Fix the issues reported by phpcs

Hi

I fix the all phpcs issues including Dependency Injection except one service,
And i didn't fix the phpcs issue in module.install file because commented code are there in that file.

Thank you!

There is a problem with the declaration of the method 'create':
Fatal error: Could not check compatibility between Drupal\imagelightbox\Plugin\Field\FieldFormatter\MediaImagelightboxFormatter::create(Drupal\imagelightbox\Plugin\Field\FieldFormatter\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) and Drupal\Core\Field\FormatterBase::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition), because class Drupal\imagelightbox\Plugin\Field\FieldFormatter\ContainerInterface is not available in /Users/pi/Sites/D10/d10/web/modules/contrib/imagelightbox/src/Plugin/Field/FieldFormatter/MediaImagelightboxFormatter.php on line 60

I think i forgot to add Symfony\Component\DependencyInjection\ContainerInterface class

I will on this provide patch

Thanks.

The patch provided in #5 resolves the error but opens a new one:

When trying to change the field formatter to ImageLightBox (/admin/structure/types/manage/BUNDLENAME/display) the ajax call does not finish.

Shorten issue description.

#8 did not work as expected... :-)

Next try: shorten issue summary.

I will remove the reported errors and raise a MR for the same.

I raised the MR which removes all the reported errors only
"unused variable $settings" need to be confirmed by the module's maintainers.
kindly review the MR.

Thank you for the effort, but your changes raised a new bug. Please test your changes before committing.

Visit /admin/structure/types/manage/BUNDLENAME/display

Fatal error: Declaration of Drupal\imagelightbox\Plugin\Field\FieldFormatter\ImagelightboxFormatter::create(Drupal\imagelightbox\Plugin\Field\FieldFormatter\ContainerInterface $container) must be compatible with Drupal\image\Plugin\Field\FieldFormatter\ImageFormatter::create(Symfony\Component\DependencyInjection\ContainerInterface $container, array $configuration, $plugin_id, $plugin_definition) in [...]/web/modules/contrib/imagelightbox/src/Plugin/Field/FieldFormatter/ImagelightboxFormatter.php on line 43

I ran phpcs and phpcbf and committed the coding style fixes without the additional changes out of scope of this issue.

Please note, that we are switching to 2.x-dev for further development as we figured it is the recommended way of not having dev-versions for every minor version.

piridium → closed merge request !6

Automatically closed - issue fixed for 2 weeks with no activity.