🇮🇳India @dineshkumarbollu

Reference document for type string https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Ajax%21Ch...

dineshkumarbollu → made their first commit to this issue’s fork.

Getting error when tring to enable the latest version.
Drupal\Core\Extension\InfoParserException: The 'core_version_requirement' constraint (^^10 || ^11) is not a valid value in modules/contrib/at_tool/at_tool.info.yml in Drupal\Core\Extension\InfoParserDynamic->parse() (line 77 of /var/www/html/diet/vb1020/web/core/lib/Drupal/Core/Extension/InfoParserDynamic.php).

Hi @Michelle-Buckby

#2 patch fixes the issue, but still i am encountering one error after enabling the module.

TypeError: array_merge(): Argument #1 must be of type array, null given in array_merge() (line 399 of /var/www/html/diet/vb101/web/modules/contrib/content_notify/content_notify.module).

Created patch for both changes

Created patch for the 2.1.x-dev

Created patch please review,Thanks

Hi @Afxsoft
In 8.x-1.4 branch D10 version is already added, and also i checked the deprecated code for module for D10, found Jquery once code, for that MR is already available, see the issue https://www.drupal.org/project/paragraphs_collapsible/issues/3380762 🐛 Replace jQuery.once() with once() Active

Hi @joachim

Based on OptionsRequestSubscriber class methods added below docs, Is this lines are good.

 * This event subscriber listens to KernelEvents::REQUEST and responds to OPTIONS requests
 * by providing an Allow header listing all the HTTP methods allowed for the requested routes.

Hi @abhishek_gupta1
Have you applied patch on 8.x-2.3 branch? I checked again in my system patch applied cleanly.

Created patch for the issue

I fixed the issue please review

Hi @jvizcarrondo

I didn't get any error in /admin/config/search after installing module in Drupal 10.2 with 8.2, am I missing anything to reproduce the issue?

dineshkumarbollu → made their first commit to this issue’s fork.

+1 for the issue

MR!19 fixes the issue, LGTM

@Steven Jones try this code in hosting_clone.drush.inc file

if (isset($task->task_args['aliases'])) {
  $task->options['aliases'] = str_replace("\n", ",", $task->task_args['aliases']);
}
if (isset($task->task_args['redirection'])) {
  $task->options['redirection'] = $task->task_args['redirection'];
}

Patch applied cleanly and fix the issue, Issue also reported in published_date module see https://www.drupal.org/project/publication_date/issues/3424575 🐛 InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() (line 201 of /var/www/html/www/core/lib/Drupal/Component/Datetime/DateTimePlus.php). Active

+1 for error, i will review patch

@erwangel
Try to add one more condition in user_menu_avatar.module to fix the issue,
if (uma_anon_markup() && is_object($menu_link['url']) && $menu_link['url']->isRouted() && $menu_link['url']->getRouteName() === "user.login") {

+1 encountering same error.

@rajeevgole
Created patch please review and test.

Hi @b_sharpe

I am interested to take maintainership, Thanks

Hi @SocialNicheGuru
I check the /admin/structure/media/manage/image/display not getting above error after enable the module.
Drupal 10.1
php 8.1

dineshkumarbollu → made their first commit to this issue’s fork.

Hi
I Install the module and tested the whitespace in olivero theme using the module, didn't encountered any whitespace.

$this->installSchema('system', 'sequences'); is deprecated in D11, see the https://www.drupal.org/node/3349345 → , created patch accordingly, please review.

Symfony\Component\Routing\Exception\RouteNotFoundException: Route "o365_sso.login_controller_login" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 206 of /var/www/html/diet/vb1020/web/core/lib/Drupal/Core/Routing/RouteProvider.php).

Complete error

dineshkumarbollu → created an issue.

Hi @quietone
#6 Needs work is due to Tests Failure?

@mondrake, Thanks for your reply, I will make MR's instead of patches from next time.

Created patch, please review.

$this->installSchema('system', 'sequences'); is deprecated in D11, see the https://www.drupal.org/node/3349345 → , created patch accordingly, please review.

@ryanrobinson_wlu the below test deprecations are not found in this module, it is occuring your system only due some other modules.

1x: The Drupal\Tests\field\Traits\EntityReferenceTestTrait is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait. See https://www.drupal.org/node/3401941
1x in KernelTestSuite::suite from Drupal\Tests\TestSuites

@shevgeny

Patch will fix the actual issue along with when install the module it throws an error.

Hi @LaRatota
In composer.json file of module add "phpoffice/phpspreadsheet": "^2.0" probably will update and download new release when install using composer.

$this->installSchema('system', 'sequences'); is deprecated in D11, see the https://www.drupal.org/node/3349345 → , created patch accordingly, please review.

@chlowden, the module is installed without any error,

The issue you are facing is related to media library configurations are already exists in DB.

hi @Anaconda777
Add condition to fix the issue,Can you provide complete steps to reproduce the issue i will work on.

if (!is_array($configuration_data)) {
        // For handling the case where configuration_data is not an array.
        return;
    }

created patch by declaring optional parameters after required parameters.

Created patch to fix the issue please review, Thanks

Hi @drunken monkey
Created patch please review,thanks

Created patch for D10 compatible, Making Active for any D10 compatible changes apart from patch changes.

dineshkumarbollu → created an issue.

Hi @mondrake

Created patch for this issue, please review.

#7 fixes the issue in admin/modules, Thanks for the patch @mekal

dineshkumarbollu → made their first commit to this issue’s fork.

Hi @mondrake
Any reason for postpone of issue,

In this issue for PHPUnit 10+, see if we can adopt a different technique instead of using standard streams.

Looking for different technique, will be good if the status is Active. Any Thoughts on this.

MR!4 fixes the error.Moving to RTBC

dineshkumarbollu → created an issue.

Hi @Ashokjey
I think jquery once dependency fix in latest release can you check the below issue will help,
https://www.drupal.org/project/cshs/issues/3347581 🐛 Drupal 10 proper once dependency Fixed

Created patch please review

Hi @msn5158
The module is officially compatible with D10 using composer, see the project page https://www.drupal.org/project/empty_page → ,
But patches are available for D10 check the issue https://www.drupal.org/project/empty_page/issues/3287186 📌 Automated Drupal 10 compatibility fixes RTBC

+1 for the issue

Created patch for this issue please review, thanks

Access checking must be explicitly specified on content entity queries, see https://www.drupal.org/node/3201242 →

dineshkumarbollu → made their first commit to this issue’s fork.

Installing module using composer causing error

Problem 1
    - Root composer.json requires drupal/social_course, it could not be found in any version, there may be a typo in the package name.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://getcomposer.org/doc/04-schema.md#minimum-stability> for more details.
 - It's a private package and you forgot to add a custom repository to find it

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

Hi @mortona2k
I tested the issue in my system, after installation won't get any error.

Drupal 10.1
php 8.2

@zebda

I think this related to TFA module, using the service of encript module.Drupal\encrypt\EncryptService service.

@Sandip Choudhury declare the variable before call, will fix the issue, I don't have D7 site currently to test and create patch.

Deprecated function: Creation of dynamic property Invite::$sendNotification is deprecated in Invite->__construct() (line 183 of /var/www/vhosts/thechoudhury.com/httpdocs/sites/all/modules/invite/includes/invite.controller.inc).

/**
   * Indicates whether notification should be sent.
   *
   * @var bool
   */
  public $sendNotification = TRUE;

@abhishek_gupta1
patch#3 fixed the issue, moving to RTBC.

@jrochate

Added condition to fix the issue, please review and test the patch.Thanks

+1 error in Fresh installation also 8.x-2.0-rc5, Is this related to Core?

Getting same error patch#3 creates new error

TypeError: Drupal\bookable_calendar\Notification::__construct(): Argument #3 ($token) must be of type Drupal\Core\Utility\Token, Drupal\Core\Messenger\Messenger given, called in /var/www/html/diet/vb1020/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\bookable_calendar\Notification->__construct() (line 65 of modules/contrib/bookable_calendar/src/Notification.php).

#4 fixes the WSOD

@ordermind

Installed in Drupal 10.2 with 8.2 unable reproduce the issue, can you steps to reproduce the issue(if i am missing anything).

dineshkumarbollu → made their first commit to this issue’s fork.

config menu is visible after the MR changes.

Created patch based on proposed solution.

@sukr_s

MR fails pipeline due to phpcs, can you fix that i can review the MR, Thanks

Found one more entityQuery in DeleteFolderForm.php file and created MR.

dineshkumarbollu → made their first commit to this issue’s fork.

The patch#3 fixes the issue

encountered few more errors in 2.3.x-dev in Drupal 10.1

created patch according to core commit and docs of user_role_names() method https://git.drupalcode.org/project/drupal/-/commit/26e376b1dff58a7644315...

@kimberly_thl try this will fix the error, but need to handle else.

public function getUsersCount($before_id = NULL) {
    $users = $this->getLicenseUsers();
    if ($users !== NULL) {
        return count(array_keys($users));
    }
}

@dbrouard

can you provide more info on steps to reproduce and complete error, i will try to test in system.

@Harpreet_singh_saluja
I think the module is not ready yet, git repo looks empty.

@VasyOK
I tried to create the MR for the issue while applying patch i got error, can you make MR for the patch because MR is best way, it will run tests also.

@VasyOK
The patch is failed to apply in 8.x-3.1

dineshkumarbollu → made their first commit to this issue’s fork.

@alshami the patch doesn't follow indentations properly.see below lines.

-    // Add attributes.
-    if (!empty($variables['settings'][$key . '-at'])) {
+      // Add attributes.
+      if (!empty($variables['settings'][$key . '-at'])) {

Hi @binnythomas
Tested on Drupal 10.2 php 8.2, still not getting the error.