Remove uses of "please" from this module

Hi @drunken monkey
Created patch please review,thanks

Hi,
If you think that 'please' should be added back to the words that contib gitlab cspell should check for, you are welcome to raise an issue on https://www.drupal.org/project/issues/gitlab_templates →

Core currently has

"flagWords": [
      "e-mail",
      "grey",
      "hte",
      "ist",
      "please",
      "queuing"
],

but gitlab templates only has

"flagWords": [
      "e-mail",
      "grey",
      "queuing"
]

Thanks for creating the patch!
This mostly already looked good, I just spotted a couple of faulty changes, and sometimes in doc comments the line wrapping was now off.
Made a few adjustments and created an MR so this can be tested.

I made a change to the .gitlab-ci.yml file in MR129 to test the new _CSPELL_FLAGWORDS variable added in #3442293: Make it easier for contrib modules to specify additional CSpell flag words →

The test worked, and found just one remaining 'please'
https://git.drupalcode.org/issue/search_api-3437275/-/jobs/1396014

Putting this back to NW for that word to be removed. Then you can decide if you keep using MR191 or wait until the functionality is available on the 'default-ref' branch.

Thanks a lot for that! In the meantime, it seems that MR was deployed to default-ref anyways, so we can even go without this temporary modifications. I added one last cspell:disable-next-line directive (I actually had already added it, just forgot to push 🤦‍♂️), the MR should pass now. If it does, I’ll merge.

Looks good now. Merged.
Thanks again, both of you!

And thank you for asking the question in the first place. The enhancement in #3442293: Make it easier for contrib modules to specify additional CSpell flag words → was good to do.

Thanks for breaking the Solr tests again ;-)

Thanks for breaking the Solr tests again ;-)

?

Thanks for breaking the Solr tests again ;-)

Sorry! 🙈

@jonathan1055: See 📌 Tests are broken since the commit of #3437275 Fixed : The Search API Solr module’s integration test asserted the presence of a particular text on the page, which we now changed, thereby breaking the tests.

If the search_api_solr tests are intrinsically linked to the search API tests, you can trigger a downstream pipeline in gitlab, so that when you test search_api you also test solr. Testing on every MR run would be over the top, but you can set the downstream test suite to be triggered manually. So when everything was ready, just before merge, you would also start the Solr tests, for a final check. That would help to avoid this kind of fault.

I already spent some tine to migrate our github based tests to gitlab. But it isn't easy as we require different Solr versions to test against.
Any help is welcome!

Automatically closed - issue fixed for 2 weeks with no activity.