- Issue created by @mingsong
- Assigned to mohd sahzad
- Status changed to Needs review
over 1 year ago 7:30am 7 February 2024 - Issue was unassigned.
- Assigned to Kristen Pol
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Assigning to myself for review.
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 3:49am 20 February 2024 - 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This cannot be committed to the existing branch since ByteSizeMarkup was added in 10.2/11.x and not available before that. In order to handle backwards compatibility, the class would need to be checked first before being used. Otherwise, we have to create another branch that's for 10.2+. Moving back to needs work in case someone wants to try to make it work for 9/10/11. Otherwise, we can postpone this one for now.
📌 Deprecate format_size() and use Drupal\Core\StringTranslation\ByteSizeMarkup instead Fixed
- Status changed to Needs review
6 months ago 5:43am 19 December 2024 Drupal 10.2 and earlier are now EOL so this should be able to go in now.
Have added changes to core requirement version.- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
This looks good to me but I'd love it if someone would test it quickly to make sure it works for you
- 🇦🇺Australia tarawij
I’ve applied and tested 3419657-10.patch → in both Drupal 10 (10.3.14) and Drupal 11 (11.0.13) environments. The patch resolves the issue as expected and I didn’t encounter any errors.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Thanks @tarawij
I appreciate the extra eyes. I don't use this module and was not the original creator of the code. And, I've been slammed with a gazillion things :)
I'll merge this shortly.
- 🇺🇸United States Kristen Pol Santa Cruz, CA, USA
Merged :)
Thanks, everyone!