πŸ‡¦πŸ‡Ί
Account created on 10 August 2014, over 9 years ago
#

Merge Requests

More

Recent comments

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

A quick thought in my mind is that,

You can create a content type in which you want the calendar is displayed, for instance, a content type called "Calendar".

This content type only need the tile and body filed.

Then you can create a new node of that content type. At this point, you will get a page of that node with the URL(page alia) you want.

In the block setting, specify the visibility to limit only that page (URL) this block can show up.

https://www.drupal.org/docs/core-modules-and-themes/core-modules/block-m... β†’

In terms of replicating between themes, you probably has to manually do that for each theme. Maybe there is another better way to do that.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Good point.

Generally speaking, I would suggest that when we alter a form from other modules, such as overriding the '#default_value', we can also modifying the description of that field if it hasn't been hidden. For instance,

  $origin_description = $form[$key]['#description'] ?? '';
  $form[$key]['#default_value'] = $this->token->replace($default);
  $form[$key]['#description'] =  $origin_description . $this->t( ' (This value is managed by Synfony mailer policies below)');  
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Create a MR.

Let's go from there.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

True.

Regarding the '#default_value', it also affect when the Contact form is edited and saved. Because the form altered by

https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/MailerH...

Agree, it is not idea and won't work for all scenarios.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Minimally maintained, in other words, bug fixing only.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

@Adam, so does it mean we need to keep $message['headers']['Reply-To'] and meanwhile also need another header $message['headers']['reply-to']?

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Absolutely agreed. It is very complicated.

If we introduce a new token, for example [symfony_mailer:address:to], and then use this token as the default value of a contact form, instead of the hardcode one [site:mail] in the following line.

https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/Plugin/...

This token will be replaced with the correct recipient address via the following line.

https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/MailerH...

If this approach works, it would be way simper and also leave the origin config untouched.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

For a better compatibility with other modules, including core modules, I would suggest keeping the recipients field of a contact form entity identical to the mailer policy's setting.

The reason is that, other module might still rely on that field of a contact form entity. Hiding recipient from "Contact forms" page would cause confusions to other module's users.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Why don't we just change the line 96 from

$message['headers'][$name] = $header->getBodyAsString();

to

$message['headers'][$lc_name] = $header->getBodyAsString();

The idea is to use the lower case name instead of the original name.

Create a new MR for the new approach.

https://git.drupalcode.org/project/symfony_mailer/-/merge_requests/87

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks @Si,

Yes, please create a MR, we can go from there.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Another problem with the translation of an email is that, the configuration of an adjuster plugin is loaded in the default language when the plugin is initiated.
Even if the languageManager->setConfigOverrideLanguage($language) is called after that, the configuration loaded before won't be changed, until the configuration is loaded again.

So if I add the following preRender function to SubjectEmailAdjuster class,

  public function preRender(EmailInterface $email) {
    $mail_config = \Drupal::config('symfony_mailer.mailer_policy.user.status_activated');

    $config = $mail_config->get('configuration.email_subject');

    if (isset($config['value'])) {
      $subject = $config['value'];
    }
    else {
      $subject = $this->configuration['value'];
    }

    $email->setSubject($subject, TRUE);
  }

Then the email subject is translated to the user language.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Right. after debugging the code, I think I figure out what is happening here.

In the Mailer::doSend() function,

https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/Mailer....

We have four phases to process an email.

In phase 'build', https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/Mailer....

The email body, subject and other contents were built in the default language since the configuration language hasn't been changed yet.

After that, the language will be changed to user's language at line 224
https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/Mailer....

Next phase is 'PHASE_PRE_RENDER', in this phase, the $email->process() will call the 'preRend()' function for each email adjuster, including the subject and body adjuster.
BodyEmailAdjuster https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/Plugin/...
SubjectEmailAdjuster https://git.drupalcode.org/project/symfony_mailer/-/blob/1.x/src/Plugin/...

But the problem is that those email address doesn't have the preRend() fuction, so they won't change anything. The email subject and body still remain in the default language.

And so on, after this stage, all coming phase won't change the language at all.

So that is why the email will always be built in the default language of the website.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

I tested this issue with
Drupal 10.2.3
Symfony Mailer 1.4.1

And two issues I came across

  1. Imported policies didn't load the translation email content.
  2. Translate mailer policy wasn't applied to the email sent to the user in user's language.
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

External events mean creating a new event by dropping an event from outside of the calendar, right? I don’t think this module provides this functionality.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

This Drupal view doesn’t support this functionality.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks @Damien,

According to my quick local test.

The cardinality box is still hiding as what it looked like in Drupal 10.1

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Here is the document from Fullcalendar V5,

https://fullcalendar.io/docs/v5/events-json-feed

https://fullcalendar.io/docs/v5/eventClick

The key point from the documents above is that

Normally, if the Event Object has its url property set...

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

No problem. It is good to know that you are on track to fix it for your site.

Good luck.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks @Oscar EmbΓΊn.

Could you please create a merge request for this new feature. I can create one for you, but you can't commit any change to the one I create, as the branch was created by me.

Also, I wonder if the the option 'dialogCanvas' should be boolean rather than an integer?

The reason I ask because we have to update the schema file for any new options.

https://git.drupalcode.org/project/fullcalendar_view/-/blob/5.1.13/confi...

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Still not enough information for me to know what happened to your website.

Given that, this version was released last year September and there are 8.5 thousand websites using this version currently. This is the first time I heard this kind of issue.

I would suggest that have someone with Drupal developer background to have a closer look at and debug this issue for you.

Particularly looking at any other module or theme that modifiers the template used by the calendar.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Does this issue only occur in 5.1.13?
What changes did you make before this happened?
Any errors or warnings in the log or browser console?

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Looks like this issue has been reported by another one.

πŸ› Error on aggregated css files for users forced to reset password RTBC

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thank you raising this issue and the patch.

It looks good to me.

One more minor thing that is nice to have is to change the default of option 'dialogModal' from 0 to FALSE since the type is changed to boolean.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks you all.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks everyone for working on this.

Here is the patch of the MR, in case anyone want to test it via a patch.

https://git.drupalcode.org/project/fullcalendar_block/-/merge_requests/1...

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks @larowlan, I changed the approach to check if a file is downloadable for public.

The changes from previous are,

https://git.drupalcode.org/project/file_to_media/-/merge_requests/1/diff...

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

@Conrad, first release is out. You can close this issue now if you like.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks @Conrad.

I was confused by the module name. There are multiple module ecosystems call 'Two Factor Authentication'.

I think I got it right now.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

It has been 6 years.

I think it is time to have a contribute module for this feature.

https://www.drupal.org/project/tfa_email_otp β†’

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Good question.

This module was created back to 2021, when those modules were not available(maybe some of them were).

Functionality-wise, I haven't looked at all those modules including the new features from core closely. As far as I can tell, this module (Entity Diff UI) doesn't only provides revision overview page(tab), but also provides the comparison between revisions.

Maybe there are other modules provide this functionality too. Again, this module was created in 2021 and pretty much no further development ahead.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Mingsong β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

@Niels, thanks for offering the help.

I just sent you an email to discuss your kind help.

Looking forward to hearing from you.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

This module has been looking for a maintainer to take over, who will be in charge of D10 versions and beyond.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

The MR also fixed some code standard issues.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

It’s duplicated to πŸ› Getting Js error of calendar_options Closed: works as designed

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Till 19th November, there were 7,116 sites using this version.

As the release notes suggested, If your theme/module/patch overrided the calendar view template, you have to make sure following template variables available to your view template and are appropriate populated.

* - options: View plugin style options:
* - classes: CSS classes.
* - defaultDate: Default date of the calendar
* - start: Field name of start date
* - end: Field name of end date
* - languageSelector: Flag for the language dropdown box
* - view_index: View index
* - view_id: The id of the view
* - display_id: The view display id
* - showAddEvent: Show add event button
* - entity_id: The Entity type machine name

For example, your template must have the following line.

πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

The patch to fix this issue including new test.

The changes made by this patch are:

  • Creating a new media entity for a private file will be forbidden. (403)
  • Remove the link to create a new media entity for a private file in the files overview.
  • New test to cover the use case of private file.
πŸ‡¦πŸ‡ΊAustralia Mingsong πŸ‡¦πŸ‡Ί

Thanks @Niels for looking into it.

Yes, that is right. That patch has been merged into the develop branch.

As I explained in #11 πŸ“Œ Remove deprecated MediaRevisionAccessCheck in Drupal 10 Fixed The reason why no release for it is that the change involved access checking, in other words, it requires a security review closely. Develop version means not ready for production yet, but for testing.

Production build https://api.contrib.social 0.61.6-2-g546bc20