- 🇹🇭Thailand Nick Hope
Re-roll for 2.1.0 and the current 2.x-dev, which upgraded the jsTree version, meaning patch #27 would no longer apply.
Besides adding an inline widget, the patch also removes whitespace in entity_reference_tree_libraries.yml, as did patch #27.
- Assigned to Nick Hope
- Status changed to Needs work
about 2 years ago 4:37am 24 February 2023 - 🇹🇭Thailand Nick Hope
No longer applies to 2.2.0. I will attempt to re-roll.
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 5:52am 24 February 2023 - 🇹🇭Thailand Nick Hope
Re-roll for 2.2.0, required because the jsTree version changed from 3.3.14 to 3.3.15. The files entity_reference_tree_inline.js and InlineEntityReferenceTreeWidget.php still work in their original form from #27 and are unchanged. This patch does not include the jsTree version number, so hopefully another new patch should not be required if just the jsTree version changes.
I would like to see this committed, but if it is never likely to be, perhaps it should become a separate module. @Mingsong, what are your thoughts?
- 🇦🇺Australia mingsong 🇦🇺
Hi @Nick,
Thanks for working on it.
As it is a big change from 2.x branch, I created a new branch called 3.x for any experiment new feature like this one.
I also create a new fork and a new branch for this issue specificly.
https://git.drupalcode.org/issue/entity_reference_tree-3059845/-/tree/30...
Please free feel to work on this branch and create a merge request that aims to 3.x branch.
Once we have the branch ready and tested by others. I am happy to release the 3.x branch to see how popular the new feature is.
- Status changed to Needs work
about 2 years ago 11:15pm 24 February 2023 - 🇦🇺Australia mingsong 🇦🇺
At this stage, we need:
- Apply the patch to the feature branch.
- Create a merge request for merging the feature branch into 3.x branch.
- Test the feature branch.
- Merge into 3.x branch if it is tested and reviewed by the community.
- Release 3.x branch to allow more people to use it via Composer.
- 🇦🇺Australia mingsong 🇦🇺
Sorry forgot to mention that anyone is more than welcome to create your own module that works with this module.
That is one of the reasons why we uses open source or Drupal, right?
- Merge request !13Issue #3059845: Update branch to match latest 2.x-dev and add support for... → (Merged) created by Unnamed author
- 🇹🇭Thailand Nick Hope
Updated branch 3059845-1 to match the latest 2.x.dev code.
Added support for inline widget display compatible with Drupal 10.
Fixed the "Selected (X of Y):" text. I am not sure it was ever working in the inline version.
Made merge Request against 3.x branch: https://git.drupalcode.org/project/entity_reference_tree/-/merge_request...
The patch can be applied to version 2.4.0.
-
mingsong →
committed c5f240db on 3.x authored by
geoffreyr →
Issue #3059845: Update branch to match latest 2.x-dev and add support...
-
mingsong →
committed c5f240db on 3.x authored by
geoffreyr →
- 🇦🇺Australia mingsong 🇦🇺
The 3.x develop branch download link.
https://www.drupal.org/project/entity_reference_tree/releases/3.x-dev →
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Error thrown in browser console if field is mandatory.
This is preventing entity from saving