🇮🇳India @gaurav_manerkar

Please review.

Fix for issue described in #40

Issue:
When link field is made untranslatable for a particular menu type from /admin/config/regional/content-language, I get the following error:

Error: Call to undefined method Drupal\Core\Field\Entity\BaseFieldOverride::setItemDefinition() in Drupal\menu_link_content\Entity\MenuLinkContent->setTranslationConstraints() (line 444 of /var/www/html/docroot/core/modules/menu_link_content/src/Entity/MenuLinkContent.php).

While debugging, i found that when link field is translatable, the $item_definition object is instance of class Drupal\Core\Field\BaseFieldDefinition and when non-translatable, the object is instance of class Drupal\Core\Field\Entity\BaseFieldOverride where `setItemDefinition` method is not defined.

Updated patch to cover cases when placeholder value is NULL.

gaurav_manerkar → created an issue.

Created patch instead of MR due to git access problem

gaurav_manerkar → created an issue. See original summary → .

Hi @florianmuellerch,
I don't like the idea of adding new fields to an existing user's view.
What if the module users have already used a customized view? Overwriting the view may break something.

gaurav_manerkar → created an issue.

gaurav_manerkar → created an issue.

If we cannot reproduce this issue, then we should close this.

Pls review.

@el7cosmos
There are other PHPcs issues that need to be fixed.

done

@priyanka_chauhan31
I have updated issue summary with cspell errors.

Please review.
The coding standards issues will be fixed in https://www.drupal.org/project/text_field_formatter/issues/3474000 📌 Coding Standard Issues Active .
Thanks

gaurav_manerkar → created an issue.

gaurav_manerkar → changed the visibility of the branch project-update-bot-only to hidden.

Hi @wkozlowski,
I see MR is merged,
Please grant issue credits and mark this issue as fixed.

gaurav_manerkar → changed the visibility of the branch 3.x to hidden.

Please review.

gaurav_manerkar → created an issue.

Instead of posting on closed issue, please create follow-up issue for this

Pls review.

Hi @cleavinjosh / @lavanyatalwar,

I have updated phpcs rules to highlight code standard errors on gitlab-ci.
https://git.drupalcode.org/issue/hook_event_dispatcher-3486944/-/jobs/34...

Let me know if any of you are going to fix the remaining issues.

Thanks.

Done for both unban as well as ban confirmation forms.
Thanks

Hi @asawari,

Pls add a "file" type field to your local drupal site to see field on configuration form.

Thanks

Updated drupal commands and README file.
Pls review, Thanx.

Please review MR!!
Thanx.

gaurav_manerkar → created an issue.

Tested on drupal 11, looks fine
MR https://git.drupalcode.org/project/simple_wysiwyg/-/merge_requests/7/diffs can be merged.

Thanks

Fixed all coding standard issues
Added gitlab-ci.yml file

Pls review

gaurav_manerkar → created an issue.

Tested on drupal 11, looks fine.
MR can be merged.

Please review.

Hi, patches are outdated, please provide merge request.
Also consider making module available for D11.

Thanks

Done, pls review.

I am not able to reproduce this issue.
Please try flushing cache or provide more details

Pls review.
Thanks

Please review mr.

Please review MR.
Thanks

Please review: https://git.drupalcode.org/project/entity_language_fallback/-/merge_requ...

gaurav_manerkar → changed the visibility of the branch 3421360-php-8.2-deprecation-errors to active.

gaurav_manerkar → changed the visibility of the branch 3421360-php-8.2-deprecation to hidden.

Rebased with latest changes.

Fixed all issues, please review.
Thanks!!

gaurav_manerkar → changed the visibility of the branch 3421360-php-8.2-deprecation-errors to hidden.

gaurav_manerkar → changed the visibility of the branch 3421360-php-8.2-deprecation to active.

gaurav_manerkar → changed the visibility of the branch 3421360-php-8.2-deprecation to hidden.

MR is ready for review.

Updated MR, thanks!!

Hi @cleavinjosh,
We should also update phpcs.xml.dist file from the module for gitlab-ci to log warninings,

Please review MR - https://git.drupalcode.org/project/hook_event_dispatcher/-/merge_request...

Updated MR with the changes
https://git.drupalcode.org/project/tmgmt/-/merge_requests/58/diffs

Please review.

Added, thanks

Thanks @lavanyatalwar looks good.

MR rebased with latest 8.x-6.x branch.

gaurav_manerkar → created an issue.

gaurav_manerkar → created an issue.

Please review mr - https://git.drupalcode.org/project/hook_event_dispatcher/-/merge_request...

gaurav_manerkar → created an issue.

gaurav_manerkar → made their first commit to this issue’s fork.

gaurav_manerkar → made their first commit to this issue’s fork.

We are facing issue because of this change. Conditional #states JS are not getting replied when element is refreshed/rendered by JS

Hi,

I have moved content_moderation_update_110001 to `content_moderation.post_update.php` file to prevent any feature conflict with hook_update_N implementations

Looks good, thanks.