- First commit to issue fork.
- Merge request !58Issue #3298245: Hook to allow modules to alter translation entity being created โ (Open) created by duaelfr
- last update
over 1 year ago 118 pass - ๐ซ๐ทFrance duaelfr Montpellier, France
I needed that so I rerolled #14 into a MR.
For those who need it right now and don't want to jump on the dev release, here is a patch against the 1.15 version. - First commit to issue fork.
- Status changed to Needs work
11 months ago 9:40pm 3 September 2024 - ๐จ๐ญSwitzerland berdir Switzerland
Thanks for the MR.
Some thoughts.
a) Since this is in tmgmt_content, the hook should be namespaced tmgmt_content, so it doesn't conflict if we'd add the same to another source.
b) Should $data be passed to the hook? you might want to use the information in there? - Issue was unassigned.
- Status changed to Needs review
9 months ago 5:07am 14 November 2024 - ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
Updated MR with the changes
https://git.drupalcode.org/project/tmgmt/-/merge_requests/58/diffsPlease review.
- ๐ง๐พBelarus Alexey_Samsonov
Hook works as expected. Tested for 10.3.x version.
- ๐ฎ๐ณIndia gaurav_manerkar Vasco Da Gama, Goa
Rebased with latest changes.
- ๐ต๐นPortugal joao.ramos.costa
joao.ramos.costa โ made their first commit to this issueโs fork.
- ๐ต๐นPortugal joao.ramos.costa
Hi @garauv_manerkar,
I've opened a MR against !58 passing the job item to the hook as well, since it can contain useful information about the job โ for example, the translator plugin used.
This can be important, as different plugins might behave differently (e.g., some might auto-accept translations while others donโt), and having access to the job item allows developers to adjust their logic accordingly within the hook.WDYT ?