- Issue created by @dinarcon
- Merge request !3Issue #3487890: Added drush commands AUTO_INCREMENT for alter operations → (Merged) created by gaurav_manerkar
- 🇳🇮Nicaragua dinarcon
Thanks for working on this @gaurav_manerkar
Drush 11 and prior required dependency injection via a drush.services.yml file. This approach is deprecated in Drush 12+ and removed in Drush 13. See https://www.drush.org/13.x/dependency-injection/ While Drush 11 could work with Drupal 10, that version has been EOL for about a year. Let's not use services files. See https://www.drush.org/13.x/commands/ for the recommended way to author Drush commands.
Also, a few new methods are being worked on. Once the following issues land, let's add Drush commands for the methods introduced in them:
- 🇳🇮Nicaragua dinarcon
✨ Get the current AUTO_INCREMENT value for a table Active has landed. Let's revisit this issue.
- 🇮🇳India gaurav_manerkar Vasco Da Gama, Goa
Updated drupal commands and README file.
Pls review, Thanx. - 🇳🇮Nicaragua dinarcon
Great work @gaurav_manerkar! A few things I would like to include before merging.
- Rename the
ignore-auto-increment-column
option of thegetAllTableAutoIncrementValues
command tounfiltered
. - No need to provide validation for the entity group/type in
getEntityList
. - Change
group
ingetEntityList
from argument to option.
Once the changes are implemented, let's update the README.md accordingly.
- Rename the
- First commit to issue fork.
- 🇳🇮Nicaragua baltowen
I tested all commands and they work as expected. @dinarcon asked to rename the
ignore-auto-increment-column
option tounfiltered
, but the actual nameonly-with-auto-increment-column
was different from the instruction. As a suggestion it would be better to rename this option toall
, since it's concise and clear to understand. -
dinarcon →
committed 40405c70 on 1.0.x authored by
gaurav_manerkar →
Issue #3487890 by gaurav_manerkar, dinarcon, baltowen: Provide Drush...
-
dinarcon →
committed 40405c70 on 1.0.x authored by
gaurav_manerkar →
- 🇳🇮Nicaragua dinarcon
Thanks @baltowen and @gaurav_manerkar for working on this! After implementing the suggestion to use
--all
as the option name, I reviewed and updated other function names and parameters. I also updated the Drush command names and included shorter aliases. Automatically closed - issue fixed for 2 weeks with no activity.