- Issue created by @mingsong
- Merge request !53Issue #3492128 by mingsong: Increase the maximum value of zoom finer to 10 โ (Merged) created by mingsong
- ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks for this suggestion, I left two comments in the MR.
- ๐ฆ๐บAustralia mingsong ๐ฆ๐บ
Thanks @ressa, I updated the description as suggested.
Regarding the minimum value, I don't know if there is any use case needed a -10 finer value. I only tested 4 Google maps, which all have a small default zoom value.
As it will still be constrained by the min and max zoom value, I think it is fine to allow as small as -10 as the finer value. But I am not sure about that. I change to 'need review' to indicate that this issue needs review.
- ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks! Maybe you can set the comments to "resolved"?
I am not sure if -10 makes sense. But I don't see any harm in allowing it, in case someone want to use it at some point ... why limit the users?
- ๐ฆ๐บAustralia mingsong ๐ฆ๐บ
I feel the same. I don't have the answer for that.
It is a question from the first place, why we need to limit the input value from 5 to -5?
Hope someone know the background can help us out.
- ๐ฉ๐ฐDenmark ressa Copenhagen
All right, since it can't harm, I think we should just set both to -10 and 10. There's no reason to limit the users.
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
prem suthar โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
Update The MR As per #11 Suggestion please review .
- First commit to issue fork.
-
itamair โ
committed 63f8e0b1 on 10.2.x authored by
mingsong โ
Issue #3492128 by mingsong, prem suthar, ressa: Increase the maximum...
-
itamair โ
committed 63f8e0b1 on 10.2.x authored by
mingsong โ
- ๐ฎ๐นItaly itamair
Thanks here, nice contribution ... I just merged the MR !53 and I am closing this as Fixed
(and providing credits to all of you) Automatically closed - issue fixed for 2 weeks with no activity.