Copenhagen
Account created on 9 January 2007, about 17 years ago
  • Site builder at ArdeaΒ 
#

Merge Requests

More

Recent comments

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for confirming, let's hope Add support for diff_id in links to file in merge requests will add this before too long:

If you switch between different versions of a merge request you won't be able to link to a file or a file line for this specific version. The link to the file or the file line always points to the latest version. We should incorporate diff_id parameter for these links to support linking to different versions of the MR in files.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@FMB: Following your steps, I get the same patch, which is the latest:

Compare 2.x and latest

Compare 2.x and version 1

Both 129.diff?diff_id=648306 and 129.diff?diff_id=419569 result in this, where version 1 (diff_id=419569) should be protected $transliterateDisplayValue;:

diff --git a/src/Result/Result.php b/src/Result/Result.php
index 334dc68559ba310b8743a188a66a2f1075e059b1..6ae88d99d980745766da700f8e2eb5eef779ebfa 100644
--- a/src/Result/Result.php
+++ b/src/Result/Result.php
@@ -73,6 +73,20 @@ class Result implements ResultInterface {
    */
   protected $children = [];
 
+  /**
+   * The facet transliterate display value.
+   *
+   * @var string
+   */
+  public $transliterateDisplayValue;
+
+  /**
+   * The term weight.
+   *
+   * @var int
+   */
+  public $termWeight;
+
   /**
    * Constructs a new result value object.
    *
πŸ‡©πŸ‡°Denmark ressa Copenhagen
πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for creating this issue @eojthebrave. Do you think DDEV could get a mention in the User Guide, since it is now the recommended development tool? I'll add it in the Issue Summary, and then we can decide.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Great idea, thanks @mindaugasd.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Yes, the patches look the same, I am not sure it's possible to pin a .diff file to a specific commit point in history, yet. The problem is that the patch MR content can change on each commit, and that's a security risk:

Warning

Hotlinking to remotely hosted patches, whether on Drupal.org or another service is not recommended. A remotely hosted patch file might become inaccessible due to an outage, or even deletion, and in a worse case scenario the contents of a remotely hosted patch file can be changed which creates a risk of malicious code. 

For the integrity of your build chain, it is best practice to commit your patch files to a local repository. 

from https://www.drupal.org/docs/develop/using-composer/manage-dependencies#p... β†’

Also, I have now read the article Apply Drupal 9 patches with composer closer, shared in #19 πŸ› PHP 8.2 compatibility for the 2.0.x branch RTBC , and that is NOT how to do it. Apply it with Composer, yes -- but the only safe method is to download the patch, not hotlink it to a remote hosted patch.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for clarifying the situation with being free, and the limitations. I'll change the issue titel to being Hugging Face specific.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Have you found a way to integrate https://github.com/mermaid-js/mermaid in PHPStorm @smustgrave? Because I only used https://mermaid.live, and the result on Gitlab, not any local dev tools.

@fjgarlin: Could you render the diagram locally?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

You're welcome @Marcus_Johansson, I am also very thankful for your great work here :)

Your steps were perfectly understandable (only minor detail was step #10 "Article" > "Body") and I just generated a summary of the article https://evolvingweb.com/blog/what-is-drupal:

At its core, Drupal is a content management system (CMS) A CMS gives non-developers a way to create, structure, update, and manage content. A DXP is an integrated set of technologies that deliver user experiences across various digital touchpoints. Evolving Web partners with Acquiaβ€”an open-source DXP designed solely for Drupal.

The returned text resume itself is not fantastic, but as a proof of concept -- that Hugging Face works with AI Interpolator, it's perfect!

And it worked for free, just by creating an account and using my Hugging Face token. I can't see there's any active metering on my account, with any limit ... Is https://www.drupal.org/project/huggingface β†’ maybe using this model? https://huggingface.co/docs/api-inference/faq

We can turn this into a Hugging Face issue again, or we could also keep this issue as is, and use it as a meta issue, for several more LLM integrations? It's up to you what you prefer.

I have created an issue for Ollama support, and added it in the Summary.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

ressa β†’ created an issue.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @SKAUGHT, much better with a link to the View list! I have updated the MR with that. And it sounds great @rkoller, thanks for giving this some attention in the UX meeting!

Appending "disabled" to the title is a great suggestion, and makes sense.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Yes @SKAUGHT, it would be nice with a disable/enable option on the edit page.

I removed the visually-hidden text, and updated the MR with your suggestions. I previously had a problem using h2, but now it seems to work ... Maybe P tag is too small, and h2 better?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

The new design is great, thanks! I wanted to try it, and thought something was wrong: I opened the Article "Manage fields" and there was no "Re-use an existing field" button ... for logical reasons. So I created ✨ Alert that no fields can be re-used? Active .

πŸ‡©πŸ‡°Denmark ressa Copenhagen

ressa β†’ created an issue.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

I believe that @Anybody is fairly busy currently, but if you want to improve the handling of CDNs in the Webform module, feel free to create an MR for πŸ“Œ Allow to disable (dynamic) CDN loading of libraries in general Active , integrating his function into the module.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

So it is not recommended to use CDNs. But I understand discouraging bundling of JS libs as an implicit recommendation to provide and use CDN based solutions by default.

Well, this was the wording on Including 3rd party libraries β†’ :

Instead, you should include third party libraries through either Composer, by using a CDN (Content Delivery Network), or by using the Libraries API β†’ module.

September 2020 version: https://www.drupal.org/node/2947530/revisions/12063740/view β†’

If you use the order of elements as a guide, since Composer is mentioned first, before CDN -- my take would be that Composer was recommended over CDN. Also, that page was last updated in 2020.

I updated the order on Including 3rd party libraries β†’ , placing CDN last with a warning that it is not recommended, so that Composer and Libraries API module now come first. Feel free to update the page, if you feel it can be improved.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Re-order the three methods, to emphasize that CDN's are not recommended:

  • Composer
  • Libraries API module
  • CDN (not recommended)
πŸ‡©πŸ‡°Denmark ressa Copenhagen

Perfect, thanks @GΓ‘bor Hojtsy!

Should the text on https://www.drupal.org/project/drupal/releases/11.x-dev β†’ be updated and the mention that it is a temporary measure and no release will ever be tagged be removed, or perhaps a https://www.drupal.org/project/drupal/releases/11.0.x-dev β†’ will be created eventually?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Great work, thanks @eojthebrave! It's fascinating to see just how many improvements have been made to the Drupal interface between D9 to D10, and the many screenshots which needed updating. It looks great, and I can't wait to read the Drupal 10 User Guide.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @eojthebrave, I am very much looking forward to the Drupal 10 version.

Since Drupal 11 is now open for development β†’ and planned to be released in June/July or December 2024, perhaps an issue for Drupal 11 edition should be created?

Wouldn't it be awesome to be able to release a Drupal 11 User Guide, right after Drupal 11 was released? I guess first step would be to add version 11.x as an option here in the User Guide project?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

This seems like a good call, if it simplifies the process, and makes releasing new editions easier. The article E-Book Formats - Choose the right one for your book from July 2022 has this table, where it can be seen that the three E-book readers support either PDF or ePub:

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @MacSim, but it's not clear where diff_id=648306 can be found ...

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Yes, being able to enable and disable a view directly on the view edit page is missing, so I created follow up issue ✨ Enable/Disable View within View Edit page Active to solve that. I have now added it in the Issue Summary, which I forgot. Sorry about that.

In my opinion, making the disabled view status obvious is priority number 1, and probably easiest, and disabling/enabling in the edit form can be handled separately.

What do you think of the visually-hidden span text I added yesterday, as recommended by @rkoller?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Using the variant with wikimedia/composer-merge-plugin added another 29MB of JS folders (tested 2023-09, numbers may differ today). webform.libraries.yml has 1346 lines of code with 13 CDN based libraries.

You don't have to use, nor download, all 13 libraries. As a start, disable the ones you don't need under /admin/structure/webform/config/libraries. To not download all libraries, remove the ones you don't need from the list in web/modules/contrib/webform/composer.libraries.json:

"require": {
    "codemirror/codemirror": "*",
    "jquery/chosen": "*",
    "jquery/geocomplete": "*",
    "jquery/hotkeys": "*",
    "jquery/icheck": "*",
    "jquery/image-picker": "*",
    "jquery/inputmask": "*",
    "jquery/intl-tel-input": "*",
    "jquery/rateit": "*",
    "jquery/select2": "*",
    "jquery/textcounter": "*",
    "jquery/timepicker": "*",
    "jquery/toggles": "*",
    "popperjs/popperjs": "*",
    "progress-tracker/progress-tracker": "*",
    "signature_pad/signature_pad": "*",
    "svg-pan-zoom/svg-pan-zoom": "*",
    "tabby/tabby": "*",
    "tippyjs/tippyjs": "*"
},
πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for sharing the comment from Slack @smustgrave.

@rkoller: I tried to add the warning visually-hidden as well, was it something like that you meant?

@SKAUGHT: Thank you for sharing the report from 2020. And yes, disabled displays now have an alert text "This display is disabled.", which is great. But the aim of this issue is to show a message when the entire view is disabled, not just a display.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for sharing it in the first place @Anybody. And yes, GDPR is so far only a thing in EU, but with ~450 mio. people, it's not exactly a small portion of the world :)

Also, you could argue that any effort made to respect user privacy is always good, looking at it from a moral point of view. You could even argue that user data protection and human rights largely overlap, as the author does in Data Protection and Human Rights: A Global Perspective.

If you were to create an MR, I would be very much ready to test it.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @Marcus_Johansson, that sounds fantastic! I see now that I forgot to update the title, which I'll do now, to make it less HuggingFace-centric.

Perhaps this issue could be a meta-issue, for supporting different AI-services?

And, of course, feel free to edit any part of the Issue Summary, to make it more precise.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

About Webform and GDPR: If you download the libraries to the correct folder, they will be used, and not CDN. But I agree that it would be great for GDPR to be able to disable all CDN's, so I reopened the issue you referred to ( πŸ“Œ Allow to disable (dynamic) CDN loading of libraries in general Active ) and suggested that.

About using CDN's, it is actually recommended to NOT use them on several Drupal documentation pages:

[...] It is recommended that these libraries are installed in your Drupal installation's /libraries or /web/libraries directory. If these libraries are not installed, they will be automatically loaded from a CDN.

https://www.drupal.org/docs/contributed-modules/webform/webform-libraries β†’

Note that it is in general not a good idea to load libraries from a CDN; avoid this if possible. It introduces more points of failure both performance- and security-wise, requires more TCP/IP connections to be set up, and usually is not in the browser cache anyway. [...]

Please correct it, where you found the opposite recommendation for CDN's, or supply a link here.

About Webform being bloated ... Well, this is open source, and no one is stopping you from creating a few MRs, and start slimming it down :)

πŸ‡©πŸ‡°Denmark ressa Copenhagen

I just re-read the whole issue, and gained a better understanding of the problem.

Perhaps the function in #8 could be considered to get added in Webform, as a global checkbox option?

[x] Never load libraries from a CDN

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Could something like the method used in Tagify work for Webform? It checks if a library is present, and uses that if it is. If it's not present, only then does it get the library from a CDN: https://git.drupalcode.org/project/tagify/-/blob/1.2.x/tagify.module

Or is that what #8 does? If yes -- perhaps an MR could get created, and eventually committed?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

No reason to be sorry @hansfn, you are doing a stellar job with keeping the documentation in good shape, and I am very grateful for that.

Feel free to chime in, in #3314821: Add new Menu column and filter to Documentation management page (view) β†’ , if you agree that adding a "Menu" column and filter, could be a help.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Awesome documentation pages such as Tricks for using Composer in local development β†’ are still lingering in limbo for long time ...

I sincerely feel that this is such as major problem for the Documentation on drupal.org, that I am bumping this feature request up to Major.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for the fast reply @ultimike, I do think that the current debate is healthy and we are making progress, and feel we pretty close now. I much prefer discussion to silence :)

About "3. To .gitignore or example.gitignore - undecided.":

Actually, I think that if we go with .gitignore, and then it is customized, the next time drupal-core-scaffold runs, it will overwrite the changes - just like what happens if robots.txt or .htaccess is customized.

That does seem to be the case ... But it looks like .gitignore can be excluded from any further updates during scaffolding, by setting the file-mapping value to false. See Drupal's Composer Scaffold > Excluding scaffold files β†’ .

I have tried to add this to the MR.

To experiment with excluding a file from getting updated in a standard drupal/recommended-project installation with an existing scaffolded file, try adding the below snippet, edit the /web/.htaccess file, and update with or without it being excluded. The file is overwritten with default set up, but excluded from updates when file-mapping is set to false.

"file-mapping": {
    "[web-root]/.htaccess": false
}

It would be great to be able to actually test the patch with Composer commands locally, and have it do the scaffolding. Tricks for using Composer in local development β†’ exists, but is only for contrib modules, so far.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

This is awesome documentation, and it should be added to the menu as soon as possible.

I would like to be able to scaffold Drupal locally, working on ✨ Add gitignore(s) to Composer-ready project templates Needs work , so I am looking for a similar page for Drupal core development using Composer.

If documentation for developing Composer and Drupal core doesn't exist, it would be a big help if it got created, and I would definitely review it right away, if it got created. Or perhaps it could be added to this page?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Would it be possible to add an upgrade path for existing facets? Because it looks like the patch doesn't take effect on already existing facets ... Reinstalling and reconfiguring the facets is not that big a task, so it's not a big deal, more like a nice to have.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

The patch applies against 2.0.x-dev (with a single offset) and works well. I get a working "reset"option, after enabling it.

Disregard my comment about building it for standard Slider in #13. I actually only need it for Range Slider, and the current patch works well for this.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Fix "Added a 'eset' boolean field" to reset in issue Summary :)

πŸ‡©πŸ‡°Denmark ressa Copenhagen

No luck, I am getting this message, after clicking "Create new branch":

Failed to create branch '3205381-allow-the-user-2x': invalid reference name '2.0.x'

It looks like it's not possible via Gitlab GUI, but using Git via command line is necessary:

Pulling in new branches from an issue fork's parent β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Changing version to 2.0.x, since I can't create a new branch with 3.0.x ...

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thank you very much for building this @idiaz.roncero. So it works, but only tests are missing?

@james.williams: It does look like the reset function could be added in Slider instead, since RangeSliderWidget extends SliderWidget ... If it was added in Slider, would it not then be available for both "Slider" as well as "Range slider"?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@VladimirAus: It looks like the README is ready, or do you think it needs more work?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

I wonder if this could get committed? It seems like a small change, which would be an improvement for the Drupal community.

There are multiple new posts every day in the Drupal Forums, getting many answers, and the Drupal Forums are thriving, so let's drive even more traffic in their direction.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Nice catch @Mithun S :)

I didn't actually change text size via CSS, it was an odd side effect of adding a H2 tag ... I have instead added an exclamation emoji to draw attention, as well as a line break which is allowed inside an <h1> tag:

[...] you can use the following convenient elements inside of a header tag in HTML5: a, em, strong, code, cite, span, br, img.

From https://stackoverflow.com/a/19779520.

Also, <h1 class="unit-title clearfix">⚠️ Note: This view is disabled.<br>Displays</h1> validates on https://validator.w3.org/nu/#textarea.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Limit the grey background to the view region.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for the feedback @smustgrave, let's try with grey instead.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for the fast review @Mithun S, I really appreciate it.

And yes, you're right -- it's best if it's translatable, and I have updated the MR.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for sharing, and I also remember Flash. I once interned in a company, who were building a medical information web site in Flash. Ouch. It was so slow, and updating anything was a big pain. I do like the "Jello" approach :)

I recently built a newsletter template in Simplenews, and used Postmark for sending email. In this day and age, many servers get blacklisted, sadly. If the volume is low (less than 100 emails every month) Postmark is free. I documented one way to set it up with Drupal Symfony Mailer:

https://www.drupal.org/docs/contributed-modules/drupal-symfony-mailer/fa... β†’

You ought to check out DDEV, it's an awesome tool. And like I wrote, it can intercept email, and let you preview, see the source, validate, etc. Though for the Postmark set up, during testing I switch the transport to the default (SMTP/Sendmail). When I then want to let an email go through and actually get sent, I switch the default to Postmark, since they are not intercepted by Mailpit in DDEV.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Heh, I know that feeling very well :) I have often spent far too long trying to get something to work, but failing because I was editing the wrong file, or assuming something should work (wrongly) like you did. I do try to "start small" now, and get something very basic to work, before moving on.

But at the least, it's great to get conformation that tokens work in Simplenews.

By the way, if you're using DDEV, you probably know about Mailpit, which is an awesome tool for email debugging and testing. If not, I warmly recommend it.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@james.williams:

I reckon the ignore file would be customised on many (perhaps most?) projects, which would require tricks to get around the composer scaffolding, which can be tricky and frustrating if & when updates are made to the original version of the file in future.

As I understand it, when composer create-project drupal/recommended-project is run, the composer/Template/RecommendedProject/.gitignore file will be copied to the root of the project. After that, it's left to its own devices, and Composer will not update it again.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Yes, maybe you can supply a link to a page on a web site with this functionality?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Sorry @nicxvan, I forgot that you managed to create an MR in Gitlab, which I have updated.

I agree, .gitignore would be easier out-of-the box, so I'll leave it at that again, and not convert to example.gitignore. So this commit only adds ignore rule by default for PhpStorm and VSCode folders, and .env file

Core maintainers should be allowed to veto .gitignore-files, if it makes maintenance very hard. But it would be great with some feedback from them, to clarify if this assumption is true or not.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

You're welcome, though I guess I only confirmed that the token seems to exist, and ought to work ... Maybe you can try a whole swathe of tokens, including regular tokens such as site name, and see if none, or some work?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Perhaps you can link to a web site with this functionality?

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @AaronMcHale, great suggestion adding .env by default, I have updated the patch.

@james.williams: I think I missed the argument before, that using example.gitignore eases the burden on the core release managers, or didn't understand it. But it's a strong argument, so I have renamed the two .gitignore files files to example.gitignore.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

I tried creating a "First name" field, and it is indeed:
First name: [simplenews-subscriber:user:field_first_name]

So the bug is confirmed :)

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Did you verify that these tokens exist? You should be able to see all available tokens under /admin/help/token if you have both Token and Help installed.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks everyone for great suggestions and refining the code, I'll update the Issue Summary to match the current patch.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

I agree that it should be advertised more prominently on the Edit page, if a View is disabled. Currently, the only difference is no "Path /archive" (for example) for a disabled View with a page. Another minor difference, is the second right side drop down, where "View Page" has been removed, so instead "Duplicate Page" is shown.

Perhaps change the background color, and make it the same as for unpublished nodes, and show an alert text at the top?

Also, it would be nice to be able to disable and enable a View from the View edit page, and I created a follow up issue for that.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

ressa β†’ created an issue.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

ressa β†’ made their first commit to this issue’s fork.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for nudging this issue along @ultimike, let's get it moving :) About your comments

I think a more aggressive approach (as @nickvan detailed in comment 66) is the way to go.

I agree, and that's how it is now, after #116, where I summarized the general opinion (aggressively ignore) and created a patch accordingly.

As I just alluded in my first thought above, I think it should be an example.gitignore and not a .gitignore file.

The Issue Summary has this sentence, which I agree with:

Have one well-documented .gitignore per project template that meets persona a)'s needs without modification, and has the additional rules desired by persona b) commented out. [...]

I would prefer to not clutter the folder with an example.gitignore file, but prefer a hidden .gitignore file, as it is in the current patch.

About PHPStorm and VSCode, I agree -- let's add ignore rule for Visual Studio Code files as well.

About the two example.gitignore files in the current patch, I have no opinion. Perhaps @mbaynton, @Mixologic, or @greg.1.anderson can weigh in, if they are necessary, or can be removed?

My main goal is to get an aggressively ignoring .gitignore in the project root of drupal/recommended-project, out of the box.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@raffaelj: If you haven't already, I recommend that you create an issue in https://www.drupal.org/project/issues/infrastructure β†’ , and describe the feature you are looking for, or problem which blocks your progress.

If you're lucky, the feature exists already. If not, the best way to improve the process and make Drupal project maintenance easier, is to make the Infrastructure team aware that there are users, who are looking for a specific feature.

The outcome of such an issue could also be improvements in the documentation, clarifying how to most easily maintain a project.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Umami demos Drupal's multilingual feature, so the /en is expected. Drupal won't have /en, /es, etc. folders for each language.

Perhaps check the error log with Drush?

drush watchdog:show

Which development environment are you running Drupal in? Because you could check the server logs, if Drush doesn't show anything.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@lostcarpark: I set it to "Postponed" mostly to make space for discussion, since you and @jayhuskins might not agree with me. But since you agree that basic design would be nice, let's change status. I like your suggestion with having "None", "Minimal" and "Themed" styling, where only the last option is missing now, since #14 in effect added "Minimal".

πŸ‡©πŸ‡°Denmark ressa Copenhagen

It looks good, thanks @jayhuskins -- "Vertical menu" is now an option, and when enabled, the items are listed under each other, as expected.

Also, "Horizontal menu" is enabled by default right after installing the module, making it look more like the kind of menu people are used to seeing.

I could change to RTBC, but maybe we should discuss first, if the menu items themselves could get styled and look a bit more themed? (like Admin Toolbar or Olivero)

As I wrote in #10, I prefer to showcase as much of a module's features right after install, to introduce it best to new users, and really make it shine.

The menu looks better now for wide Desktop resolution, with items listed horizontally, but with a few simple CSS rules, the Disclosure Menu items could look even more like menus users are accustomed to see, such as Admin Toolbar or Olivero, i.e. nicer, as opposed to the current, more raw look.

And, yes people should style the menu themselves, but with a few simple changes, such as removing underline for the menu items (but show on hover), and making the font-weight 600, we could make the menu look just a little more menu-esque, and work out of the box.

Also, sub-menu items, which pop up on click or hover, could also be aligned better. But maybe that's better handled in a separate issue? Or maybe as part of the light styling, I suggest above?

I created ✨ Enable hover navigation Javascript by default Active for my suggestion about Javascript on hover enabled by default.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

I actually ran the composer.json locally, and verified that updating Drush is the solution :)

πŸ‡©πŸ‡°Denmark ressa Copenhagen

You need to update Drush to the latest version:

 composer require drush/drush:^12
πŸ‡©πŸ‡°Denmark ressa Copenhagen

Sounds fantastic @Orkut Murat YΔ±lmaz, I look forward to trying it, and will give it a go, as soon as it is available. Have a nice weekend :)

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Great, thanks @himanshu_jhaloya! I didn't mean to single you out, but you obviously know how to use the Gitlab CI, so we might as well not use the Drupal CI any more.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks for sharing everyone. It would be great if you also included operating system.Also, if it happens in local development, the set up (Lando, XAMPP, Docker, DDEV, etc.) or on a server, which OS and maybe also PHP version.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Please note that DrupalCI and all patch testing will be turned off on July 1, 2024 β†’ , so generally speaking, it's probably better to create a patch and Merge Request with the Gitlab integration, to be better prepared in advance of the eventual phase out.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Manually attaching patches is being phased out, and you should create a patch and Merge Request with the Gitlab integration.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@himanshu_jhaloya: Manually attaching patches is being phased out, and you should create a patch and Merge Request with the Gitlab integration. This is especially so, if an existing Gitlab patch is already exists.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @himanshu_jhaloya. Manually attaching patches is being phased out, and you should create a patch and Merge Request with the Gitlab integration.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@himanshu_jhaloya: Manually attaching patches is being phased out, and you should create a patch (or update existing) and Merge Request with the Gitlab integration.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @himanshu_jhaloya. Manually attaching patches is being phased out, and you should create a patch and Merge Request with the Gitlab integration.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @himanshu_jhaloya! As I commented in the other issue, manually attaching patches is being phased out, and you should create a patch and Merge Request with the Gitlab integration.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

@himanshu_jhaloya: Thanks! As I commented in the other issue, manually attaching patches is being phased out, and you should create a patch with the Gitlab integration, and create a Merge Request.

DrupalCI and all patch testing will be turned off on July 1, 2024 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Thanks @himanshu_jhaloya, but attaching patches is being phased out, and you should create a patch in the Gitlab integration branch https://git.drupalcode.org/issue/simplenews-3419867/-/tree/3419867-set-d... and create a Merge Request.

For more, see DrupalCI and all patch testing will be turned off on July 1, 2024 β†’ as well as:

DrupalCI console output and artifacts are no longer available from dispatcher.drupalci.org. Use GitLab CI instead β†’

From your attached patch https://www.drupal.org/pift-ci-job/2855624 β†’

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Nice to get confirmation from the target audience that this is an improvement, thanks @smustgrave.

πŸ‡©πŸ‡°Denmark ressa Copenhagen

Yes, they are incredible. If you haven't already, also check out how Devel can generate dummy content:

devel-generate:                                                                                                                       
  devel-generate:content (genc)  Create content
  devel-generate:media (genmd)   Create media items
  devel-generate:menus (genm)    Create menus
  devel-generate:terms (gent)    Create terms in specified vocabulary
  devel-generate:users (genu)    Create users
  devel-generate:vocabs (genv)   Create vocabularies

Simply running drush and going through the list of commands can be very inspiring.

drush topic is another great way to explore Drush.

Production build https://api.contrib.social 0.61.6-2-g546bc20