Account created on 14 May 2021, almost 4 years ago
#

Merge Requests

Recent comments

πŸ‡¦πŸ‡ΊAustralia tarawij

I can reproduce this on Drupal core 10.4.5, 11.0.13, and 11.1.5 with Modifiers 8.x-1.6.

πŸ‡¦πŸ‡ΊAustralia tarawij

Hi @kishan kumar and maintainers,

Thank you for the great work on MR #17! I have tested the current changes and noticed a few issues related to constructor arguments and service injection for D11 support.

To help move this forward, I made some adjustments and fixes, including:

  • Corrected the constructor signature and service injection to align with D11 standards.
  • Improved the order of dependencies in the factory method.
  • Simplified the row calculation logic for better readability.
  • Updated the row calculation comment for clarity.

You can find my commit with the fixes here:
Fix commit for MR #17

Since I couldn't push changes to the main project repository to directly update the MR, I kindly ask if you could cherry-pick my commit or incorporate the changes into the existing MR. Please let me know if you would like me to make any further adjustments.

Thank you once again for your effort on this! I hope my contribution helps move the MR forward.

πŸ‡¦πŸ‡ΊAustralia tarawij

tarawij β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia tarawij

I have tested the Merge Request created by the Project Update Bot (D11) and noticed that there was a missing dependency in the `ConfigFormBase` constructor call.

To resolve this, I created a new MR that fixes the issue and ensures full compatibility with Drupal 11.

MR: https://git.drupalcode.org/project/module_permissions/-/merge_requests/4

πŸ‡¦πŸ‡ΊAustralia tarawij

I manually tested the patch and can confirm that it functions as expected. With the patch applied, account reactivation link expires after use as intended.

Production build 0.71.5 2024