I ran into this in Migrate Plus on Drupal 11.2.4. The function migrate_plus_module_implements_alter() was called with an integer $hook, which triggered a fatal TypeError.
I’ve opened a contrib issue with a workaround patch: https://www.drupal.org/project/migrate_plus/issues/3547891 🐛 Fatal error in migrate_plus_module_implements_alter() when $hook parameter receives integer instead of string in Drupal 11.x Active . This shows the problem also affects contrib modules implementing hook_module_implements_alter().
Happy to help test the core patch against Migrate Plus.
I’ve prepared a merge request with a fix for this error:
MR !143: Fix TypeError in migrate_plus_module_implements_alter()
The patch adds a type check to ensure $hook is a string before processing, preventing the fatal error caused when integers are passed (see core issue #3508292).
A merge request has been submitted to fix this issue:
[!92: Add migrate_plus as a required dependency](https://git.drupalcode.org/project/migrate_tools/-/merge_requests/92)
This MR updates `migrate_tools.info.yml` to declare `migrate_plus` as a required dependency.
This resolves the runtime issue observed in both 6.1.0 and 6.1.1.
tarawij → created an issue.
Updated the patch to include an update hook for backward compatibility.
Added `book_update_103007()` which automatically grants the new 'administer book settings' permission to existing roles that have 'administer site configuration'. This ensures no access disruptions during upgrades.
The patch now provides a complete solution with automatic permission migration for existing sites.
I've pushed an initial patch to the issue fork branch 3533308-add-a-dedicated-permission.
This patch introduces a new administer book settings permission and updates the route access for the Book module’s settings page (/admin/structure/book/settings) to use it, replacing the broader administer site configuration permission.
It also includes a functional test (BookSettingsAccessTest) to verify access for users with and without the new permission.
This patch does not include an update hook, so sites will need to assign the new permission to roles manually.
Kindly requesting a review when convenient, happy to revise or expand on the patch as needed. Thank you!
I’ve applied and tested 3419657-10.patch → in both Drupal 10 (10.3.14) and Drupal 11 (11.0.13) environments. The patch resolves the issue as expected and I didn’t encounter any errors.
I can reproduce this on Drupal core 10.4.5, 11.0.13, and 11.1.5 with Modifiers 8.x-1.6.
Hi @kishan kumar and maintainers,
Thank you for the great work on MR #17! I have tested the current changes and noticed a few issues related to constructor arguments and service injection for D11 support.
To help move this forward, I made some adjustments and fixes, including:
- Corrected the constructor signature and service injection to align with D11 standards.
- Improved the order of dependencies in the factory method.
- Simplified the row calculation logic for better readability.
- Updated the row calculation comment for clarity.
You can find my commit with the fixes here:
Fix commit for MR #17
Since I couldn't push changes to the main project repository to directly update the MR, I kindly ask if you could cherry-pick my commit or incorporate the changes into the existing MR. Please let me know if you would like me to make any further adjustments.
Thank you once again for your effort on this! I hope my contribution helps move the MR forward.
kim.pepper → credited tarawij → .
I have tested the Merge Request created by the Project Update Bot (D11) and noticed that there was a missing dependency in the `ConfigFormBase` constructor call.
To resolve this, I created a new MR that fixes the issue and ensures full compatibility with Drupal 11.
MR: https://git.drupalcode.org/project/module_permissions/-/merge_requests/4
I manually tested the patch and can confirm that it functions as expected. With the patch applied, account reactivation link expires after use as intended.