- Issue created by @cb_govcms
- π¦πΊAustralia tarawij
I can reproduce this on Drupal core 10.4.5, 11.0.13, and 11.1.5 with Modifiers 8.x-1.6.
- First commit to issue fork.
- Merge request !11696Issue #3516558: Settings is not a valid render array in navigation module β (Closed) created by plopesc
- πͺπΈSpain plopesc Valladolid
The suggestion looks valid to me.
Changed settings to #settings and I didn't detect any regression afterwards.
- πΊπΈUnited States smustgrave
Seems straight forward, been told since navigation is experimental then a CR isn't needed. Also believe this qualifies for not needing test coverage
- π¨π¦Canada m4olivei Grimsby, ON
As
#settings
is defined by Layout Builder for layout templates, we can actually simplify its use in the template. See MR for details. - πͺπΈSpain plopesc Valladolid
Thank you for your review @m4olivei. Great catch!
Addressed your comments in the last commit.
- π¨π¦Canada m4olivei Grimsby, ON
Looks great! Thanks for this @plopesc.
I'm seeing everything look good including adjusting the logo settings, eg.
Hide Logo:
Default logo:
Custom logo
-
pdureau β
committed 05057f1f on 11.x
Issue #3516558 by plopesc, m4olivei, cb_govcms, tarawij: Settings is not...
-
pdureau β
committed 05057f1f on 11.x
-
nod_ β
committed 8a5dd952 on 11.1.x authored by
pdureau β
Issue #3516558 by plopesc, m4olivei, cb_govcms, tarawij: Settings is not...
-
nod_ β
committed 8a5dd952 on 11.1.x authored by
pdureau β
- π«π·France nod_ Lille
doesn't cherry pick to 10.5.x, need a MR for that one