🇺🇸United States @Kristen Pol

crediting shyam_bhatt (to match the commit) and jessebaker for code and review and lauri for reporting

The change to onlyMethods happened in D9 (example: #3250629: MockBuilder::setMethods is deprecated in PHPUnit8 and removed from PHPUnit10 → ) so we can change to:

+core_version_requirement: ^10 || ^11

once the fixes are done.

Needs work per review.

Sorry, I should have remembered that by now o_O

It's working as expected! Thanks!

Video is currently uploading:

https://youtu.be/dYPWCiCK968

Looking at this and 📌 Automated Drupal 11 compatibility fixes for quantcdn Needs review

Looking at this and 📌 Drupal 11 compatibility changes Postponed

Actually... there's no live preview button.

Looking now.

Adding credit.

Thank you for the details. I agree that some of these complex domain specific modules are important for Drupal’s ecosystem.

Maybe for example some like Tome would also fall into this to make Drupal sites static which may entice a different type of customer.

There are also themes like USWDS and CivicTheme used by government that are critical.

The list goes on and on I’m sure.

It would be impossible to evaluate all modules to understand their importance so we’d need a set of criteria that these projects must hit to be included.

Then the maintainers or the community would have to nominate them.

This adds extra ongoing burden on the DA to review these so I’m sure they want to support this even if it does make sense.

Thanks 🙏

I'm having the same issue I was having on my local a couple days ago... my understanding is there was a bug that has been fixed since then... I'm unclear how we can get the preview to update to the latest code.

Here's a video of the issue (it's uploading now)... you can't drag anything into the desktop area... there were no related errors.

https://youtu.be/0lTPqtZXwNc

Let me take a look :)

smustgrave → credited kristen pol → .

smustgrave → credited kristen pol → .

add note re articles

add composer require alternative command

Here's Drupal 9:

• DevPanel (D9): http://prod-3d5066bd-6dc3f819-qwscsa2b.app-drupalforge.click/
• QuantCDN (static): https://134489d1-93f4-4f78-a6fb-d7ce7378ec61.quantsites.com/

remove JS Aggregation section

The Tome maintainer isn't going to use the automated issue and created a new one:

📌 Non-automated Drupal 11 compatibility fixes for tome Needs work

We may just move foward with creating our D11 version and not wait for Tome though since Tome is not required and not typically used for Quant projects.

Here's the Drupal 7 site:

https://prod-3d5066bd-6dc3f183-kx2ngggr.app-drupalforge.click/

I used https://www.drupal.org/project/realistic_dummy_content → so the photos aren't the typicial multicolor blocks.

The site is tied to one of my testing accounts so we'll need to figure out how to best connect to an account created on the fly.

Assigning to me as I've been looking at this.

quietone → credited kristen pol → .

gargsuchi → credited kristen pol → .

Adding credit

Removing tag

Thanks 🙏

gábor hojtsy → credited kristen pol → .

gábor hojtsy → credited kristen pol → .

gábor hojtsy → credited kristen pol → .

Good news 🙏

kristen pol → created an issue.

See js file here:

https://github.com/civictheme/monorepo-drupal/blob/4fcdb6801af711a0d8ff0...

Thanks. Code looks good.

I'll do a quick test before merging but otherwise marking RTBC for now.

Thanks. I will probably move some of these back to obsolete like the form field ones as those don't make sense inside XB and we have no other way of hiding them for now.

Moving to RTBC and I'll update those right before I merge.

Coolio :)

So once we merge that, this one can be marked fixed.

Cool, thanks. FYI that I’m used to seeing issues marked fixed *after* all credits are done which is why I was confused :)

xjm → credited kristen pol → .

Yay!

Is it true that deleting a section would remove it wherever it’s used? I guess it makes sense.

Is there any plans for archiving a section so it’s still shown where previously added but not available for adding to new things? Or perhaps tagging and hiding as part of the categorization feature that’s being designed?

Thanks for the details! I’ll move this to postponed for now.

rachel_norfolk → credited kristen pol → .

You can decide your policy but it’s usually either:

1. All organizers and speakers

Or

2. All attendees

Here's an update:

https://www.drupal.org/project/purge → - compatible!
https://www.drupal.org/project/simple_sitemap → - compatible!
https://www.drupal.org/project/token → - compatible!
https://www.drupal.org/project/webform → - (dev is) compatible as of 17 Oct 2024:
https://git.drupalcode.org/project/webform/-/blob/6.3.x/webform.info.yml...

Only one left... I pinged the #d11readiness channel to see if anyone wants to take a stab at remaining items:

https://www.drupal.org/project/tome → - not compatible as of 18 Oct 2024 📌 Automated Drupal 11 compatibility fixes for tome Needs review

Very excited to see the designs!

Yes :(

Thanks 🙏

FYI looks like credit wasn’t given to some folks

Added to docs, updated project page text and resources, and add to Slack bookmarks.

update to d11 and add milestones

Link to Kanban board and add milestone 2

Done:

https://contribkanban.com/board/demo_design_system

I'll add to the docs and project page.

Working as expected based on testing, so marking fixed.

Postponed on 📌 Port improved CivicTheme build code to SDDS Active

Tested a couple things and update the button booleans to default to false (though there's a bug with XB where they aren't defaulting).

Merged manually.

I tested locally and it is working as expected.

Update summary to link to dev guide.

kristen pol → created an issue.

Ah... maybe you found in here?

components/00-base/about-civictheme/about-civictheme.stories.twig

Looks like there are icons listed in that twig file that aren't in the icons folder.

Please create an issue here:

https://www.drupal.org/project/issues/civictheme →

Where are those from?

These are the ones I see in the theme:

kristens-mbp-2:assets kristenpol$ ls icons/
account.svg		close-outline.svg	exclamation-mark-3.svg	linkedin.svg		right-arrow-1.svg	upper-arrow.svg
approve.svg		close.svg		eye.svg			magnifier.svg		right-arrow-2.svg	upper-right-arrow.svg
bars.svg		down-arrow-1.svg	facebook.svg		map.svg			select-box.svg		watch.svg
bullet.svg		down-arrow-2.svg	help.svg		megaphone.svg		share.svg		word-file.svg
calendar-1.svg		down-arrow-large.svg	image.svg		message.svg		square.svg		x.svg
calendar-2.svg		download-file.svg	information-mark.svg	mortarboard.svg		to-do.svg		youtube.svg
call.svg		download.svg		instagram.svg		newspaper.svg		twitter.svg
cancel.svg		exclamation-mark-1.svg	left-arrow-outline.svg	pdf-file.svg		up-arrow-large.svg
checked.svg		exclamation-mark-2.svg	left-arrow.svg		progress.svg		up-arrow.svg

Thanks for reporting. I saw this pre-Barcelona when working with buttons as well.

Note that you can use the browser back button to get back to the XB display so this is a workaround if you accidentally click something and don't want to reload the page and redo your stuff.

Thanks. Marking this one as fixed.

🐛 Link opens inside XB Active

Talked with Jacob about this. For the left side with the 5 logos could be one image that defaults to the image that has these five logos but someone could swap it out in the XB UI, of course.

Jacob is going to focus on other things so will see if someone from the community can do this.

For real.

Thanks. Back to Jacob. Put the image in components/assets/images and adjust the path in the base theme and the subtheme.

See 📌 Target Drupal 11.1 for stable release Active

scott_euser → credited kristen pol → .

update node version

Notes from Alan:

• The code is up on a branch: https://github.com/civictheme/monorepo-drupal/pull/1313
• At the moment it's a single javascript file you add to your theme and run (examples of how to run that are in the package.json in the PR.)
• Only catch is the requirement of node 22
• As for the "cleanup" part of it, removing dependencies etc. Currently the storybook still relies on the webpack instance - so i haven't removed it yet. That part will be handled in a separate PR, and part of a bigger piece with upgrading storybook.

Off to Jacob to pull in that JS file and test it out and create a MR here.

kristen pol → created an issue.

Actually, looks like you compared against storybook already so just the icons are left.

Unassigning because alan.cole has improved the build rules in CT and that will get merged into that repo soon so we should get that in here first.

Looks good. I'll get this merged.

@alan.cole We want to have a default for some example images like for the image component... should it be in a assets/images directory or ?

Thanks for the feedback 👍

Thanks 🙏

Not sure if this is related to this or to #3467954 but this was found when debugging this issue:

🐛 Image Schema only works with image var in twig Needs review

Moving to active.

Moving back to postponed.

Gotcha. One place where we allow different padding is for props+components that may want more or less breathing room above/below. But, I can see for the overall spacing defaults, perhaps having these globally defined so each site has some freedom to make things tighter or more airy.

Actually… reopening as we need to make some issues based on the feedback :)

Crediting participants.

Though maybe we need to sort this one first?

📌 Should we add SDDS to XB's Tugboat? Needs work

IMO it would be nice to have the button on the project page until it's available more broadly.

Thanks for creating this issue. I saw this pre-Barcelona but unfortunately didn't get around to reporting it in the flurry of activiity.

This would make it easier to test:

📌 Should we add SDDS to XB's Tugboat? Needs work

Drupal CMS is still using 10.3.

Testing guide can be handled separately before Singapore so closing this.

Closing... meetings issues will be handled separately.

Closing as fixed.

Not moving forward with the spacer idea at the moment given community feedback.

This issue is open for review/testing from others in the community.

Thanks for the feedback 🙏

Thanks for debugging. Not sure what I we can do on the SDDS end... anything?

Jacob will take a stab when he's done with other things.

Jacob will take a stab at this after he's worked on some other things.

Off to Jacob.

Looks good. I'll get this merged.

Ready for review.

Fixing status.

Same issue... only happens when there's a component on the page with an image.

I don't think it's on our end as one of our devs has been working with it since last week without issue, but :shrug:

https://youtu.be/rWI4RRmkjjI