Also get this error before adding a csv file if the temp dir is not specified:
Failed to connect to your database server. The server reports the following message: No database connection configured for source plugin variable.
Is the database server running?
Does the database exist, and have you entered the correct database name?
Have you entered the correct username and password?
Have you entered the correct database hostname?
kristen pol → created an issue.
Here's the video of me testing @heyyo's MR:
I'm marking MR 94 as draft as we work through this.
I've tested MR 94 from @heyyo.
I like the gradient and wonder if it could be pulled into the generic components somehow... need to think about this.
I also like the styling of the menus as there is more vertical space between items. That could get pulled into the .ct-menu in the container component.
@heyyo If you have the time/inclination... think about how might your gradient get pulled into the generic components.
And similarly, this one needs work and not sure when Alan would be able to get to this:
📌 Update SDDS components to move header_panel features to generic components Active
Follow-up:
📌 Update SDDS components to move header_panel features to generic components Active
kristen pol → created an issue.
Thanks, everyone!
Some generic styling to support footer and minor header tweaks happened in:
📌 Create SDDS global footer Active
These changes were merged.
We probably want to move away from a specialized header component and move the styling into some of the generic components (e.g. flexible slot and or columns)
To avoid confusion, I'll mark this one as fixed and we can create a follow up issue for that.
Finished code review and testing on Alan's MR and this is testing for the footer in a generic way (using two approaches):
I'll merge this and move onto @heyyo's approach.
Tested Alan's MR and these are generic improvements, so I will merge that one shortly. I'm uploading a video right now.
kristen pol → changed the visibility of the branch 1.0.x to hidden.
Thanks @heyyo.
Alan has a branch too and was trying to do this in a "generic" way (and didn't include the social media links) as that's what @gábor hojtsy mentioned in Slack.
So, you two have different approaches and hopefully we can take the best of both :)
Assigning to myself for initial review/testing. I'll try to create two videos with each approach and add them here and then open this up for other review.
Whoops
Merged MR and we'll do another MR to clean up some styling things.
Oh… or probably because it’s not inside the hero
Here's a video of it (still processing)... not sure why the link styling disappeared after switching menus:
I'll try with a fresh install later as my local db might be a bit borked now
I'll be out of commission until tonight, so unassigning in case someone can pick this up.
When splitting up the menus into starshot-specific ones, I must have missed some config as I get errors sometimes... I'll try to figure it out but am off to class for a few hours soon :/
Forgot to upload his screenshot:
This issue needs to happen after the header one due to config updates.
Per @gábor hojtsy, we'll simplify the footer... config cleanup is happening in:
✨ Add SDDS global header styling Active
Lots of changes happening and we have the temp contributor image placeholder so moving to postponed for now until the dust settles :)
There are more to add to this and one that I still need to create if it's not already (components with multiple slots make it hard to move into some slots depending on placement)
Thanks!
Thanks for the update :)
Copying from footer issue:
Yeah, when I created these, I wasn't aware of XB's global placement workflow.
Block placement has been removed and regions simplified per:
📌
Remove block placement of SDDS header+footer blocks
Active
📌
Too many global regions
Active
but the content is still there.
Tweaks can be in the header/footer styling issues.
Yeah, when I created these, I wasn't aware of XB's global placement workflow.
Block placement has been removed and regions simplified per:
📌
Remove block placement of SDDS header+footer blocks
Active
📌
Too many global regions
Active
but the content is since there. Sounds like we don't want to do the social media links for now but I'll leave the default content for now in case that changes.
Marking this one fixed and tweaks can be in the header/footer styling issues.
We're going to move from the standalone MR into an issue MR so non-maintainers can collaborate.
Removed some of the main menu links to reduce wrapping issues so it will look more like:
Just merged these:
📌
Remove block placement of SDDS header+footer blocks
Active
📌
Too many global regions
Active
Merged in the changes.
One more update
Updating summary to reflect new reality.
Thanks :)
The region simplification is part of ✨ Add SDDS global header styling Active as noted in #8...
But, I'm going to add an MR here to get this merged in now so we can close this one out and avoid further confusion.
I'll keep the sidebar off for now until we understand the UX better.
Merged
Actually... I'm remembering now that we needed at least one block placed or it will grab all the base theme blocks. I'll put the page title block back for now, I guess.
Doing this now as it's confusing because XB shows even disabled blocks.
The regions are reduced in this issue’s MR but I didn’t include the header region because I had my unstyled blocks in there. Even disabled blocks will show up in XB.
I made an issue for me to remove those blocks from block placement so it’s not additionally confusing things. I’ll try to do soon.
I started those steps but it's hanging on:
Browserslist: caniuse-lite is outdated. Please run:
npx update-browserslist-db@latest
Why you should do it regularly: https://github.com/browserslist/update-db#readme
and won't let me kill it... blargh.
kristen pol → created an issue.
kristen pol → created an issue.
Updating summary with correct video
I recorded my testing of the header and of global regions.
I'm not loving the UX of the global regions but I think that's a known thing so maybe it'll be different at some point.
I'm not sure it's good to build this into the hero because only the home page will have the hero and not the other pages.
If we could just build that bar more generically and put it into the header then it would be the same across all pages.
But then it wouldn't look integrated with the hero and a hero may or may not be on other pages and, if it is, it will be different.
I'm not sure what the best UX is for this.
I'll see if others have some thoughts.
Could this be a variation of the container rather than being its own "header panel" component?
Sean should give himself issue credit for the work
We've done a bunch of them but focus is on starshot_demo subtheme so moving this to postponed until we can do the next round.
I'll have to dig up my notes o_O so postponing for now.
Note that I did create this one before:
kristen pol → created an issue.
This as well:
Closing as this work is happening in Drupal Forge now since GitPod/DrupalPod are EOL:
Closing as this work is happening in Drupal Forge now since GitPod/DrupalPod are EOL:
📌 Create standalone SDDS+XB demo for user testing Active
Moving credit to that issue.
Closing these issues:
📌
[META] Create a GitPod project for easy SDDS testing and development
Active
📌
Create SDDS GitHub project to support GitPod Launcher
Active
and adding credit from there to here.
Forgot to update status
I've created but haven't committed.
This was fixed.
Removed the unused variables.
Tested this and the XB team must have fixed those issues and it's working fine now.
Tested this and the XB team must have fixed those issues and it's working fine now.
Fixed
Maybe there was some issue with XB when this was tested. Seems fine now.
It did have the icons missing, but I added those in that issue.
Maybe there was some issue with XB when this was tested as I just tested while testing:
📌 Integrate SDDS base theme link component with XB Active
and it's working as expected. It did have the icons missing, but I added those in that issue.
@jacobadeutsch's video looked good and I did some testing.
Added icon enum to this and to the other components that were missing it and prefixed all CivicTheme components with "CT".
Lots of great stuff here and I want to make sure everyone gets credit for providing their thoughts.
Accordion definitely keeps coming up.
Video was blocked on XB the last time we looked at it:
📌 Integrate SDDS base theme video component with XB Active
If anyone is interested in working on any of these components, we can open specific issues for them. Let me know :)
Wow! Sorry this didn't get marked fixed. Great work! Definitely interesting to see how paragraphs+sdc is used.
Updating issue statuses
I tried pulling out xb_page into its own recipe and loading all the non-xb_page content first, but still get the same error.
I'm going to switch to another MR right now but I'll try to look at this again after that.
I was testing on vanilla D11...
$ ddev drush recipe themes/contrib/demo_design_system/starshot_demo/recipes/starshot_demo_content/
3/10 [▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░░░]
Installed configuration for Basic HTML editor recipe.
In TypedDataManager.php line 204:
Property pathauto is unknown.
Failed to run drush recipe themes/contrib/demo_design_system/starshot_demo/recipes/starshot_demo_content/: exit status 1
after installing pathauto:
$ ddev drush recipe themes/contrib/demo_design_system/starshot_demo/recipes/starshot_demo_content/
3/10 [▓▓▓▓▓▓▓▓░░░░░░░░░░░░░░░░░░░░]
Installed configuration for Basic HTML editor recipe.
In Evaluator.php line 44:
No data provided to evaluate expression ℹ︎␜entity:media:image␝field_media_image␞␟alt
Failed to run drush recipe themes/contrib/demo_design_system/starshot_demo/recipes/starshot_demo_content/: exit status 1
which is the bug we've been working around.