Fixed! We'll set up a regular meeting soon :) I'll ping people directly for some good day/time windows.
kristen pol → created an issue.
Added recording (thanks, Suchi!)
adding credit
kristen pol → created an issue.
kristen pol → created an issue.
mradcliffe → credited kristen pol → .
Yeah… want to do this soon and we just need to decide timing… I think we can do it this week tbh to start more conversations about Figma to XB at minimum
Thanks 🙏 We will be making a website as well so we should figure out what’s where
volkswagenchick → credited kristen pol → .
griffynh → credited kristen pol → .
griffynh → credited kristen pol → .
griffynh → credited kristen pol → .
griffynh → credited kristen pol → .
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
Switching to official tag :)
tagging
Adding credit
kristen pol → created an issue.
Thanks for bumping priority :) I find that I’ll set to false and the component behavior seems fine but the UI later shows it as true even though the component still seems to behave as it’s false … maybe that’s what’s explained but I’m on my phone on my flight to Atlanta so hard to read well :D
Closing... you can still add a comment though if something isn't correct :) [or ping me in slack]
Closing... you can still add a comment though if something isn't correct :) [or ping me in slack]
At the airport waiting to fly to Atlanta! See some of you there :)
Speed-up XB+SDDS demo from videos I created a couple of days ago:
Thanks to @AaronDeutsch for stitching these today and adding original musci!
Crediting all of the people that have been helping with all this... hopefully I got everyone!
Thanks!
I created these for the screenshots so maybe that's good enough as we are getting down the wire:
📌 Create Atlanta components for prop vs slot comparison Active
This one is coming along:
📌 Create fast SDDS XB demo video from blank canvas Active
So close!!!
Working with Aaron on this.
Ah, yes, console shows a 404 for:
https://mr101-hfagpamcycjtiie2ccqvu335hh0pbbmq.tugboatqa.com/themes/contrib/demo_design_system/starshot_demo/assets/starshot/testimonial_avatar.png
so must be a permission issue?
Actually, that image is coming from the themes so maybe that's a permission issue?
kristen pol → created an issue.
Adding follow-up issue because the default media isn't loaded for some reason...
Thanks!!!
Added an empty MR to test tugboat live preview
Speed of
ddev composer create phenaproxima/xb-demo --stability=dev
real 3m22.094s
user 0m3.273s
sys 0m2.499s
Included in 📌 Create SDDS 1.0.1 release Active
Included in 📌 Create SDDS 1.0.1 release Active
Included in 📌 Create SDDS 1.0.1 release Active
Includes
📌
Remove all SDDS civictheme base theme optional config
Active
✨
Speed up SDDS build for xb-demo
Active
✨
Add Tugboat for SDDS project MR testing
Active
kristen pol → created an issue.
Marking fixed but feel free to still review
Not sure why it's not showing up for the dummy MR but :shrug:
I'm marking this fixed as I think it's working well enough for now
I'm going to merge this and try creating another MR and see what happens
I'm not sure why the XB link doesn't come up at the top of the page but it seems like things are working.
- Login at /user
- Go to /xb/node/2
- Look at list of components... it's a mixture of SDDS and XB components (which is fine for now)
The xb-demo repo does some cleanup so that the home page is prefilled with components. We had a hard time getting that to work with default content due to XB issues:
✨ Convert SDDS page--front.html.twig to a proper home page for XB Active
Templates with XB are unhappy with the base theme so I'm going to get rid of those for now since we aren't using them
This merge
✨ Speed up SDDS build for xb-demo Active
adds the dist and css file assets to the theme so a build isn't required so you should be able to remove the "npm ci" and "npm run build (or dist)" for base and subthemes
Merged... I'll test again before creating a release
I've tested with just:
dist
components/**/*.css
added for both themes and it is working fine.
I'll merge and test again.
Think we need these for base theme:
dist
components/**/*.css
and same for subtheme:
dist
components/**/*.css
but I'm not sure about these yet:
components_combined
.components-civictheme
add parent
Testing video: https://youtu.be/GN2U6RjVlw0
Moving to outdated as the CT team are creating SDCs now and then will be doing the "proper" XB integration so let's see how they land. We might not be using the components module in a few months.
Moving to outdated as the CT team are creating SDCs now and then will be doing the "proper" XB integration so let's see how they land.
Merged... thanks!
merged latest changes and made sure it st
Updated the dev guide and testing guide:
https://www.drupal.org/community-initiatives/starshot-demo-design-system... →
https://www.drupal.org/community-initiatives/starshot-demo-design-system... →
add info on testing merge requests
kristen pol → created an issue.
add info about xb-demo and drupal forge
add parent
Though this can be worked on at any time... given you get past the install issues that @siramsay was having.
xb-demo is using a version of the contributors component that was hand-built in the home/front page twig template
So... we have something for next week though it doesn't look as nice as this one
Although this is working, the hosting cost aspect hasn't been sorted so unfortunately this won't be ready for next week
All the pieces are in place now to make this video so I will try to do today but worst case tomorrow
This is unblocked now.
Pulling this from meta as it's not a priority as we'll be prebuilding assets per:
✨ Speed up SDDS build for xb-demo Active