🇺🇸United States @Kristen Pol

Given we are using two hard-coded links for the hero, we don't need the cta component anymore.

Would be good for @mherchel to confirm here.

@bernardm28 Why was the image commented out?

Hmm... tried to merge in 1.x but I don't know enough about how the component/card.css was/is being used... this MR deletes that file but then we need to test all the views/displays that use the card to make sure things are still handled correctly.

Off to @mherchel for thoughts here.

diff --git a/drupal_cms_olivero/css/components/card.css b/drupal_cms_olivero/css/components/card.css
index 76eff66..1c82cda 100644
--- a/drupal_cms_olivero/css/components/card.css
+++ b/drupal_cms_olivero/css/components/card.css
@@ -3,6 +3,7 @@
       var(--grid-repeat, auto-fit),
       minmax(min(100%, var(--grid-min, 26ch)), 1fr)
     );
+  gap: var(--sp2);
 }

Testing notes

1. Card grid title doesn't show up
2. Not responsive in preview
3. XB edit doesn't look the same as preview
4. XB bug: can't edit image in 2nd card after adding to 1st card... but I haven't updated my XB code in awhile so might be fixed
5. Note the stacked approach with one card by itself and then two in the grid... would we want the images to align?
6. A general question on the approach: given we should have a generic columns or grid component, do we need the card grid component?

3 cards in builder

3 cards in preview

3 cards in preview and medium width

3 cards in preview and smaller width

1 card and 2 cards stacked in builder

1 card and 2 cards stacked in preview

I can try to merge in latest after I finish tweaking/testing.

Getting back to this because @mherchel will be taking a look shortly.

I'm going to test this and do a final round of review now and will relinquish this in about 15 mins :)

Thanks! That icon seems okay but maybe someone can make something a bit more interesting?

In the meantime, someone can pull out that icon, size it, and attach here or create MR.

Sorry... haven't gotten back to this so I'll unassign for the moment in case someone wants to jump in here.

wim leers → credited kristen pol → .

I'll update the prop naming conventions.

While this still needs work, we need some direction, I think, so moving to needs review.

I've updated the prop names to match the WIP feature component.

Some issues:

• The default image is cut off, but we should decide if that is the image that should be used before updating
• See feedback in #24 and #26

Video showing current state:

https://youtu.be/9lvmWFuob70

kristen pol → created an issue.

I'm going to rework the prop names to align with:

📌 Implement designs for Feature component within Olivero for XB Active

Fake Section 2 was removed as part of:

✨ [PP-1] Integrate saving sections with the backend Postponed

From @larowlan in Slack:

Sections are config entities
So I think Section::create()->save() would allow code creation

So this can be done... the remaining question...

Do we want to provide section(s) out-of-the-box? If so, how are we differentiating these with "big components"?

Just ran into this. Error in log:

LogicException: The page_title_block block plugin does not support previews. in Drupal\experience_builder\Plugin\ExperienceBuilder\ComponentSource\BlockComponent->renderComponent() (line 145 of /var/www/html/web/modules/contrib/experience_builder/src/Plugin/ExperienceBuilder/ComponentSource/BlockComponent.php).

kristen pol → created an issue.

Updating because the "Fake Section" section isn't showing up in XB anymore.

Added comments to both files.

Thanks.

Maybe we need a clearer error message in that case?

Okay... I compared it to Figma and got it closer but it's still not completely there... for example, there should be less space between the quote and the name+role and between name+role and link. And the name+role colors don't match.

Is it good enough?

Also, it feels like the CSS is overly complicated and has some unnecessary things, but I didn't try to pull it apart because I don't do CSS every day.

Figma

Implementation with image

Implementation without image

I'll try to clean up the styling.

Confirmed this is still an issue, e.g.

RuntimeException: Adding non-existent permissions to a role is not allowed. The incorrect permissions are "Testing dblog overview perm". in Drupal\user\Entity\Role->calculateDependencies() (line 214 of core/modules/user/src/Entity/Role.php).

I've been reviewing and testing various issues and am waiting on a couple to be tested by others (the first one is most pressing):

🐛 Permissions that depend on disabled modules prevent any editing/creation of other permissions Needs review
🐛 Module does not work with routes that implement _entity_access Needs review

Add missed credit.

Thanks, everyone. This has been merged with some minor changes.

I just tested and you can't do that unfortunately.

Not sure how this could be done as I'm not that familiar with the code. Feel free to reopen if someone wants to create a MR.

I've reworked the logic during testing.

Test 1

• Go to /admin/people/custom-permissions/list
• Click "Add permission"
• Click "Save"
• Result: no fatal error

Test 2

• Go to /admin/people/custom-permissions/list
• Click "Add permission"
• Duplicate an existing entry, e.g. "Administer account settings 2" and "entity.user.admin_form"
• Click "Save"
• Result: no fatal error
• Delete the original entry name and route
• Click "Save"
• Result: no fatal error

Test 3

• Go to /admin/people/custom-permissions/list
• Click "Add permission"
• Fill in a name but no route
• Click "Save"
• Result: shows error about missing as expected
• Fill in an invalid route but no name
• Result: shows error about missing name as expected
• Fill in an invalid route and a name
• Result: shows error about invalid route as expected
• Fill in an valid route and a name
• Result: saved as expected
• Click Delete link for new entry
• Result: deletes as expected

Created an MR and changed the logic a bit to make it simpler to understand.

This is a major (or perhaps even critical) issue as it prevents you from using the functionality.

Thanks, everyone. I've moved into an MR and made some minor changes.

We need someone to test this and make sure it fixes the issue.

@ameymudras Also see the questions from @mingsong in #3.

kristen pol → changed the visibility of the branch 3312434-module-does-not to hidden.

Confirmed this is already in the 8.x-2.x branch.

Crediting gnuget.

Merged.

Ah... that's the one that added version 11:

Kristens-MacBook-Pro-2:config_perms kristenpol$ git blame *info*
92427067 (AlonaOneill        2019-06-26 12:00:27 -0500 1) name: Custom Permissions
74925cb1 (mostfa             2016-07-10 14:30:08 +0100 2) type: module
74925cb1 (mostfa             2016-07-10 14:30:08 +0100 3) description: Allows additional permissions to be created and managed through an administration form.
10d396cc (Project-Update-bot 2024-03-16 19:27:27 +0000 4) core_version_requirement: ^8 || ^9 || ^10 || ^11
74925cb1 (mostfa             2016-07-10 14:30:08 +0100 5) configure: custom_perms_select_list_form
74925cb1 (mostfa             2016-07-10 14:30:08 +0100 6) package: Permissions
74925cb1 (mostfa             2016-07-10 14:30:08 +0100 7) features: true

Merged. Thanks, everyone!

This will be in the upcoming release:

📌 Create Custom Permissions 8.x-2.2 release for Drupal 11 support Active

Thanks, everyone.

Merging to 8.x-1.x shortly.

Note that @gnuget did not add this code to 8.x-2.x but instead used a different approach per #4.

Thanks, everyone.

Merged and will be in the next release:

📌 Create Custom Permissions 8.x-2.2 release for Drupal 11 support Active

Adding credit

I'll take a look at the code.

kristen pol → created an issue.

I don't see it was merged... last commit:

commit 10d396cc6230eb58c3df143f792feef2f4ae9a42 (HEAD -> 8.x-2.x, origin/HEAD, origin/8.x-2.x)
Author: Project-Update-bot <updatebot@assosiation.drupal.org>
Date:   Sat Mar 16 19:27:27 2024 +0000

    Automated Project Update Bot fixes from run 11-120835.

@shivam_tiwari Thank you for opening this issue. We need more information when creating bug reports including explicit steps to reproduce and, as appropriate, a screenshot of the problem.

Thanks @undersound3. I can update the project page. I'm wondering if it's worth keeping the info for the older versions though. Assigning to myself since I'll be making a release soon.

@joshuautley What you have would be the route.

For old versions of Drupal, the starting slash wasn't included. In Drupal 9 (?), the beginning slash was added.

I'm confused though because it looks like @oltus did try starting with a slash.

@oltus Let us know if you still need help with this issue or if it can be closed.

I see this is quite old and didn't get any response.

@Kris77 Do you still need help with this? I haven't used the configuration you mention so I don't have any advice without trying this myself.

If you still need help, please reopen and provide explicit steps on how you have this set up, so someone can set up their local site in the same way.

Thanks.

Given D8 is EOL and @sokru couldn't reproduce, I'm closing this.

If you are still having this issue with D10 or later, please create a new issues with explicit steps to reproduce. Thanks.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

I'm going to make a release soon so looking at all recently fixed issues along with RTBC and needs review.

Thanks 🙏

You should credit yourself too 😉

Thanks! I’m realizing that this issue probably should’ve been moved to the other queue but your workaround is good 👍

roderik → credited kristen pol → .

@roderick could you give the logo creators and contributors issue credit by creating a new comment and checking their checkboxes in the credit and committing section and saving the comment? You can credit people this way including yourself and it’ll show up on their profile page. Thanks

@shumer could you give the logo creator issue credit by creating a new comment and checking their checkbox in the credit and committing section. You can credit people there including yourself and it’ll show up on their profile page.

Typo

kristen pol → created an issue.

Merged

Looks like this:

MR: https://github.com/quantcdn/drupal/pull/246

kristen pol → created an issue.

Just noticed a linting error but it's fixed in dev now so it'll make it into the next release.

An RC release can happen after this GitHub PR is merged:

https://github.com/quantcdn/drupal/pull/238

and then we'll switch to only working on the 2.x branch.

New release:

https://www.drupal.org/project/quantcdn/releases/2.0.0-beta1 →

I made sure these branches are all in sync between GitLab and GitHub:

• 1.x
• 2.x
• 8.x-1.x

The only differences between 1.x and 2.x are related to Drupal 11 compatibility, phpcs, deprecations, and the views exposed filter warning (which could be backported but not a big feature/improvement).

1.x and 8.x-1.x are the same.

kristen pol → created an issue.

kristen pol → created an issue.

adding credits

hestenet → credited kristen pol → .

hestenet → credited kristen pol → .

add more

Update order

Closed/fixed some issues.

Retested with latest fixes and it's working as expected now.

Ended up using exposed filter warning for this but tweaked to include the display id.

kristen pol → created an issue.

Fixed:

https://github.com/quantcdn/drupal/pull/244

More closed and add 2.x issues.

Move to 2.x queue.

Move to 2.x queue.

Move to 2.x queue.

Moving to 2.x queue.

Closing some 1.x issues as the focus is switching to the 2.x branch and these are lower priority.

Leave a comment if you are interested in this issue and we can move to the 2.x queue.

Moving to 2.x queue.

Closing some 1.x issues as the focus is switching to the 2.x branch and these are lower priority.

Leave a comment if you are interested in this issue and we can move to the 2.x queue.

Closing some 1.x issues as the focus is switching to the 2.x branch and these are lower priority.

Leave a comment if you are interested in this issue and we can move to the 2.x queue.

Closing some 1.x issues as the focus is switching to the 2.x branch and these are lower priority.

Leave a comment if you are interested in this issue and we can move to the 2.x queue.