The module adds white space at the top of the olivero theme

Created on 13 March 2024, 3 months ago
Updated 6 June 2024, 20 days ago

For several days I have had a white space appearing on my websites with the Olivero theme. After some tests, if I uninstall the PWA EXTRAS submodule, the problem disappears.

Since the latest update of the PWA module, the module adds a white space at the top of the olivero theme (a

tag). I noticed that this appears when changing the color.

🐛 Bug report
Status

Needs review

Version

2.1

Component

pwa_extras

Created by

🇫🇷France zenimagine

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @zenimagine
  • First commit to issue fork.
  • 🇮🇹Italy maurizio.ganovelli Arezzo

    I have the same problem and extra metatags are not printed at all. This seems to be caused by values passed to DOMDocument::loadHTML that are html encoded. Attached a quick solution that works in my case but i'm not sure if it's optimal.

  • 🇮🇳India dineshkumarbollu

    Hi
    I Install the module and tested the whitespace in olivero theme using the module, didn't encountered any whitespace.

  • 🇮🇹Italy maurizio.ganovelli Arezzo

    Hi,

    the issue is not limited to Olivero, I can replicate with every theme.
    Please make sure you changed some configuration options (default values don't give any issue) in /admin/config/pwa/pwa_extras: try to flag some fields and select a mask icon color.

    This is a part of html head of a bootstrap based theme:

    ...
    <meta charset="utf-8" />
    <link rel="manifest" href="/manifest.json" />
    <meta name="theme-color" content="#8ae234" />
    <p></p>
    <meta name="Generator" content="Drupal 10 (https://www.drupal.org)" />
    <meta name="MobileOptimized" content="width" />
    <meta name="HandheldFriendly" content="true" />
    ...
    

    I have a vanilla Drupal 10.2.5 with PWA 2.1.0-beta5.
    I confirm also that disabling pwa_extras, the problem disappears.

  • 🇫🇷France zenimagine

    #3 Thanks I just applied the patch and it fixes the problem

  • Status changed to Needs review 3 months ago
  • 🇮🇹Italy maurizio.ganovelli Arezzo

    Thanks for feedback, changing issue status to Needs review.

  • 🇮🇹Italy Kris77

    #3 works fine for me too.
    Thanks @maurizio.ganovelli

Production build 0.69.0 2024