- Issue created by @zenimagine
- First commit to issue fork.
- 🇮🇹Italy maurizio.ganovelli Arezzo
I have the same problem and extra metatags are not printed at all. This seems to be caused by values passed to DOMDocument::loadHTML that are html encoded. Attached a quick solution that works in my case but i'm not sure if it's optimal.
- 🇮🇳India dineshkumarbollu
Hi
I Install the module and tested the whitespace in olivero theme using the module, didn't encountered any whitespace. - 🇮🇹Italy maurizio.ganovelli Arezzo
Hi,
the issue is not limited to Olivero, I can replicate with every theme.
Please make sure you changed some configuration options (default values don't give any issue) in /admin/config/pwa/pwa_extras: try to flag some fields and select a mask icon color.This is a part of html head of a bootstrap based theme:
... <meta charset="utf-8" /> <link rel="manifest" href="/manifest.json" /> <meta name="theme-color" content="#8ae234" /> <p></p> <meta name="Generator" content="Drupal 10 (https://www.drupal.org)" /> <meta name="MobileOptimized" content="width" /> <meta name="HandheldFriendly" content="true" /> ...
I have a vanilla Drupal 10.2.5 with PWA 2.1.0-beta5.
I confirm also that disabling pwa_extras, the problem disappears. - 🇫🇷France zenimagine
#3 Thanks I just applied the patch and it fixes the problem
- Status changed to Needs review
9 months ago 10:35am 5 April 2024 - 🇮🇹Italy maurizio.ganovelli Arezzo
Thanks for feedback, changing issue status to Needs review.
- 🇳🇱Netherlands joshahubbers
I think
use Drupal\Component\Utility\Html;
should be added to the top of the file too? - 🇮🇹Italy maurizio.ganovelli Arezzo
Declaration is already in place:
https://git.drupalcode.org/project/pwa/-/blob/2.x/modules/pwa_extras/pwa...
since Html class methods are used elsewhere in module.
- 🇳🇱Netherlands joshahubbers
Ah great, I think I was looking at another version of the code ;-)
Working fine anyway. Thanx!