πŸ‡³πŸ‡±Netherlands @JoshaHubbers

Account created on 3 September 2007, over 16 years ago
  • Support Engineer at iOΒ  …
#

Recent comments

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Added one extra check. Got an error in a form where private and encrypted files were mixed.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Added patch file of the diff because the diff can change.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Attatched patch implements the default webform zip export as suggested.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Hm, I'm getting this error with the patch applied:
Call to a member function id() on string in Drupal\webform_scheduled_tasks\WebformScheduledTaskListBuilder->getEntityIds() (line 93 of modules/contrib/webform_scheduled_tasks/src/WebformScheduledTaskListBuilder.php

πŸ‡³πŸ‡±Netherlands JoshaHubbers

I solved it by creating a custom views-filter.
1. create a view that loads all the points.
2. in the module file I load the drawn area from the node:

my_module_custom_views_pre_view(&$view, &$display_id, &$args){
  if($view->id() == 'test'){
    if($view->current_display == 'block_1'){
      $node = \Drupal::routeMatch()->getParameter('node');
      if ($node instanceof \Drupal\node\NodeInterface) {
        $focus_area = $node->field_adres->value;
        $args[0] = $focus_area;
        $view->setArguments($args);
      }
    }
  }
}

3. in the custom filter I add a join to the table, and the custom expression to select the points within the polygon:

     /** @var \Drupal\views\Plugin\views\query\Sql $query */
    $query = $this->query;
    $definition = [
      'table' => 'node__field_adres',
      'field' => 'entity_id',
      'left_table' => 'node_field_data',
      'left_field' => 'nid',
    ];
    $join = \Drupal::service('plugin.manager.views.join')->createInstance('standard', $definition);
    $query->addRelationship('adres_filter', $join, 'node__field_data');
    $expression = sprintf("st_Contains(st_GeomFromText('%s'), st_GeomFromText(\"adres_filter\".\"field_adres_value\"))", $this->view->args[0]);
    $query->addWhereExpression($this->options['group'], $expression);

Note: this is quick and dirty. Some basics like service injection must be fixed.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

I am also trying to accomplish this. Did you solve it?

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Drupal 7.98 update

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Update core to 7.98

πŸ‡³πŸ‡±Netherlands JoshaHubbers

New patch.
* Change the description and label of the "Signature"-checkbox on the settings page.
* Assure the signature is at the end of the file.

Two versions of the patch, one for the main branch, one with all the patches applied as described in #11.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Well, we use ✨ Language preferred and Canonical settings missing Needs work AND πŸ› Acknowledgment should be Acknowledgments RTBC ... so again the same patch with these two applied before.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

The same patch, but applicable if ✨ Language preferred and Canonical settings missing Needs work is applied before this one.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

@ralph: I checked, and https://www.drupal.org/project/securitytxt/issues/3375231#comment-15195253 ✨ Language preferred and Canonical settings missing Needs work does not remove the "Signature"-item. It just fixes that it is not displayed twice or if the signature is not present. But the point is that the "Siganture" should not be present in the file at all. It is not in the specs.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

This patch adds the signature the right way I think.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

@ralph That is great. Then the file will pass the checks. But it does not fix the problem that the signing of the file doesn't work as it shoud imho. I will change the title and description of this issue.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Fixed it for the patch that applies after ✨ Language preferred and Canonical settings missing Needs work is applied.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Fixed it for the original patch.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

This patch corrects the typo and adds an update hook to migrate the value to the new config key and remove the old config key.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Patch rerolled for alpha3.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Sorry for the txt extension. Oops.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

For people that use webform 6.1 this patch implements the principles of the referred to-patch (except that patch does not add the css-file to the library, so I am not shure that really fixes the issue, but havenot tested that).

When you use css-aggregation, you will still get the error in the console, because the script checks if tippy.css is loaded. But with aggregation enabled, that is not found.

But the tippy popups work fine with this patch because the css is loaded.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

This is work in progress. Done so far:
* add config forms
* rewrite some logic and cleanup code

Todo:
* create the output
* update config-schema
* add tests

πŸ‡³πŸ‡±Netherlands JoshaHubbers

JoshaHubbers β†’ made their first commit to this issue’s fork.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Duplicate of πŸ“Œ Replace README.txt with README.md Fixed .

If you are hunting credits, please stick to the original issue.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

As clearly stated on the page, this module is no longer supported.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Please consider this solution: apply array_filter to strip the empty elements from the array in appendDirective...

πŸ‡³πŸ‡±Netherlands JoshaHubbers

JoshaHubbers β†’ created an issue.

πŸ“Œ | Piwik pro | PHPcs fixes
πŸ‡³πŸ‡±Netherlands JoshaHubbers
πŸ“Œ | Piwik pro | PHPcs fixes
πŸ‡³πŸ‡±Netherlands JoshaHubbers

JoshaHubbers β†’ created an issue.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

drupal:payment

should be

payment:payment

πŸ‡³πŸ‡±Netherlands JoshaHubbers
drupal:currency
drupal:payment

should be:

currency:currency
payment:payment
πŸ‡³πŸ‡±Netherlands JoshaHubbers

In our code we dit something like this:
'style-src' => 'https://somedomain.com ' . $this->getInlineStyleSha(),

But when there was no return value from getInlineStyleSha(), the added directive is
'style-src' => 'https://cloudstatic.obi4wan.com https://fonts.googleapis.com '
It ends with a space. Apparently the space is converted to an empty array item in the module.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Uhm, thinking further... if we move to D10, we need to change nothing, because just as you said: That's Symfony 6, so the IBAN validator is automatically upgraded. So, sorry, but I will close this issue than without any changes... Feel free to reopen it if you disagree.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

I have been thinking about this and I don't like the idea of putting Symfony files in the module, since Symfony is included when Drupal is installed. I propose to make a new version that is only for d10 and above that uses this. Is that ok?

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Patch-version of this patch to be included in composer patches.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

This is fixed in the dev version as far as I can see:

$entity_type = $entity->getType();

    if (isset($config[$entity_type]) && $config[$entity_type]['is_activated']) {
πŸ‡³πŸ‡±Netherlands JoshaHubbers

JoshaHubbers β†’ created an issue.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Ah, I see some additions 2 months ago in the "blame" sheet.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Thanks for your patch! I will test it. Do you have examples of IBANs that don't validate well?

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Patch updated after core update

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Hello Erik,

Would you consider making us co-maintainer for the module? Toghether we could release a stable version...

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Is a release of the 2.x branch planned, so we can be d10-compatible?

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Added patch for currency.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Good point. I will also add this to the module page.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

I reviewed the mr. It looks good. Added some small text improvements. And changed the CDN to a select because that is much more userfriendly in this option in my opinion.

Have not tested it in a real live site yet.

πŸ‡³πŸ‡±Netherlands JoshaHubbers

Thank you @ressa. We still use the 1.x version because that is the stable version. If this is also fixed in the 2.x version in issue #3326461, I would propose to stick to the 1.x change in this ticket and handle the 2.x changes in the other?

Production build https://api.contrib.social 0.61.6-2-g546bc20