- Issue created by @joshahubbers
- π³π±Netherlands joshahubbers
This is the patch. I know it is not to be comitted to the module this way, but for reference if someone needs it.
- πΈπ°Slovakia kaszarobert
There's a cookie consent solution for this module I made for the COOKiES modules: https://www.drupal.org/project/cookies_media_entity_facebook β
There I basically modify the script tag this way:/** * Implements hook_preprocess_HOOK(). */ function cookies_media_entity_facebook_preprocess_media_entity_facebook(&$variables) { $variables['script_attributes']['data-sid'] = ['facebook']; $variables['script_attributes']['type'] = ['text/plain']; }
I think a similair approach would be better to set the
data-cookieconsent="marketing"
. Another question would be that since every cookie consent solution does things differently, should we commit to this repo as a submodule, or should we create separate module for that, or should we create a MR to include that to the Cookiebot module instead? - π³π±Netherlands joshahubbers
Thanx @kaszarobert. Ik think you have a fair point here. Thinking about it, a hook like yours could be added to the module, only we don't use the module but it is integrated via google tag manager. So than we should incorporate it in a custom submodule for ourselves I think.