Use Google Workbox library

Required

✅

✅
✅
✅
- ✅
- ✅
- ✅

✅ This has been completed, though it's not a 1:1 copy as the various config pages have been kept on the same URL nesting level for better UX, i.e. so users don't have to go up or down a level/category just to see certain local task tabs.

✅

✅ This has been upped to 1000 kilobytes based on the current median size in the referenced link.

❌ Documentation for installing Workbox, both with and without Composer.

⌛️ Change record → .

Bugs

✅

Drupal core issue 📌 Exception in EarlyRenderingControllerWrapperSubscriber is a DX nightmare, remove it Needs work
Lullabot article

✅ This seems to work fine now and was likely a quirk of not starting with the 8.x-1.x branch before running updates.

Nice to have

✅

❌ Add configurable path to Workbox library.

✅

❌ Convert _template.js into a Twig template similar to what Drush does with their generators.

This is more complicated than it first seemed as the Drupal twig.engine hard codes .html.twig and assumptions that the output will be HTML rather than anything else.
See also the twig service which may be worth investigating.
See this Drupal Slack question as well.

❌ Convert the asset cache config (pwa.config.cache_assets) to Configuration Entities → ?

Pro: could make things easier long term and allow more customization/alteration opportunities.
Con: might be overkill if we never add more than the four types we have now.

❌ Use the Symfony Validator for various things by implementing validation plug-ins → :

❌ CacheConfigurationForm: Workbox strategies for page rules and assets.

Original summary by ChristophWeber:

We (the team at Achieve Internet) have been researching tooling for Progressive Web Apps and looked into Google's Workbox library.
In our minds using a library that is widely used to support the basic functions of a PWA would make a lot of sense.
If anyone is interested we can share more about our experience, and of course we are curious what others think.

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇩🇪Germany Anybody Porta Westfalica
Settings this Major, as it's supposed to fix a lot of other issues and save us some (or not). But at least we should not first fix other code that's then replaced by this.

Google Workbox looks very useful for all Serviceworker functionality.
Status changed to Needs work over 1 year ago7:42am 21 September 2023
Comment over 1 year ago →
🇯🇵Japan tyler36 Osaka
Patch did not apply against `drupal/pwa:2.0.0-rc2`.
Comment about 1 month ago →
🇳🇱Netherlands joshahubbers
Well, I was struggling with caching too, and stumbled upon this issue. Only this issue is far behind the current version of the module. I did some fiddling around, but did not get a proper way to merge this code into the current version. So I created a very basic implementation of the current workbox script. It is lacking nuance, and is rather crude. But I think it is working for now. Maybe a starting point to work on going forward.

Use Google Workbox library

Legend

Required

Bugs

Nice to have

Comments & Activities