Missing schema for smartdate_custom

Created on 2 December 2024, 11 months ago

Problem/Motivation

The smartdate_custom format has no complete schema definition.

Steps to reproduce

Use the smartdate_custom format in a display.

Proposed resolution

Complete the schema.

πŸ› Bug report
Status

Active

Version

4.2

Component

Code

Created by

πŸ‡³πŸ‡±Netherlands joshahubbers

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @joshahubbers
  • Pipeline finished with Success
    11 months ago
    Total: 157s
    #356568
  • I have applied the patch it works fine for me so moving it to the RTBC
    Thanks !!

  • Status changed to RTBC about 2 months ago
  • πŸ‡©πŸ‡ͺGermany stefan.korn Jossgrund

    stefan.korn β†’ made their first commit to this issue’s fork.

  • πŸ‡©πŸ‡ͺGermany stefan.korn Jossgrund

    It's true that schema defintion for smartdate_custom formatter is not valid. Drupal 11.2 LenientConfigSchemaChecker is complaining.

    But seems to me the schema definition for the smartdate_custom formatter from this MR could be reduced by using the config from the core timestamp formatter from which smartdate_custon is inheriting.

    I am not exactly sure if all the "label" types are required in the schema. I believe label types would be relevant if the config setting should be translatable?

    I have updated the MR. LenientConfigSchemaChecker is not complaining anymore now, but MR should be reviewed regarding the types of the config options.

Production build 0.71.5 2024