- Issue created by @joshahubbers
- 🇳🇱Netherlands joshahubbers
I added the patch to enable sound by default. It follows the device setting of course, so when sounds are muted a buzz is played, or nothing at all, depending on the user phone preference.
- 🇳🇱Netherlands joshahubbers
Also fixed some pipeline-things. Only composer next minor fails. Don't know why exactly.
- 🇯🇵Japan ptmkenny
Hi, thanks for this MR. I think this is a good change but please submit a new MR that only has the fix for playing a sound; the pipeline stuff should be fixed in a separate issue.
- 🇯🇵Japan ptmkenny
I'm going to add a new argument, $silent, to the API to enable people to get silent notifications if necessary.
- 🇯🇵Japan ptmkenny
ptmkenny → changed the visibility of the branch 3529972-default-messag-does to hidden.
- 🇯🇵Japan ptmkenny
@joshahubbers Ok, I created a new branch that adds a preference (default: sound on) to override the behavior. Please test it and let me know if it works for you.
-
ptmkenny →
committed 4b6d7aa4 on 7.0.x
Issue #3529972 by joshahubbers, ptmkenny: Play notification sounds by...
-
ptmkenny →
committed 4b6d7aa4 on 7.0.x
- 🇯🇵Japan ptmkenny
Ok, I was able to get this all working on my setup, so I'm going to commit. To be honest, I never tested notifications with sound because I don't use them personally so I didn't realize this had to be added. It's fixed now though, many thanks!