ptmkenny → created an issue.
JSON-RPC 3 beta 1 has been released, so let's move to support it.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
We'll address all this in : https://www.drupal.org/project/decoupled_passkeys/issues/3472603 📌 JSON-RPC 3.x: Update object imports Postponed
This module uses JSON-API, not JSON RPC.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
All the "must haves" are done so I am releasing beta 1.
ptmkenny → changed the visibility of the branch attributes_refactor2 to hidden.
ptmkenny → changed the visibility of the branch attributes_claude to hidden.
ptmkenny → changed the visibility of the branch attributes to hidden.
Found a way to work around this; see the referenced issue.
I need specific steps to reproduce this error before I can commit a fix.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
Drupal 9 support has already been dropped.
Setting back to RTBC based on #4 and #7, and the change in #9 was reverted.
@pbonnefoi Yes, the service should generally be auto-loaded, but since the constructor accepts NULL, we have to handle the case of a NULL value, since that is the API argument. To preserve BC, eliminating the NULL argument can only happen in a module major version update.
@pbonnefoi Please explain what "the same error as #7" means-- #7 did not apply the MR. Your commit breaks backward compatibility because it changes the acceptable argument type by removing null. I think this is an unnecessary change and out of scope for this issue; please explain why the change is necessary.
For now, I have updated the module page to note this incompatiblity.
Comment from the security issue by alexpott:
I think this is the same as the caveats for Views filters or JSON:API filtering but should ideally come with a solution of sorts. Maybe an error if you try to encrypt a field or some form other way of doing uniqueness without knowing the value.
Comment from the security issue by ptmkenny:
I was able to reproduce the behavior locally and confirm the bug.
Regarding the example of the mail field, if you use the Field Encrypt module to encrypt the "mail" or "name" base field, it will break logging in to the site, but it will not (to my knowledge) expose any information; you will just have a broken site (which is not good, but it is not a security issue; I will open a follow-up issue later to fix this by not showing the mail and name fields as options). For people who need to encrypt email addresses, the Dbee module is available and works well (this should be noted on the Field Encrypt project page under Known Limitations).
This issue is a result of the entity query in the UniqueField constraint not having access to unencrypted data, which will result in failed validation (values will always be considered unique). This is a bug, but I do not think it is a security issue because the encryption is maintained (also, this is not a case of breakage in which a feature stopped working; the module has never worked with the UniqueField constraint), so I think it is safe to work on publicly.
ptmkenny → created an issue.
Closing as it seems the module complies with the JSON:API spec.
Closing as there was no follow-up. Feel free to re-open if this is relevant for you.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue. See original summary → .
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.
Ok, I was able to get this all working on my setup, so I'm going to commit. To be honest, I never tested notifications with sound because I don't use them personally so I didn't realize this had to be added. It's fixed now though, many thanks!
Apparently the badge count not being set correctly for Android is a difference among Android launchers. I'm testing on a 7-year-old phone, so maybe that's why. I'm going to commit this because this is better than nothing.
ptmkenny → created an issue.
ptmkenny → created an issue.
ptmkenny → created an issue.