- Issue created by @andrei.vesterli
- 🇯🇵Japan ptmkenny
Please add an MR, not a patch. This module runs automated tests via GitLab CI, but only MRs get tested, not patches. So we need an MR to run the tests.
There is a crash for /jsonapi/carts
endpoint when this module is enabled. It looks like there might be arrays with entities, but the entity item might be NULL.
See, createCollectionDataFromEntities
and $entities
array for more context.
Here is the crash result:
1. Enable the module jsonapi_resource
2. Enable the module commerce_api
3. Use the API endpoint jsonapi/carts
when the cart is empty
4. See the crash with the message above.
Write a patch for covering then the $entity
variable from createCollectionDataFromEntities
, which is NULL
instead of an actual entity. This validation should be covered here and not inside the commerce_api module.
Write the patch.
No.
No.
No.
Active
1.0
Code
Please add an MR, not a patch. This module runs automated tests via GitLab CI, but only MRs get tested, not patches. So we need an MR to run the tests.