I have compiled the SCSS into CSS using npm run build, as the CSS file should be included in the MR. Now, the MR fixes the issue. Please Review!
anirudhsingh19 → made their first commit to this issue’s fork.
Installed the module and applied the MR. Can confirm that we now have a new status form input as a checkbox on the add/edit form (/admin/config/workflow/notifications/add). Attached the screenshots.
The form was giving an error because ConfigFormBase in Drupal 11 requires 2 mandatory parameters, i.e, ConfigFactoryInterface and TypedConfigManagerInterface.
Ok, the error is getting reproduced on Drupal 11.2.5, working on it!
@trickfun I installed the module, but I'm not getting any errors— are there any other steps involved?
I agree with @seutje that this issue only deals with the styling, which is already there, actually getting applied to buttons. The styling for the cursor should be handled in a separate issue. Moving this to NR.
I was able to reproduce the issue on D11 site, I have raised a MR and the issue is getting fixed now. See the screenshots.
After applying the MR, I'm seeing the old twitter logo. Am I missing something here?
I installed the module on D10 and can confirm the issue exists (See the screenshot). For reproducing the issue, I created a custom module and a new select field in a form. I applied the MR and issue was fixed. Hence, moving to RTBC.
Can confirm that the page on url /admin/config/services/stripe_api reports the error. After applying the MR, the issue got fixed and also the configuration was getting saved. Attaching the screenshots for reference. Moving to RTBC.
I created a small custom module to define an "my_extra_field" on the article content type. Then I created a new article and viewed the page and got a WSOD with -
Error: Call to a member function isComputed() on null in quickedit_preprocess_field() (line 203 of /app/web/modules/custom/quickedit-3552421/quickedit.module)
.
After applying the MR, the issue got fixed. See the screenshots.
The MR doesn't fix the issue. scss needs to be compiled into css. See the screenshot for reference.
@leisurman I tried changing the path to <img src="{{ active_theme_path }}/assets/img/usa-icons/close.svg" alt="close" /> but this is also incorrect. Also, I didn't find any close.svg in the theme directory.
After applying the MR, the theme still loaded correctly. I also created a custom module to try to override the twig template with more specific naming views-view-field--my-view--status.html.twig, Before the MR, it didn't get loaded as it should instead the less specific one from gin theme was getting rendered. After the MR, the more specific one gets rendered, so the intended changes are working correctly and if its not more specific then the one from the theme will be rendered, so we can safely remove the code.
*The status(published) field on content view page uses this template*
Moving this to RTBC.
@rkroller (#15), I believe that the reason we have more changes in https://git.drupalcode.org/project/gin/-/merge_requests/635.diffis because the source branch is created from branch 4.0.x and in the MR target branch is set as 5.0.x instead of 4.0.x, so we have different set of commits in our source branch which are not in the target branch.
The patch worked for me. @divya.sejekan We have to also enable the interface translation module along with language module and then add the translation manually in /admin/config/regional/translate for our string. As the Drupal.t() function only makes the string translatable but doesn't translate the string automatically on changing the site language.
Created a MR as patches have been deprecated. Attaching screenshots for reference.
I confirmed that there were no suggestions for eva_display_entity_view before the MR. The MR applied cleanly and after the MR, there were suggestions visible which includes the view id and current display name.
Moving this to RTBC. Attaching screenshots for reference.
Even after unchecking 'Insert horizontal line', the line still appears in bootstrap based theme. The MR gets applied cleanly on my D10 site, with Bootstrap5 → as my theme. After applying the MR, the issue gets fixed. Attaching screenshots for reference.
Moving to RTBC.
The MR applied cleanly. The required classes are now visible by default in form UI, and gets applied to the link unless the user overrides it. Attaching screenshots for reference.
Moving this to RTBC.
I was able to reproduce the issue on Drupal 10.5.3, and version 6 of Modal. It worked fine with version 5 as stated by @keszthelyi.
I applied the MR and it fixed the issue, as visible in the screenshots. I think this is the MR which caused this: #3281106.
Moving this to RTBC.
Confirmed that there was no form-item class on the parent div. Compared with other themes and confirmed that in claro and bootstrap5 theme, the parent div had form-item class. After applying the MR, the form-item class gets added correctly. See the screenshots.
Moving this to RTBC.
Due to different symfony versions in D10 and D11. We had different ways of declaring $message in the base class. So, currently our class has public string $message, and it don't work in D10 and work in D11, but when I declared $message without defining it as string and used public $message then it stopped working in D11 but worked in D10. So, for compatibility in both versions had to use the constructor for updating the value of $message from parent class instead of declaring it again. I have also checked if a custom message has been provided, and it will be given priority. Please review!
The patch works fine. Please provide a MR as patches are not recommended anymore.
The MR solves the issue, now on hover the full name of the file can be seen. Attaching the screenshots for before and after on hover. I also tried to add a file with too long file name but the max-length is 240 characters, so the whole block overflowing out of the box won't be a problem here.
I was able to reproduce the issue on Drupal 11.2.4 with PHP 8.3.23. After installing the module, the reported error does appear. After applying the MR, the error is no longer present. I’ve attached before and after screenshots, which confirm that the MR resolves the issue. Hence, moving it to RTBC.
Using this solved the issue for me:
.region-sticky__items {
width: auto;
}
Created a MR for the fix, can confirm that the changes work. Attaching the screenshots, Please review!
I tried to reproduce this issue but to me the styling looked perfect. I dig into it and saw that it may have been fixed due to the changes here: [#2398459] feat: Clean up "captions" component in Bartik. This is the issue: #2398459 📌 Clean up "captions" component in Bartik RTBC .
I think this issue should be Closed as outdated.
1. Added the id prop in heading, cta and hero-1 component.
2. Added the id attribute in twig templates.
3. Also, used twig filters to make entered id in lower case and replace space and underscore with hyphen. id attribute is only set if the id is given.
Please review!
Removed the full comment and validation to check if $form['#attributes']['class'] is already set. Please review!
I was able to reproduce this error. The problem was that in version 4.1.0 the buildForm() expects different schema for services from version 5.x. The buildForm() was updated in 5.x but the config/install/better_social_sharing_buttons.settings.yml was not updated accordingly. So that's why it gave error.
This needs to be updated, as the config page doesn't work at all when installing the module.
I have removed the gitlab-ci.yaml file from MR as it was unrelevant for this issue. I can also confirm that the changes worked without it. Attaching a screenshot for reference. Please review!
I have improved the contrast color for hyperlinks for byte light and byte dark mode. I have made sure that it pass the WCAG AA and WCAG AAA tests. Please review!
Earlier the toolbar was showing under the content. Which was due to indexing issue. I have fixed this. Please review.
@ressa Made the text color light grey on hover. And for the placement of button on top, I may not be able to help in that, so I'm leaving this to NW for someone else to pick it up.
I have implemented the proposed style for the link. Please review!
working on this
Re-rolled the MR,
Please review!!
working on it
Experimented with the colors. Still uses the accent colors from gin variables.
I have used the gin-color-primary variable here, so the color will change according to selected gin's theme accent color. I thought it would make the color match gin theme .But yes, we can use our own color too.
Now the icons color is also changes according to light and dark mode. Instead of using background-image property I have used mask-image property.
@doxigo I have explored a little and found a way to do that, working on the changes.
I have updated the circular icons so their background color now matches the theme’s primary color. I also cleaned up the MR by removing redundant code.
If the icons had been implemented as inline SVGs, we could have changed their colors according to light and dark mode, but since they’re being used via CSS background-image, that option isn’t available.
working on this.
I have remove the color_mode prop from all *.component.yml files. Not sure, If the color_mode variable needs to be removed from twig templates.
working on this
@richardgaunt I have created a PR Issue #3525185 by anirudhsingh19: Expose banner type as a variable for this issue on GitHub Drupal monorepo. Apologies for being this much late.
Please review.
working on this!
As mentioned by @fizcs3, The duplicate messages were caused by 2 templates.
templates/page--mercury-editor.html.twig
<mercury-dialog id="me-edit-screen" hide-close-button push resizable dock="right">
{{ page.highlighted }} <strong>Responsible code</strong>
{{ page.content|without(local_actions_block) }}
</mercury-dialog>
templates/mercury-editor-entity-form.html.twig
{{ attach_library('mercury_editor/node_form') }}
{{ form['status_messages'] }} <strong>Responsible code</strong>
<header class="me-node-form__header">
<h1 class="me-node-form__title">{{ form['#title'] }}</h1>
</header>
{{ form|without('status_messages', 'advanced', 'footer', 'actions', 'gin_actions', 'gin_sidebar', 'gin_sidebar_toggle') }}
I think the later was better to be removed as the first one was styled better, according to the default administration theme.
working on this.
Please review.
working on this.
I tried applying the patch but got:
git apply tara-slider-modern-jquery.patch
error: corrupt patch at line 14
I think it happened because /js/slider.js is minified file. I have made the changes and raised MR. Please review!
working on this.
Please review!
working on this.