- Issue created by @joachim namyslo
- ๐ฉ๐ชGermany jan kellermann
jan kellermann โ made their first commit to this issueโs fork.
- ๐ฉ๐ชGermany jan kellermann
Then please have a look and give feedback :)
We added classes for gin but also for general dark mode without gin as admin theme.
- ๐ฉ๐ชGermany joachim namyslo Kulmbach ๐ฉ๐ช ๐ช๐บ
Well, that looks much better than before.
It would be nicer, of course, if the background color of the circular icons could be adjusted when the values for dark mode are applied.That would make the widget look much rounder.
What I also noticed is that the Duplicate entry created by ECA does not have an icon. Here, you could consider implementing a generic icon for such cases, but that should be the subject of a separate issue.
- ๐ฎ๐ณIndia anirudhsingh19
I have updated the circular icons so their background color now matches the themeโs primary color. I also cleaned up the MR by removing redundant code.
If the icons had been implemented as inline SVGs, we could have changed their colors according to light and dark mode, but since theyโre being used via CSS background-image, that option isnโt available.
- ๐ฎ๐ณIndia anirudhsingh19
@doxigo I have explored a little and found a way to do that, working on the changes.
- ๐ฎ๐ณIndia anirudhsingh19
Now the icons color is also changes according to light and dark mode. Instead of using background-image property I have used mask-image property.
Great work so far, I personally don't like the accent color used. We should do our own good looking UI instead of doing high contrast accent colors
- ๐ฎ๐ณIndia anirudhsingh19
I have used the gin-color-primary variable here, so the color will change according to selected gin's theme accent color. I thought it would make the color match gin theme .But yes, we can use our own color too.
- ๐ฎ๐ณIndia anirudhsingh19
Experimented with the colors. Still uses the accent colors from gin variables.
- ๐ฉ๐ชGermany joachim namyslo Kulmbach ๐ฉ๐ช ๐ช๐บ
Oh I like that a lot. Thank you very much.