@doxigo

Based on the screenshot provided, I see that it's radix:nav that can cause the issue, let me check and keep you posted

Thomas pushed a fix to the latest dev release, could you test and see if it fixes the issue?

Hey Thomas, thanks for the issue, I am aware, hopefully push a fix today, the issue is that the media breaks if I fix the Image and vice-versa, will wrap it up

Great work Diego, and thanks for the MR, merged

doxigo → made their first commit to this issue’s fork.

doxigo → created an issue.

Lovely, thanks a lot Aleix. merged

doxigo → made their first commit to this issue’s fork.

This is now fixed, revamped the Progress component and borrowed some of @pdureau code from UI Suite to get the Drupal.theme.progressBar in place

Oops, yes that's a mess for sure, thanks a lot for pointing that out and of course for the merge request, merged.

doxigo → made their first commit to this issue’s fork.

Okay that's not what Radix does. it shouldn't be a Radix issue. Radix does not modify the render array, it could possibly be your view mode, other contrib modules that is causing this. could you test to see if now you revert back to 6.0.0-beta12 it gets fixed?

Hey Willem, could you share the error you are getting?

Thanks for noticing this Milos, I'd like to avoid any preprocess in case that it might break some future changes in core.

for now this is how I got around the issue which fixes the issue and keeps the wrapper as is, not ideal but better than a double wrapper for sure.

Good idea Phil, reverted it for now.

Thanks a lot guys, merged.

lovely, thanks a lot. there were some minor merge issues in page-content.twig, I ended up applying the rest with --reject flag.

Thanks a lot ckng for the MR, all is valid but I wonder why did we change this part:

{% set page_header_container_classes = [
  page_header_container_type is null ? 'container' : '',
  page_header_container_type ? 'container' ~ (page_header_container_type ? '-' ~ page_header_container_type : '') : '',
  ]|merge(page_header_container_utility_classes ?: []) 
%}

into:

{% set header_container_class = '' %}
{% if page_header_container_type is null %}
  {% set header_container_class = 'container' %}
{% elseif page_header_container_type is not empty %}
  {% set header_container_class = 'container-' ~ page_header_container_type %}
{% endif %}
{%
  set page_header_container_classes = [
    header_container_class
  ]|merge(page_header_container_utility_classes ?: [])
%}

also the same for page_content_container_classes

and if we are to pass page_content_container_type: false, isn't that better to set it to false at the source? also I rather keep the container rather than not having it. setting it to false gets rid of it.

I got rid of the py-5 class as you suggested from the page-content and passed it from the page.twig, let me know if this suffice or you think we need more adjustments.
marking this as fixed, feel free to re-open, thanks

tagged 1.0.7 for drupal-radix-cli to get around this issue, please do npm update drupal-radix-cli to get the latest version.

Just released the 1.0.6 tag, thanks for the issue, please do run npm update drupal-radix-cli to get the latest version and test it out and let me know if it works as expected or not.

Good idea, will do so. but the issue should probably go to Github rather than the Drupal theme. but thanks

Here's a patch against 3.0.x in case anyone needs it

Good suggestion Phil, do you mind providing a MR? if not let me know and I'll look into this.

Hey @sibiru, could you test again with the latest dev and let me know if its good now?

doxigo → made their first commit to this issue’s fork.

Changing the targeted branch to 6.x

Since we are not gonna develop 5.x anymore, I'll change the version to 6.x. We currently have a progress bar and we need to make sure that the core progress bar uses that. changing the version and the title

Thanks for the issue Lee, somewhat considered in 6.x

A lot of great work there with examples and Storybook integration, I hopefully will get there soon if I find some free time, still not sure about integrating with the " Storybook → " module or the old approach.

Will have to investigate a bit further.

Regarding the Accordion (and similar child/parent components), I wasn't sure if a separate component makes sense or not. I just went on with 1 component fits all approach.

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

Let's hope that I manage to get the Radix to a RC state first, it has been one too many fixes/commits.

but yeah let's evaluate at a more stable state later on, thanks a lot for your work as well, closing the ticket then.

Another great catch Martin, merged

doxigo → made their first commit to this issue’s fork.

Thanks for the follow up Martin, merged

doxigo → made their first commit to this issue’s fork.

You have a good point regarding the fact that it shouldn't be SDC, I'll have to circle back on this issue and see if we can make some adjustments. it's good to keep it within the components directory in general to match Bootstrap but your points are also valid.

Great, thanks for picking this up. also added author utility classes. merged

doxigo → made their first commit to this issue’s fork.

Thanks Milos, merged but note that you can omit the value if the key/value are equal, so I just adjusted it a bit to:
{% include "radix:form-element" with {
errors,
prefix,
suffix,
type,
name,
label,
label_display,
description_display,
} %}

doxigo → made their first commit to this issue’s fork.

This actually prompts me to make sure a lack of Component Schema shouldn't break the drupal-radix-cli, we need to add a safeguard there, maybe do a fix there as well? :)

Great work as always Martin, merged

doxigo → made their first commit to this issue’s fork.

Thanks a lot Phil, merged

doxigo → made their first commit to this issue’s fork.

Good catch Aaron, sounds about right to me, and thanks for the MR, merging

doxigo → made their first commit to this issue’s fork.

Pushed a fix for this, thank you all for the help.

Hey James, currently we are rather a bit away from considering tagging a stable release. there's a lot of improvements to be done on different components and overall SDC integration. We are fixing things as we see it while working on other projects. unfortunately I don't have a lot of free time to fully dedicate and make a stable release viable but there are some todos and blockers that I are known and I'll add them later on here.

A changelog before a stable release is just time consuming, hopefully once we are stable, I'll add that as well.

I need to get to this issue and check it out but isn't that a better idea to define the default value in the source rather than the calling template?

Thanks for the patch, but if it's an SDC issue, you have to patch it in Drupal core queue, this patch doesn't apply to Radix but rather core. if that's the issue, I have no means of testing this on a Windows machine, but thanks anyways. closing the ticket.

I'll use my own linting, but I can add some linting later on.

A lot of great stuff in the new release, thanks a lot.

to be honest not really a fan of Drupal standard linting in general, just takes time to do meaningless work! but that's just my take.

Thanks for the patch and the state change, fixed and pushed to the latest dev

Thanks a lot for the help Pierre and a lot of good tips and hints, most are fixed now, some are opinionated but all is good so far. Feel free to re-open with your great suggestions, marking this as fixed for now

marking this done, feel free to reopen

Lee, as you mentioned and per this issue, for the time being and with Bootstrap 5.x, we will stick with @import, mark this as won't fix.

Hey Phil, thanks for re-opening, the issue was within the form-element, pushed a fix

Thanks Milos, pushed the fix

Hey Dmitry, no need to add your stand alone CSS/JS or any other assets to anywhere else but it should load on it's own as long as you kept the same name for the component folder, the CSS, js and the twig file.

I suggest that you read the documentation here

Hey Andreas, thanks for the issue and sorry for a late reply, I pushed a fix to the latest dev version

@punit, your MR is just a lot of changes and wrong, sorry can't merge that one.

thanks Andy, yeah could be useful for future possible features as well, since you are the new maintainer, feel free to tag a 2.x

Andy, thanks a lot for well a whole rewrite and tests along with it, dropping support for D8/9 is just fine for sure.

To answer the followings:

• Could we add a default icon in case there isn't one? Or alternatively just not show a link in the sticky tasks?

- Yes we should, that we should for sure, happened on a website I've seen recently.

• When not using the block, we could provide a textarea for users to specify paths, similar to block visibility

- Would be a nice addition

• We could possibly recognize entity routes when trying to select an icon, eg. entity.*.edit-form.

- isn't that what we are already doing? or what exactly you mean by recognize?

• Not my strength, but I think it's better to add classes than inline styling via JS, where possible.

- The animations in general are not the best, it was the first draft that got stuck, yes we can/should make it more fancy.

• Also not my strength, but I was wondering if a transition would be a simpler way to achieve the animation than, er, an animation (:

have to check the code, but I thought I did use transition in the animation

The patch seems to fix the issue

Thanks for your work jcandan, this is not actively supported, so could you provide a MR? and someone need to test it afterwards

@jcandan could you open a new Pull request on a new issue so I can merge? the 8.x-4.x is no longer maintained

Lee, re-opening this since we might be able to incorporate this partially, will check it out later, thanks

@jcandan, it is on our todo list, but I am considering it with the Storybook → module instead of Twing/TwigJS approaches. but that would be the integration would be done once we are stable with the 6.x branch and if I get some free time, didn't get the chance to look into it much.

Amstercad → credited doxigo → .

is the import { Tooltip } from "./_bootstrap"; path correct? considering probably your component is within your components directory? you should import Tooltip from the node modules

Thanks Sam, could you please provide a MR?

Added a new documentation page here. Please check it out and let me know if anything is missing, thanks.

This is fixed Milos, thanks

Hey Lee, what you need to do is to pass the btn-primary or any other classes to the card_link_utility_classes in the card, you cannot override the default card_link_classes. that's the base classes and needed for the card to look the way it is. Regardless updated the README and the docs to include card_link_utility_classes, thanks

Thanks a lot Sam, works as expected 🎉

doxigo → made their first commit to this issue’s fork.

doxigo → created an issue.

@anybody hey, tbh I don't even remember what project it was at the time that I was working on :D
have to test and keep you posted

@erutan, can you update your subtheme links.html.twig file? the block slots has renamed, see if updating that helps

yeah I see your point, and I need to give your theme a go, thanks a lot anyways but feel free whenever you wanted to jump in, let me know.
Otherwise I appreciate your contribution in general