@doxigo

You are totally correct, thanks for catching this, I should have paid more attention merging MRs, can you provide a MR?

Thanks for the MR, merged

doxigo → made their first commit to this issue’s fork.

Yeah sounds good, we should look into that at some point, Thanks a lot for the MR 🙌

The same happened to me with a downgrade from 5.x to 3.x, I suppose that's expected

The MRs were a bit confusing, I just kept both the form-inline and d-flex

removed

I'm not a fan of adding SCSS files or hardcoded styles into the theme at all but no better solution I guess.
Thanks for the fix Sam

doxigo → made their first commit to this issue’s fork.

Using rel="nofollow" on pagination links can actually hurt your website's SEO and indexability.
if anything we can add those ourselves if we reckon that could help fight bots per project, and for fighting bots there are other solutions outside of the scope of this I believe which makes more sense.

Closing this as won't fix

Thanks, merged

Yes that, so I can merge and call it a day :D

Thanks Gaurav, could you please also update the README to include this in within your MR?

Thanks guys for the time spent and discussing this, closing this as works as designed

Thanks guys for looking into this, I updated the docs with your suggestion:
https://radix.trydrupal.com/radix/understanding-radix/bootswatch

Marking this as Closed.

Lovely, nice fix. Applied to the dev.

I see, thanks Aleix, could you also do me a favor and update the README file of the component as well if needed in the MR?

Thanks a lot Aleix for the patch and the issue.
I am yet to test this but I wonder if this is a proper solution for nolink and button, they will probably fall into the else section.

the - for the divider works I suspect but not sure

That aside, if they are meant to be a dropdown, does it need a dropdown-header class maybe?

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

Perfect, thanks

Cool thanks, can you make a MR?

@jcandan It depends on what you prefer, but yes, that's one way. I'd like to support Storybook as well out of the box, but it's rather an extra overhead and time-consuming, and most of our users in Drupal don't really use Storybook that often, so I prefer to use my free time for the theme itself or possibly extend it into Tailwind

thanks though, yup covered in the other issue

Thanks a lot Christopher, merged and updated the https://radix.trydrupal.com/radix/components/offcanvas as well

I noticed some duplicates there as well, that aside I wonder if we should make that into a boolean instead of string.
Would appreciate another MR

doxigo → made their first commit to this issue’s fork.

Cool, thanks Christopher. Merged

doxigo → made their first commit to this issue’s fork.

I've seen this as well, can't recreate it.

Got the same error on production on Drupal 10.4.7, seems related:
https://www.drupal.org/project/gin/issues/3509501 🐛 User warning: Trying to overwrite cache redirect Active

Darren, I get a warning once I grant a user any permission on a node:

Warning: Undefined array key "grant_view" in Drupal\nodeaccess\Form\GrantsForm->validateGrants() (line 224 of modules/contrib/nodeaccess/src/Form/GrantsForm.php).

Test wise:
Warning: Undefined array key "grant_view" in Drupal\nodeaccess\Form\GrantsForm->validateGrants() (line 224 of modules/contrib/nodeaccess/src/Form/GrantsForm.php).

That aside, there are room for code improvements as well

Looks really solid Darren, works fine with my tests as well

It looks good tbh and I reviewed these two, which is great work from Darren:
- https://www.drupal.org/project/nodeaccess/issues/3357718 🐛 Warning: Undefined array key "rid" + Trying to access array offset on value of type null in nodeaccess_node_access() Active
- https://www.drupal.org/project/nodeaccess/issues/3144313 ✨ Preserve role grants when adding custom grants on node Needs work

IMO, we can merge the two and tag a new alpha with D11 support.

I made a proof of concept of what I mean, we can make this configurable so it would load the Gin based design or the previous approach.

That aside I believe it would be nice if we have another configuration to have this as a toolbar item rather than a block in a region.

doxigo → created an issue.

There was a typo as well, created a MR

doxigo → created an issue.

Thanks Jukka, I need to further understand the ecosystem myself. My use case is that I already have a "CKEditor automated translation job" that uses OpenAI to translate text based on another field in the node. it works fine and I wanted to switch from OpenAI to another provider. But from what I understood, I can't really do that since the CKEditor text seems to be a "Chat with Complex JSON" scenario.

Thanks a lot for a quick reply.
It just says provider_deepl.settings already exists.

That aside, a side question, do we have AI automators integration? I want to use "Chat with Complex JSON" with DeepL provider.

doxigo → created an issue.

Thanks for the PR, but by enable, you mean setting the localStorage? Not sure if I see the benefit. For instance you prefer if it stays open on all pages whenever you are moving around the website?

Thanks a lot, merged

doxigo → made their first commit to this issue’s fork.

got the same error with Drupal 11.1.7

Thanks everyone, merged into the dev

The MR works as expected, thanks.

The issue still persists with group 3.x

Great, thanks a lot for the MR, merged. Hopefully will tag the last release

doxigo → made their first commit to this issue’s fork.

Thanks guys, merged

Thanks but there's a merge conflict as of now it seems

Lovely, thanks a lot Mikey, merged.

doxigo → made their first commit to this issue’s fork.

Any brave souls to provide a MR?

Glad to hear that, I was starting to doubt that decision, good to get it confirmed

I'm not sure if you are filing the issue under the correct branch or not Thomas but the 6.x does not have a proxy.js file but rather .env.local file, you might have mixed things up with 5.x documentation

And done, tagged 1.1.16

Hey Mikey, thanks a lot for the MR and the Gutenberg work, merged.

doxigo → made their first commit to this issue’s fork.

This causes the error mentioned above and I kinda don't see any way around recovering this

Nothing on my end, not actively working on nodeaccess at all, but I'd say let's give it a bit and see how things are and if all is good we can tag a new release

Thanks a lot Darren, merged.

doxigo → made their first commit to this issue’s fork.

Thanks Rajab for the update, I'll mark this as closed for now since it's not Radix related.

I have no idea Pierre, I haven't looked further into it but you can test on D11, generate some content with devel on let's say olivero, check the content generated and some throw the error. Works after re-saving it though

Have the same issue, the patch didn't work though

@Stephan and @Pierre, I looked a bit further into this, and it turns out at least based on the error I am getting this is not a Radix nor UI patterns issue but rather the D11 core I suspect.

So the error exists on Radix, Olivero, and any other SDC themes, it gets fixed if you just re-save the node.

Stephan, could you check please, and see if that's the case?

Great work, thank you. will check soon

doxigo → created an issue. See original summary → .

@Stephan I managed to recreate it with Drupal 11:

TypeError: Drupal\Component\Utility\Html::escape(): Argument #1 ($text) must be of type string, null given, called in /var/www/html/web/core/lib/Drupal/Core/Utility/LinkGenerator.php on line 198 in Drupal\Component\Utility\Html::escape() (line 431 of core/lib/Drupal/Component/Utility/Html.php).

I'll keep you guys posted on a fix.

@Stephan I somehow couldn't recreate the errors you mentioned on Drupal CMS. I'll try with Drupal 11 Core to see if that's the case. I suspect it might be a content-specific error.

Would be nice to know what error you were getting.

@Pierre still on my todo list to clean up the remaining components, definitely will give the SDC devel a go, thanks a lot for the help.

It's been a while since I last looked into this and I don't recall the reason for it Tom, I wonder if it's a core issue but we'll investigate, thanks

Thanks a lot, appreciate the work. I am not knowledgeable here as well, so I guess this is as good as it gets for now.

Thanks Marc-Antoine, should I expect a MR?

Thank you, I'll make sure to refer to our conversation when I'm on a call with my therapist. Cheers

Btw, instead of being hostile and calling your co-maintainer someone who stole your code, you could've just said, let's revamp 1.x instead of starting new fixes on 2.x 🙂

Something to think about for the future.

Begging is a big word, especially when I emailed you and told you to work together, wow, you have some issues, instead of reading on git branches please consider a therapist.
To wrap this up:
- So your only issue is that I opened a new branch instead of continuing on the 1.x branch? and you consider that as stealing? just a new branch?

Anyway, don't waste more of my time, best of luck :)

Marking this as Closed (due to lack of thinking capabilities)

Daniel, please consider what you are saying:
- I stole your work with a fix and introducing a new branch?
- You (Yes you have access as a maintainer to all the branches) could've also just merged the 2.0.x to 1.0.x if you wanted to, even though that's wrong, you should just start a new branch like I did :)
- Also did you reported me for creating a new branch :)))

Dear Daniel,
I'm really struggling with your lack of knowledge on how things work, a couple of things:
1. Your code is already open-source
2. I joined your project as a co-maintainer, created a new branch called 2.0.x and fixed this issue https://www.drupal.org/project/gutenberg_ai_tools/issues/3473966 ✨ Please consider using the Ai module Active
3. You sent me an email saying that I stole your code? I'm your co-maintainer FFS :)) If I am to steal your code, would I add a new branch on the same project? You know we both have access to all the branches on a project right?
4. The reason for a new branch is, your code is dependent on obsolete OpenAI module, I integrated it with the AI module, so backward compatibility requires you to create a new branch (please study on that)
5. AGAIN IT WAS STILL ON YOUR OWN PROJECT WHICH YOU HAD ACCESS
6. You kept asking me to opt-in your "Alpha" release into security coverage, you need to be stable first to even try to opt-in
7. Please study on git branches and reasons people branch out and backward compatibility

Marking this as "needs review"

Thanks Stephan, got rid of the whole thing

This is causing too many issues, I just pushed a fix by removing the type limitation on the rows. should be good for now but not the ideal solution.

Please test and let me know if it helped

oh nice catch, thank you Mohammed

doxigo → made their first commit to this issue’s fork.

All good, another MR maybe?

Done Vegard 😍

Great, thanks