@doxigo

Closing this as we no longer support 1.x

Hey Shubham, the Radix 5.x to 6.x is a major upgrade. There's no easy way. Read the docs here

Also added a "Dark theme" checkbox so you can enable dark theme regardless

Okay, I made some changes. Now your MR changes would only load if we enabled the "Gin" as shown below:

Gonna do a bit more cleanup and fixes that would play nicely with this. Thanks for the work guys. Merged

Thanks for the work but I kinda don't like it. We need to make the option to use Gin accent color optional. I tested on a couple of projects with different accent colors and it looks just odd and doesn't go nicely in comparison with the previous UI

I'll see what I can do

Thanks for the MR, merged.

Perfect, thanks for the MR, merged

doxigo → created an issue.

Great work so far, I personally don't like the accent color used. We should do our own good looking UI instead of doing high contrast accent colors

Patch #25 works for me and getting the translation errors fixed.

doxigo → created an issue.

Thanks, It seems you forgot to add credit on this issue

Thanks, It seems you forgot to add credit on this issue

can't we reverse the color via CSS?

I did some initial work on issue 3544529 ✨ Add possibility of adding children from the "Children" tab Active

doxigo → created an issue.

This works as expected, and this is a major blocker, can anyone tag a new release please?

Thanks guys, merged without testing. let's hope for the best 🤞

I was playing around with this and noticed that this is the working version https://git.drupalcode.org/issue/klaro_js-3508237/-/tree/3508237-bugfix-for-536

Given this is quite critical, that kinda blocks half of the functionality and does not really work for CCPA, I suggest we just tag the next version already

doxigo → created an issue.

doxigo → created an issue.

Updated the issue details and provided a MR for you to check with Drupal 11.2

Thanks guys for the update, I watched the video, and followed the exact steps, it does not work on a standalone Drupal 11.2 and higher

I'll see if I can figure out the issue and provide a patch :)

Thanks for the patch Tony. Could you do me a favor and do MR instead?

Hey Jørn 👋
nice to see you in the issue queue, this one is a tough one to crack, I did consider Vite before and did some initial work there a while ago but seems quite complex and you might only manage to get it to work with a ddev config which adds to the onboarding process

here's a branched off version: feature/vite but the job is not done

Here's the README for it.
Give it a go maybe and let me know what you see

Thanks frank, could you do me a favor and provide a MR?

doxigo → created an issue.

The same applies to beta3, bumping to "Critical" and the version. The patch does fix the problem otherwise the module does not work at all.

A side question guys, on what basis a content gets flagged? what prompt are we talking about here? I am getting this when using Pinecone to index

Can you guys check that the file wouldn't get generated once you build the theme at 'assets/js/text.js' ?

Hey guys, thanks for the patch but since this version is no longer maintained can you provide a MR?

Thanks again Stephan, merged

doxigo → made their first commit to this issue’s fork.

Thanks Stephan, merged

doxigo → made their first commit to this issue’s fork.

Thanks a lot, Thomas. This is fixed for now, regarding the card-img class, not sure if this is straightforward since a media can also be, let's say, a video and so on. I think if it comes to it, we can either override the card component or maybe some sort of a custom hook that can detect the media within the card to add the class

On the latest dev version of 6.x, I cannot recreate this, regardless, I implemented the suggested htmlspecialchars_decode. It's good to have that, thanks.

Perfect idea, merged. thanks Wahe

doxigo → made their first commit to this issue’s fork.

Sorry for a late reply here wwwahe, been busy a bit. sounds great and thanks for chipping in

Thanks for the patch @dim-dev, applied to the dev branch for now.

Thanks for the issue. I fixed item 1 and pushed it to the dev. For item 2, it seems rather too complex to fix a use case that barely happens (e.g., websites not having navigation), and if that's the case, we can just achieve that by a lot of copying.

That aside if we are to do Item 2, we should check if there are any blocks or content within the right or left block in the navigation, which is just too much complexity for a simple fix, for that I'm gonna set the second item to "Not going to fix" for now.

Feel free to suggest an easy solution/MR if you have something in mind.

@Jan perfect, now you are a full maintainer.

Feel free to do whatever, thanks a lot for the help

@jan thanks but as of now the MR has some conflicts due to the recent merges, would be nice if you could check them. Also you should become a maintainer since you've been quite active, would that work?

Thank you so much guys, merged.

doxigo → created an issue.

Hey Jan, yes please do support with a MR, ideally against the 2.x

{% include "radix:html" %} In SDC world, it means that go load the html.twig file from the Radix component list. I suggest you start by reading the documentation and watching the first part of the video tutorial

But in short, yes, you copy over the component to your subtheme and modify it there. For an easier process, I suggest using drupal-radix-cli

Marking this as closed. feel free to ask more questions if its unclear after going through the items above.

Oops, thanks for noticing, fixed.

Thanks guys, merged. It would be nice to have the PHP_CodeSniffer also fixed

doxigo → made their first commit to this issue’s fork.

Thanks guys, merged.

I don't think that's going to be that easy to support, more or less the Bootstrap 4 and Radix 8.x-4.x have reached their end of life.
One thing I can think of is to override jQuery version via theme libraries using libraries-override if that would work. Alternatively, consider loading a certain jQuery version with a custom hook_page_attachments_alter

I mark this as closed (won't fix) since there isn't much we can really do here, but please, if you come up with a solution, do share it here for others.

Lovely, thanks a lot, Aaron

You are totally correct, thanks for catching this, I should have paid more attention merging MRs, can you provide a MR?

Thanks for the MR, merged

doxigo → made their first commit to this issue’s fork.

Yeah sounds good, we should look into that at some point, Thanks a lot for the MR 🙌

The same happened to me with a downgrade from 5.x to 3.x, I suppose that's expected

The MRs were a bit confusing, I just kept both the form-inline and d-flex

removed

I'm not a fan of adding SCSS files or hardcoded styles into the theme at all but no better solution I guess.
Thanks for the fix Sam

doxigo → made their first commit to this issue’s fork.

Using rel="nofollow" on pagination links can actually hurt your website's SEO and indexability.
if anything we can add those ourselves if we reckon that could help fight bots per project, and for fighting bots there are other solutions outside of the scope of this I believe which makes more sense.

Closing this as won't fix

Thanks, merged

Yes that, so I can merge and call it a day :D

Thanks Gaurav, could you please also update the README to include this in within your MR?

Thanks guys for the time spent and discussing this, closing this as works as designed

Thanks guys for looking into this, I updated the docs with your suggestion:
https://radix.trydrupal.com/radix/understanding-radix/bootswatch

Marking this as Closed.

Lovely, nice fix. Applied to the dev.

I see, thanks Aleix, could you also do me a favor and update the README file of the component as well if needed in the MR?

Thanks a lot Aleix for the patch and the issue.
I am yet to test this but I wonder if this is a proper solution for nolink and button, they will probably fall into the else section.

the - for the divider works I suspect but not sure

That aside, if they are meant to be a dropdown, does it need a dropdown-header class maybe?

doxigo → made their first commit to this issue’s fork.

doxigo → made their first commit to this issue’s fork.

Perfect, thanks

Cool thanks, can you make a MR?

@jcandan It depends on what you prefer, but yes, that's one way. I'd like to support Storybook as well out of the box, but it's rather an extra overhead and time-consuming, and most of our users in Drupal don't really use Storybook that often, so I prefer to use my free time for the theme itself or possibly extend it into Tailwind

thanks though, yup covered in the other issue

Thanks a lot Christopher, merged and updated the https://radix.trydrupal.com/radix/components/offcanvas as well

I noticed some duplicates there as well, that aside I wonder if we should make that into a boolean instead of string.
Would appreciate another MR

doxigo → made their first commit to this issue’s fork.

Cool, thanks Christopher. Merged

doxigo → made their first commit to this issue’s fork.

I've seen this as well, can't recreate it.

Got the same error on production on Drupal 10.4.7, seems related:
https://www.drupal.org/project/gin/issues/3509501 🐛 User warning: Trying to overwrite cache redirect Active

Darren, I get a warning once I grant a user any permission on a node:

Warning: Undefined array key "grant_view" in Drupal\nodeaccess\Form\GrantsForm->validateGrants() (line 224 of modules/contrib/nodeaccess/src/Form/GrantsForm.php).

Test wise:
Warning: Undefined array key "grant_view" in Drupal\nodeaccess\Form\GrantsForm->validateGrants() (line 224 of modules/contrib/nodeaccess/src/Form/GrantsForm.php).

That aside, there are room for code improvements as well