- Issue created by @jan kellermann
- 🇵🇭Philippines paraderojether
Hi
I reviewed MR!10, and confirmed it passed phpcs on Gitlab CI.
However, there are still phpcs issues reported by PHP_CodeSniffer:
Command used:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig sticky_local_tasks
FILE: /Users/jetherparadero/Q2/q2issues/web/modules/contrib/sticky_local_tasks/README.md ---------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------- 62 | WARNING | Line exceeds 80 characters; contains 85 characters ---------------------------------------------------------------------------------------- FILE: /Users/jetherparadero/Q2/q2issues/web/modules/contrib/sticky_local_tasks/assets/css/sticky_local_tasks.css ---------------------------------------------------------------------------------------------------------------- FOUND 250 ERRORS AFFECTING 125 LINES ---------------------------------------------------------------------------------------------------------------- 9 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 10 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 11 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 11 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 12 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 12 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 16 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 17 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 17 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 21 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 22 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 23 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 27 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 28 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 29 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 30 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 31 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 32 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 33 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 33 | ERROR | [ ] No style definition found on line; check for missing colon 34 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 35 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 36 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 37 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 37 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 38 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 39 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 39 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 40 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 40 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 44 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 44 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 45 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 45 | ERROR | [ ] No style definition found on line; check for missing colon 46 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 46 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 50 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 51 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 51 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 52 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 52 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 53 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 53 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 54 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 54 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 55 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 56 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 56 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 57 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 61 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 61 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 65 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 65 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 66 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 66 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 67 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 67 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 68 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 68 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 69 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 69 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 75 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 79 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 79 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 80 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 80 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 81 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 81 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 82 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 82 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 83 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 83 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 84 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 84 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 85 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 85 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 95 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 95 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 99 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 99 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 100 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 101 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 101 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 102 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 102 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 103 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 103 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 104 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 104 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 105 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 105 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 106 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 106 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 107 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 107 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 108 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 109 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 109 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 113 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 113 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 114 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 114 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 115 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 115 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 116 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 116 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 117 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 117 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 118 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 118 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 122 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 122 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 123 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 123 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 124 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 124 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 127 | ERROR | [x] Selectors must be on a single line 128 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 128 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 128 | ERROR | [x] Selectors must be on a single line 129 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 129 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1 130 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 130 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 131 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 131 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 135 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 135 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 136 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 136 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 137 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 137 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 138 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 138 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 139 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 139 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 140 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 140 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 141 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 141 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 142 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 142 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 143 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 143 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 144 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 144 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 148 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 148 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 152 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 152 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 156 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 156 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 160 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 160 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 164 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 164 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 168 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 168 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 172 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 172 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 176 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 176 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 179 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 179 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 184 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 184 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 188 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 188 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 193 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 193 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 197 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 197 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 201 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 201 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 206 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 206 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 210 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 210 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 215 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 215 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 219 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 219 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 223 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 223 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 227 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 227 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 231 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 231 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 235 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 235 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 239 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 239 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 243 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 243 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 247 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 247 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 251 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 251 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 252 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 252 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 253 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 253 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 254 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 254 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 255 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 255 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 256 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 256 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 257 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 257 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 258 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 258 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 262 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 262 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 263 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 263 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 264 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 264 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 265 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 265 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 266 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 266 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 267 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 267 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 268 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 268 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 2 269 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed 269 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 1 ---------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 248 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------- Time: 260ms; Memory: 12MB
Kindly check and advise, please.
Thank you. - 🇩🇪Germany jan kellermann
Yes, I saw also all this issues. My focus was on getting the Gitlab CI running properly.
- First commit to issue fork.
-
doxigo →
committed 398c55fb on 2.x authored by
jan kellermann →
Issue #3529998: Fix PHPCS
-
doxigo →
committed 398c55fb on 2.x authored by
jan kellermann →
Thanks guys, merged. It would be nice to have the PHP_CodeSniffer also fixed
- 🇩🇪Germany jan kellermann
@doxigo I wanted to wait until #3525336 is merged so that you don't get any confilcts because of it :) I'll gladly take over. It would be cool if the new version was at the start then!
Automatically closed - issue fixed for 2 weeks with no activity.