undefined - Contrib.social

🇩🇪Germany jan kellermann

I reverted the last commit and changed the first commit to place the close-button at the end of dialog and not footer. You should place your footer now sticky and the close-button should remain top right in the dialog.

Please review and feedback.

📌 | Klaro Consent Management | Missing 'aria-expanded' attribute in 'Customize' button

🇩🇪Germany jan kellermann

Thank you for feedback, rkoller. We have the Klaro! button "Manage consents" which already has the attribute aria-haspopup="dialog". I would also add this attribute to the "customize"-button. I would also add type="button".

I am not able to add any attribute when the consent-dialog is open - because the notice is removed from DOM.

Please feedback and I will start.

🌱 | WEB-T | Future Planning of WEB-T module

🇩🇪Germany jan kellermann

jan kellermann → created an issue.

📌 | AI | AI Translate should be able to use the TranslateText operation type

🇩🇪Germany jan kellermann

As I understood it, the AI-Translate module is supposed to deliver a provider for “translate_text” that works with LLMs and chat.

My impression is that AI-Translate works past “translate_text”. I cannot select the set Deepl provider at any point.

Was this the goal? What is the sense of “translate_text” then? How can I use ai_provider_deepl with AI-Translation module?

💬 | Video Embed AVideo | Core media module

🇩🇪Germany jan kellermann

Because the given project already used this field type.

A solution based on remote video / oembed would be nice either.

🇩🇪Germany jan kellermann

Every Drupal has its own entities. In webt.module you are testing for instanceof ContentEntityBase and that is a good way.

Many modules are creating their own entities. There are config entities also which may need translation.

✨ | WEB-T | Add translation for media entities

🇩🇪Germany jan kellermann

In preparation of this ticket i found this function in src/TranslationManager.php:

  public function getTranslatableFields($entity) {
    switch ($entity->getEntityTypeId()) {
      case 'node':
        return [
          'title'       => ['value'],
          'body'        => ['value', 'summary'],
          'field_image' => ['alt'],
        ];

      case 'comment':
        return [
          'subject'      => ['value'],
          'comment_body' => ['value'],
        ];

      case 'taxonomy_term':
        return ['name' => ['value']];

      default:
        // Type not implemented.
        return [];
    }
  }

You hardcoded the translatable fields. But what to do with all the other fields? And you can not presume that these fields really exists. This should be replaced by a field iterator per entity.

🐛 | WEB-T | TypeError: strlen(): Argument #1 ($string) must be of type string, array given in strlen()

🇩🇪Germany jan kellermann

Thank you for feedback! I changed the MR like suggested.

Some question (a little offtopic):

You hardcode the bundles:
```
$this->checkContentTypeTranslationEnabled(StringType::NODE, [
'article',
'page',
]);
$this->checkContentTypeTranslationEnabled(StringType::COMMENT, ['comment']);
$this->checkContentTypeTranslationEnabled(StringType::TAG, ['tags']);
```
Wouldnt it be better to get all bundles per content type?

🐛 | Klaro Consent Management | Multiple contextual consents do not respect custom description text

🇩🇪Germany jan kellermann

🇩🇪Germany jan kellermann

💬 | Klaro Consent Management | Klaro! dialog do not open when no third party service is active

🇩🇪Germany jan kellermann

Thank your for discussing.

Do you have some additions for the README or documentation?

Else I would like to close this issue.

📌 | Klaro Consent Management | Inconsistencies in the "Close" button markup

🇩🇪Germany jan kellermann

We discussed the close button for some weeks in https://www.drupal.org/project/klaro/issues/3485880 ✨ Make close button X as DeclineAll button for mustConsent: true (needed for Italy) Active
Please have a look. I cannot remember all the problems we discussed.

The behavior to "discard all" is only needed, if no consents are saved (in notice dialog and in consent dialog). The consent dialog has its own close-button - except if option "must consent" is enabled, then Klaro hides its own close button. So we added a close button with "discard all" function for this both cases. In all other cases the close-button is like an "abort"-button.

📌 | Klaro Consent Management | Inconsistencies in the "Close" button markup

🇩🇪Germany jan kellermann

> Not sure what these conditions are meant for, but removing them fixes the problem. In that case, everything works as expected.

The conditions control when the Drupal module has to add its own close button. Else the close button fom Klaro JS is used.

📌 | Klaro Consent Management | Inconsistencies in the "Close" button markup

🐛 | WEB-T | TypeError: strlen(): Argument #1 ($string) must be of type string, array given in strlen()

🇩🇪Germany jan kellermann

The 2nd markup is from Klaro JS.
The 1st markup is provided by Drupal module.

So we cant fix the Klaro JS markup :(

The Klaro JS only shows close button on some situations. You may open an upstream issue on github.

🐛 | WEB-T | TypeError: strlen(): Argument #1 ($string) must be of type string, array given in strlen()

🇩🇪Germany jan kellermann

🇩🇪Germany jan kellermann

jan kellermann → created an issue.

✨ | WEB-T | Add translation for media entities

🇩🇪Germany jan kellermann

jan kellermann → created an issue.

🇩🇪Germany jan kellermann

I created a MR. Please review and feedback.

🇩🇪Germany jan kellermann

jan kellermann → created an issue.

📌 | Klaro Consent Management | Move close button to header

🇩🇪Germany jan kellermann

Works for me. But the order of interactive elements changes!
Maybe move the new element to the end of .cm-modal.cm-klaro'?

@rkoller can you please have a look for a11y?

📌 | German translation | Web-T

🇩🇪Germany jan kellermann

📌 | German translation | Web-T