Account created on 26 September 2008, almost 17 years ago
  • Senior Developer / CTO at werk21 
#

Merge Requests

More

Recent comments

🇩🇪Germany jan kellermann

After 14 days without response moved from https://www.drupal.org/project/html_field_formatter/issues/3535801 📌 Offering to (co)maintain HTML Field Formatter Active

Project: https://www.drupal.org/project/html_field_formatter

🇩🇪Germany jan kellermann

In unserem Integrationssystem meldet er beim Prüfen der Übersetzungen:

PDF using mPDF (3.0.0). Datei weder unter https://ftp.drupal.org/files/translations/all/pdf_using_mpdf/pdf_using_m... noch unter translations://pdf_using_mpdf-3.0.0.de.po gefunden

Magst Du bitte nochmal schauen?

🇩🇪Germany jan kellermann

Version 2.0.0 ist veröffentlicht und ich habe die letzten Strings übersetzt. Bei "toggle state" habe ich nicht wortgenau mit "Geöffnet-Status" übersetzt, da ich "Umschalt-Status" im Deutschen nicht verständlich finde (und es auch technisch präzise, da nur der geöffnet-Status gespeichert wird und beim Schließen der Eintrag im localStorage DSGVO-konform entfernt wird).

🇩🇪Germany jan kellermann

We plan to close this ticket and to discontinue 1.x.

🇩🇪Germany jan kellermann

Here is a ready solution: https://www.drupal.org/project/decorative_image_widget

We would prefer this texts: https://www.drupal.org/project/decorative_image_widget/issues/3468387#co... 💬 Anyway to configure the help text? Active

Here is another solution, but less used and stores information in key/value-store: https://www.drupal.org/project/decorative_images

Additionally you need a hook for a attribute role="presentaion":

/**
 * Implements template_preprocess_image().
 */
function hook_preprocess_image(array &$variables): void {
  if ($variables['attributes']['alt'] == '') {
    $variables['attributes']['role'] = 'presentation';
  }
}
🇩🇪Germany jan kellermann

Thank you all for your work. This issue is merged.

🇩🇪Germany jan kellermann

Added text to admin form and README. Please have a look and give feedback or fix. Thank you in advance.

🇩🇪Germany jan kellermann

Then please have a look and give feedback :)

We added classes for gin but also for general dark mode without gin as admin theme.

🇩🇪Germany jan kellermann

jan kellermann made their first commit to this issue’s fork.

🇩🇪Germany jan kellermann

We'll add that to our list.

But could you please clarify with the module maintainers why external files are being loaded there in the first place? This generally leads to problems and should be avoided. See here :

Using a CDN was historically thought to be beneficial. However, things have changed, and it is in general not a good idea to load libraries from a CDN; avoid this if possible.

🇩🇪Germany jan kellermann

Dank für das unterhaltsame Youtube-Video!

Da kommen noch ein paar neue Strings, die übersetze ich dann noch. Wir sind gerade bim RC1 und lösen noch eine Rückwärts-Kompatibilität und dann können wir hoffentlich endlich releasen :)

https://git.drupalcode.org/project/sticky_local_tasks/-/merge_requests/1...

🇩🇪Germany jan kellermann

Ready incl. phpunit tests.

Please review and feedback.

🇩🇪Germany jan kellermann

Thank you for your proposal. This is a good idea to add a field for ignoring external resources pattern.

A quick workaround should be to add `cdn.ckeditor.com` in `/admin/config/user-interface/klaro/services/cms` => `Advanced` => `Sources`.

🇩🇪Germany jan kellermann

Thank you! That's a very plausible suggestion. Since this changes the way the program works, we would like to make a note of it for version 2.1, which we are currently working on and which will include several other changes.

🇩🇪Germany jan kellermann

Thank you all for coding and feedback!

I merge this issue and look foward to a stable release!

🇩🇪Germany jan kellermann

Ich hab mal einiges vorgeschlagen, wie "Versandtyp" und "Versandmethode" verwendet werden könnte.

🇩🇪Germany jan kellermann

As @anybody asked about it: I am also happy to offer my support.

🇩🇪Germany jan kellermann

@anybody I would be happy to assist you :-)

🇩🇪Germany jan kellermann

@doxigo thank you very mich! I will prepare the release for D11.

🇩🇪Germany jan kellermann

As just a small addition to #3502108 i merged this due to no errors in pipeline.

🇩🇪Germany jan kellermann

I re-opened the issue #3515677 and suggested giving anybody maintainer privileges.

🇩🇪Germany jan kellermann

It would be great to discuss this issue again.

Since march nothing happened. It would be great to have privacy first for this important module js-cookie.

See https://www.drupal.org/project/js_cookie/issues/3390616#comment-16157103 Support local library file Active

🇩🇪Germany jan kellermann

> but as of now the MR has some conflicts due to the recent merges, would be nice if you could check them.

Yes, of course :)

> Also you should become a maintainer since you've been quite active, would that work?

Yes, this would be great! We are using this module actively and we can carry it a little further.

🇩🇪Germany jan kellermann

Thats it. The problem of WPOD after upgrade could not resolved because of missing hooks. I added this in README.

🇩🇪Germany jan kellermann

The purpose of the module is precisely to output HTML. Everything else is provided by Drupal in the core. In this respect, I see no need to solve this via config. But you can indeed mention this in the module description or in the README.

🇩🇪Germany jan kellermann

We added a commit for Drupal Coding Standards and tested manually for D11.

Please merge and release a new version for D11.

If you need support or have little time feel free to add me (temporarily) as co-maintainer.

🇩🇪Germany jan kellermann

@doxigo When you merge #3502108 I will adapt this issue to new JS code.

🇩🇪Germany jan kellermann

The patch is merged to 1.x and 2.x.

In #3502108 we prepared for D11.

Maybe we should just close this issue and continue working on #3502108?

🇩🇪Germany jan kellermann

@doxigo Tests are all green now and we tested manually on D11 incl. PAReview.

It should be D11 ready now!

🇩🇪Germany jan kellermann

jan kellermann changed the visibility of the branch 3502108-path-to-d11 to hidden.

🇩🇪Germany jan kellermann

I created a new issue fork and MR for D11: https://git.drupalcode.org/project/drupal/-/merge_requests/12682

I collected the existing patches and merged them in this issue fork.

I uploaded the patch for your composer-patch as 3326684-42.patch

But this is only the mitigation. As @geek-merlin wrote in #37: behind every warning waits a bug that should have been fixed before.

🇩🇪Germany jan kellermann

Es geht darum, ob es ein Schmuckbild ist oder ein Informationsträger. Und im Kontext von A11y ist Dekoratives Bild einfach der Fachterminus:

  1. https://bitvtest.de/pruefschritt/bitv-20-web/bitv-20-web-9-1-1-1c-leere-...
  2. https://www.lf-barrierefreiheit-st.de/digitales/webseiten/checklisten/bi...

Und "Grafik ohne informative Funktion" klingt auch eigenartig.

🇩🇪Germany jan kellermann

It would be great to get a D11 compatible release.

Can we support?

Thank you in advance.

🇩🇪Germany jan kellermann

Works for me.

Would be happy to get a D11 compatible version soon.

🇩🇪Germany jan kellermann

@joachim: Vielleicht löst sich das Problem mit dem "Decorative" von selbst, ich hab neue Texte vorgeschlagen:

https://www.drupal.org/project/decorative_image_widget/issues/3468387#co... 💬 Anyway to configure the help text? Active

🇩🇪Germany jan kellermann

I like the WAI Decision Tree.

Proposal:

This image is decorative and can be ignored by assistive technologies, such as screen readers. Read more about Decorative Images or use the Decision Tree.

🇩🇪Germany jan kellermann

RC1 ist heute erschienen und das sollten hoffentlich die letzten Übersetzungen für das Release sein:

https://localize.drupal.org/translate/languages/de/translate?project=PDF...

🇩🇪Germany jan kellermann

Shipping Type scheint z.b. "Abholung im Shop" oder "Postversand" zu sein.

Die Methoden beziehen sich dann auf den Typ ("Express-Versand", "Versichertes Paket", ...)

IKEA übersetzt "Shipping Type" z.B. mit "Lieferoptionen".

Aber ich denke eine 1:1 Übersetzung nach "Versandarten" und "Versandmethoden" sollte das Problem lösen. Die Beschreibungen sind ja Problem des Modul-Maintainers von commerce_shipping.

🇩🇪Germany jan kellermann

This issue should be obsolete with #3531134.

🇩🇪Germany jan kellermann

I merged this issue.

Thank you all for testing and feedback.

🇩🇪Germany jan kellermann

Thank you for feedback. I added svg to list of allowed extensions.

🇩🇪Germany jan kellermann

Fixed Patch file for 7.0.5 with re-ordered css lines.

🇩🇪Germany jan kellermann

Patch file for 7.0.5 with re-ordered css lines.

🇩🇪Germany jan kellermann

Thank you all for 5 years from idea to merge!

I merged this issue to 3.x.

🇩🇪Germany jan kellermann

Thank you for reporting and testing!

I merged this MR.

🇩🇪Germany jan kellermann

Thank you all for your work. I merged the code :)

🇩🇪Germany jan kellermann

Thank you for reporting and testing. I merged this MR.

🇩🇪Germany jan kellermann

I fixed the wrong message object and switched to ollama-client because openai seems to handle images in a different way.

Please test and review.

🇩🇪Germany jan kellermann

jan kellermann made their first commit to this issue’s fork.

🇩🇪Germany jan kellermann

I pushed some code to the issue code. Maybe someone will have a look. It os a proof of concept. I will continue work later.

🇩🇪Germany jan kellermann

I just played around to mitigate this issue in ai-module and used base64_encode/decode for generating URL, but then I got error message while saving form: Model ID can only contain letters, numbers, hyphens and underscores.

So I think this module has to sanitize or transliterate model_id.

🇩🇪Germany jan kellermann

@avpaderno Thank you very much! Make more easy to fork and update forks.

@gauravjeet I already sent you a PM and ask again to support me:

Can you please add this to the project description (I hace no access):

New branch 3.x
Version 3.x is the successor to 8.x-2.x and should be compatible if patches #3361245, #3475769, or #3520301 are used.

If you have used any other patches, please check the issue queue. We are working hard to adopt these in 3.x in a way that maintains backward compatibility. Feel free to comment on the issues and give feedback.

And can you please change the maintenance status so that users don't turn away from the project?

If you don't have time right now, please assign the necessary permissions to my user.

Thank you in advance.

Production build 0.71.5 2024