jan kellermann → created an issue. See original summary → .
Thank you very much! We are not using VDB-Provider. We deliver an own Operation type "Ai Search API" to communicate with AnythingLLM Document Storage / Vector Database.
We just added a documentation for using core media with AVideo to the module page: https://www.drupal.org/project/video_embed_avideo →
Maybe we can release a version 2.x later for core media.
Thank you!
Version 2.0.4 works for me with Drupal 10.6.
jan kellermann → made their first commit to this issue’s fork.
Thank you very much! I just inspected the code of video_embed_field and there is also a fragment in style:
src="{{ url }}{% if query is not empty %}?{{ query | url_encode }}{% endif %}{% if fragment is not empty %}#{{ fragment }}{% endif %}"
See https://git.drupalcode.org/project/video_embed_field/-/blob/3.x/template...
Maybe you can just add the fragment also?
jan kellermann → made their first commit to this issue’s fork.
Add new possibilites from version 3.0.8, see issue #3496107
Thank you for your work. I merged the changes for next release.
Klaro is mandatory, so the module works as designed.
It seems that block's behavior has changed so that it is also displayed when NULL is returned (see failed test). It seems that another way to hide the block must be found, and thus the issue #3358576 🐛 Fatal error "TypeError: array_filter(): Argument #1 ($array) must be of type array, null given." Needs review for language_switcher_extended and this core issue are obsolete.
I just updated the core-patch in #3362713 and the test for hiding the block fails. It appears that Block's behavior has changed so that it is also displayed when NULL is returned. It seems that another way to hide the block must be found, and thus this issue and the core issue are obsolete.
If the AI module manages the machine names, the individual calls would not be necessary at all, as AI would take care of everything in the background.
And yes, you're right: a new config entity would certainly be better than the State API. The other issue was only about finding a solution within the existing structure.
It's just like using a machine name, as is done in many places in Drupal. I think the ai module should handle this centrally and the routes etc. should use the machine names.
I added the asserts and enabled PHPUnit in Gitlab CI.
Please review and give feedback.
Yes, I do. Sorry, didnt see. Then we should enable tests in Gitlab CI also.
Yes, but this should solve the problem that gitlab CI cannot find the classes from field_group module.
I added the UI for bulk delete (based on bulk delete in pathauto module).
Please review an/or give feedback.
jan kellermann → made their first commit to this issue’s fork.
The warnings should be fixed after merging composer.json in #3560599
Please review and / or give feedback. Thank you :)
Added documentation in code. Please review and feedback.
Great! Can this issue merged for RC? This would be great.
Great, thank you! I fixed this and merged this MR.
Thank you very much.
I added two terms to cspell and merged.
Thank you! Sometimes we overlook the obvious...
Please review :)
There a several ways to add a videos. You find prepared apps for youtube and matomo and some information in the Readme.md of the module.
If you can give more information here how you implement library and videos, maybe someone can help. In module glighbox only a field formatter for images is included.
We do not need this service or have an key, so please test and complete texts and links.
Thank you for your response and explanations.
Please have a look at klaro_page_attachments:
There is a early return condition:
if (!$helper->hasAccess() || $helper->onDisabledUri() || $helper->onExcludedUri() || !$helper->consentManagementRequired()) {
return;
}
And only of this condition is not met, the klaro-library is added and generates a different cache-key for assets.
This is very similar to the early return condition in klaro_js_alter:
if (!$helper->hasAccess() || $helper->onDisabledUri() || !$helper->getSettings()->get('auto_decorate_js_alter') || !$helper->consentManagementRequired()) {
return;
}
The only difference is $helper->getSettings()->get('auto_decorate_js_alter') - and this is a site-wide setting and does not depend on url, role or user.
Therefore, I assume we do not require an additional file to generate various cache tags for assets.
Unfortunately, I was unable to trigger the error, so I couldn't create a test scenario.
We don't need a placeholder; we may not aggregate these scripts because we are changing the attributes of the source tag. They cannot be aggregated.
Thank you very much. We permanently exclude the javascript files that Klaro handles from preprocessing.
Which cache needs to be cleared when the activated Klaro apps change?
In the moment we add cache-context to every page:
https://git.drupalcode.org/project/klaro/-/blob/3.x/klaro.module?ref_typ...
We could add there an further array of all enabled Klaro-apps. Or do we need to clear a special JS-cache?
I have a question to understand the problem: Klaro blocks the loading of external scripts. Only with consensus are the external scripts loaded. Why is an init code needed if the external scripts are not even loaded at this point?
Maybe we could simple use a part (or a hash) of $settings['hash_salt']? This should be unique per Drupal instance.
Thank you very much, @unqunq, but the MR was into 1.1.x.
I adadpted the MR for 1.2.x. Because of this I set the status to "Needs review" again.
Adapted code for 2.x and removed workaround.
Before patch:
redis-cli KEYS *update_fetch_tasks:counter
1) "drupal:queue:update_fetch_tasks:counter"
After patch with $settings['cache_prefix'] = 'some_id_';:
redis-cli KEYS *update_fetch_tasks:counter
1) "some_id_:drupal:queue:update_fetch_tasks:counter"
After patch without $settings['cache_prefix']:
redis-cli KEYS *update_fetch_tasks:counter
1) "drupal.redis.11.2.4..ef4fb228e416685697f2d1c82950814ef2334d09cf018a577084dc04a63db568:drupal:queue:update_fetch_tasks:counter"
I am not sure if prefix with version is a good idea for Queue.
Eigenartig. Aber anscheinend war das ein maschineller Vorgang (wahrscheinlich im Rahmen des Security Shields), denn die Änderung ist von anonymous: https://www.drupal.org/node/1819680/revisions →
Danke fürs Kümmern!
We hit this bug in 10.4 - probably as a consequence of https://www.drupal.org/node/3374955 →
This breaks the admin areas for multilingual sites with system-default in EN but editors working in other languages. So I increased the prio.
I added the warning to README and project page.
Because of no further response since 6 weeks I merged and closed this issue.
Merged small fixes.
jan kellermann → changed the visibility of the branch 3542872-fix-gitlab-ci-pipeline to active.
jan kellermann → changed the visibility of the branch 3542872-fix-gitlab-ci-pipeline to hidden.
jan kellermann → created an issue.
MR is merged to 3.x branch.
Thank you for quick response!
I changed the code for new 3.x branch. It works (and produces pipeline errors which will be fixed in new issues).
Thank you for your work.
@avpaderno Thank you very much! Can you please change the default branch for this project to 3.x? I dont have the permissions for this.
I merged this to new 3.x branch. Thank you very much.
I have got no response but am still interested to (co)maintain.
I suggest tagging this as 3.1.0. Then the Klaro 3.0.x versions should not pull it (constraint: `drupal/klaro_js: ~3.0.0`).
We are planning the 3.1.x Klaro version with some new features, so we have time to test it.
RTBC and please merge an release version.