Currently, the disabling check is performed on the entire URI, including the query string. However, in some cases, this can lead to unintended behavior.
In my case, the situation is as follows:
\/admin\/, but only in the section "Disable Klaro! element and don't block attributed resources on following URL patterns."
When I edit a storage by clicking the button in the overview, the page opens including the destination parameter.
/it/storage/18759/edit?destination=/en/admin/content/storage%3Fname%3D%26type%3Dstorage_multimedia%26status%3DAll%26langcode%3Dit
In this case, when I try to open the media library, the AJAX commands to open the modal are correctly triggered, but the element with the ID #drupal-modal is not present on the page, so the media library does not appear.
The missing element should be added to the HTML via drupal.dialog.ajax, but for some reason, this script is not present when the page loads.
There is probably an issue with the ordering of the JavaScript files being aggregated somewhere else, but I haven't been able to identify the exact cause.
From what I've observed, the pattern used in Klaro is matched against the destination in the query string, and as a result, the script is excluded. However, during aggregation, other JavaScript files are also removed — including the one responsible for creating the #drupal-modal element.
I can fix this by modifying the pattern, but since the site is multilingual, I would need to use a pattern similar to this:
^\/admin\/
^\/it\/admin\/
^\/en\/admin\/
^\/fr\/admin\/
...
^\/es\/admin\/
Is the search in the URI instead of just the path intentional?
Otherwise, it might be possible to modify the methods KlaroHelper::onDisabledUri() and KlaroHelper::onExcludedUri() by replacing:
$uri = $this->request->getRequestUri();
with
$uri = $this->request->getPathInfo();
Active
3.0
Code
Thank you! That's a very plausible suggestion. Since this changes the way the program works, we would like to make a note of it for version 2.1, which we are currently working on and which will include several other changes.