- ๐ซ๐ฎFinland jviitamaki
If return statement in latest patch causes NS_BINDING_ABORTED breaking referencing of existing entities in versions >2.6.
- ๐ซ๐ฎFinland jviitamaki
This seems to be working working better for what ever reason.
- ๐บ๐ธUnited States luke.leber Pennsylvania
#9 seems to work wonderfully against E.B. 2.9.0 and Drupal 9.4.x.
Wrapping things in this pseudo-code seems to be an elegant solution, but I do think that using
drupal/once
would be more elegant. IMO it would be worth merging this bug fix in as-is and opening a follow-up task to refactor things to drop jquery / usedrupal/once
.TL;DR - +1 RTBC
- ๐ญ๐บHungary peter_serfozo
If the focus is on another field (for example a text field) before opening the entity browser modal & closing it by submitting its form, the page is scrolled to the previously focused page element. To prevent it, we can add
.focus()
before triggering the.click()
. - Status changed to RTBC
12 months ago 7:02am 3 September 2024 - ๐ฉ๐ชGermany jan kellermann
jan kellermann โ made their first commit to this issueโs fork.
- Merge request !62#2857339: Fix Modal auto-open conflicts with AJAX. โ (Merged) created by jan kellermann
- ๐ฉ๐ชGermany Anybody Porta Westfalica
@jan kellermann thanks for the MR - would you confirm RTBC? Then I'd merge it.
-
anybody โ
committed 3e001a0a on 8.x-2.x authored by
jan kellermann โ
Issue #2857339 by jan kellermann, ckaotik: Modal auto-open conflicts...
-
anybody โ
committed 3e001a0a on 8.x-2.x authored by
jan kellermann โ
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Okay let's merge this and create a follow-up to use
core/once
here in the future.