- Issue created by @SirClickALot
Yes, I just haven't gotten to it yet, sorry. Could you maybe provide a MR? if not I'll check soon
- 🇬🇧United Kingdom SirClickALot Somerset
Hi @doxigo → ,
Thank you for coming back to me on this.
I'm afraid I'm not backend savvy enough to produce an MR so I'll have to wait for your magic to kick in.
I have tried many other 'floating' TABS modules and none of them come close to yours. In fact most of don't even seem work very robustly at all.
Now that I know your intentions, I have also raised another issue 💬 Trouble theming some menu items. Active relating to theming other menu items — this is something that has been driving us mad for ages so I thought now was the time to raise it.
Thanks again, great work.
- 🇳🇴Norway jonsimonsen
Hi @doxigo,
Thank you for coming back to me on this.
I'm afraid I'm not backend savvy enough to produce an MR so I'll have to wait for your magic to kick in.
Hi @sirclickalot. I just wanted to let you know that I tested the suggested D11 patch for version 2 of the module, and it worked fine on my site. I believe that version 1 will not be made D11 compatible. The patch was merged into the dev branch for version 2 today
- 🇬🇧United Kingdom SirClickALot Somerset
Thanks @jonsimonsen → ,
We will wait to see the next release and give the 2.x a go when the time comes that it is designated as D11 compliant.
Still fumbling about with theming as described in another issue 💬 Trouble theming some menu items. Active but we're adamant that this module is the one we want to go with moving forward so we'll sit tight and see what happens.
Hey guys 👋
I have a long todo list to add to this module but unfortunately, don't have a lot of free time, I'll see if I can open up sometime if possible.
- 🇩🇪Germany jan kellermann
It would be great to get a D11 compatible release.
Can we support?
Thank you in advance.
Hey Jan, yes please do support with a MR, ideally against the 2.x
- 🇩🇪Germany jan kellermann
jan kellermann → changed the visibility of the branch 3502108-path-to-d11 to hidden.
- 🇩🇪Germany jan kellermann
@doxigo Tests are all green now and we tested manually on D11 incl. PAReview.
It should be D11 ready now!
-
doxigo →
committed c5bdc138 on 2.x authored by
jan kellermann →
Issue #3502108: Path to D11
-
doxigo →
committed c5bdc138 on 2.x authored by
jan kellermann →
- 🇮🇳India gaurav.kapoor
We can also get rid of the PHP parameter in the .info.yml file as the minimum supported version → by Drupal 11 is 8.3.
Automatically closed - issue fixed for 2 weeks with no activity.