Account created on 22 September 2016, over 8 years ago
  • Drupal Developer at werk21ย  โ€ฆ
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Great work. This can be taken up once major changes from https://www.drupal.org/project/antibot/issues/3406484 ๐Ÿ› Antibot blocks multistep webform submission if user fails to move mouse pointer Active are finalised and pushed.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

gaurav.kapoor โ†’ changed the visibility of the branch 3406484-antibot-blocks-multistep to hidden.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

@glugmeister @itmaybejj Thanks for using Antibot and working on this issue. Are you still able to reproduce the issue with the latest 2.0.4 release? I created a multi-step web form, followed the steps mentioned in the issue and then used Apple voiceover to make submission and it was not blocked by Antibot. Possible to share any other inputs that might help others reproduce the issue? Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

@jan.kellermann, I copied the embed from https://social.bund.de/@Umweltbundesamt/113662513183074352 by clicking the option "Get embed code" from the extra options under a post. The post loads without Klaro but doesn't load with Klaro enabled and user allowing external content.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Tested the patch by adding Bluesky and Mastodon embeds to a Drupal website and noticed the following:

  1. The required "data-name" attribute gets added to the embedded data by JS.
  2. External content is blocked as well if the respective Klaro app has been marked enabled.
  3. The bluesky embed gets blocked by Klaro and shown only if user allows
  4. The issue is in the case of a Mastodon post, the post loads fine if the Klaro app is disabled for it but does not load completely when the Klaro app is enabled for it (Check screenshot). This could be an issue with Klaro JS or even Mastodon embed.

Overall, the required attributes get added and external content is only shown after user consent.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Tested with video embed field, the required attributes get added along with an external video link. Also, getting the Klaro links that confirm if user wants to load content from an external link.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

The added logic for handling video_embed_field isn't working at the moment and would require a bit of changes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

I had to remove the variable type 'array' from $fieldOptions temporarily to make it work. Clearing cache didn't work for me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Getting the same issue with the Mistral AI provider. No error in the browser console or Drupal logs. The response from Mistral does get logged in the logs provided by the AI logging module.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Added the provided description. Thanks for writing it and adding this issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Patch pushed. Tested on D11, documentation generation and PDF download works.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Thanks for working on this. Tested in local, merged with 2.0.x, and new tag 2.0.4 added as well.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

+1 to this feature request. Any easy way to implement it for the time being?

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Do we have any fix for this or any configuration related changes that can suppress this issue?

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

In one of the websites, we are using smart trim and wrapping the generated summary around a link (linked to the respective node). Special characters such as german umaluts 'รค, รถ, รผ and รŸ' are then not showing up in the generated trimmed text. Patch from #3 resolved the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

TYSM @danrod. I have granted you maintainer access for the module.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

@ericgsmith Thanks for the support request. I have added you as a maintainer with all the required accesses.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

#53 would require some changes as it isn't removing these 2 lines and the radio buttons disappear as their type gets changed to 'value'.

-      $form['user_role']['negate']['#type'] = 'value';
-      $form['user_role']['negate']['#value'] = $form['user_role']['negate']['#default_value'];

Also, the saved value of user role negation isn't reflected in the UI after saving the block. Should we make this change as well:

-      $form['user_role']['negate']['#default_value'] = (int) $form['request_path']['negate']['#default_value'];
+     $form['user_role']['negate']['#default_value'] = (int) $form['user_role']['negate']['#default_value'];

Thoughts?

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Thanks @jan.kellerman for spotting and fixing this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

Pushed and added a new release. Thanks for working on this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

The changes done right now are good enough for moving forward. We will keep on modifying the methods once we start working on the migration or data sync logic. Thanks for working on this.

๐Ÿ‡ฎ๐Ÿ‡ณIndia gaurav.kapoor

I have worked a little bit on this much. Did changes at some places and also added @deprecated notice wherever. This patch is only useful once parent issue is fixed. Looking for a good review on this one.
Thanks in advance.

Production build 0.71.5 2024