Deprecate ThemeHandlerInterface::rebuildThemeData() and use extension.list.theme service instead

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule → and the Allowed changes during the Drupal 8 release cycle → .

I have worked a little bit on this much. Did changes at some places and also added @deprecated notice wherever. This patch is only useful once parent issue is fixed. Looking for a good review on this one.
Thanks in advance.

Here's a start. Still need to sort out the ThemeInstaller. Ideally we wouldn't need the ThemeHandler there. But then we'd need to sort out issues with reseting the list in ThemeHandler.

+++ b/core/tests/Drupal/Tests/Core/Extension/ThemeHandlerTest.php
@@ -72,6 +72,8 @@ protected function setUp() {
+   * @group legacy
+   * @expectedDeprecation \Drupal\Core\Extension\ThemeHandlerInterface::rebuildThemeData() is deprecated in Drupal 8.7.0 and will be removed before Drupal 9.0.0. Use \Drupal::service('extension.list.theme')->reset()->getList() instead. See https://www.drupal.org/node/2709919.

Maybe better to create common ThemeHandlerLegacyTest - it will be easy to remove it in 9.0
I'm Adding it in #3017231-4: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage →

Drupal 9.5.0-beta2 → and Drupal 10.0.0-beta2 → were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.4.0-alpha1 → was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.3.0-rc1 → was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.2.0-alpha1 → will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

Drupal 9.1.0-alpha1 → will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule → and the Allowed changes during the Drupal 9 release cycle → .

Drupal 8.9.0-beta1 → was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule → and the Allowed changes during the Drupal 8 and 9 release cycles → .

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule → and the Allowed changes during the Drupal 8 and 9 release cycles → .

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule → and the Allowed changes during the Drupal 8 release cycle → .

Moved install/uninstall patch to found #2776031-21: Properly deprecate ThemeHandlerInterface install() and uninstall() also replace usage →

PS: issues related because also manages how extensions lists are rebuilded/populated

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened → , as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule → and the Allowed changes during the Drupal core release cycle → .

The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

To answer a question posted in Slack, this needs a separate change record. A change record is for documenting the first version and branch where the change was introduced. When you want to add related issues that can be done in the issue links fields or even in the description body.

For this issue, the changes to the existing change record should move to a new change record. And the new change record can refer to the older one.

I do know the existing change record does not follow what I describe above and it is on my list to update that.

Updated tasks in IS

Left some small comments.

Feedback appears to be addressed.

Committed/pushed to 11.x and cherry-picked to 10.3.x, thanks!

Published CRs:

• https://www.drupal.org/node/3413308 →
• https://www.drupal.org/node/3413196 →

catch → closed merge request !5846

Thank you! the last bit is 📌 Deprecate ThemeHandlerInterface::getBaseThemes and remove usages from core Needs work

Automatically closed - issue fixed for 2 weeks with no activity.