vensires → credited dimitriskr → .
I'm also getting a similar error, but on a different occasion, for example when a (malicious) request goes to /contact/Perú
I'll try to reproduce it on a clean install and upload a failing test
Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[HY000]: General error: 1267 Illegal mix of collations (ascii_general_ci,IMPLICIT) and (utf8mb4_general_ci,COERCIBLE) for operation '=': SELECT "name", "data" FROM "config" WHERE "collection" = :collection AND "name" IN ( :names__0 ); Array ( [:collection] => [:names__0] => contact.form.Perú ) in Drupal\Core\Config\DatabaseStorage->readMultiple() (line 111 of web/core/lib/Drupal/Core/Config/DatabaseStorage.php).
vensires → credited dimitriskr → .
@anybody there's some work going on in 3160987
I agree creating a formatters/tabs.css to fix this on vertical tabs too. You can use the branch I'm working on, no need to have multiple branches and MRs
As for interfering with other themes, only testing can prove that. I see in tag, data-once="" has a claroDetails, so we could limit it like this. Again, I am not familiar with front-end stuff in Drupal, so I'm just throwing random ideas :D Adding a related issue I saw about this
I've identified the issue (or hacked the module into making this work?) I have no good knowledge of CSS but the point is something is missing in the module's CSS files. I compared it with claro's form.css component and copy-pasted the CSS. I guess it needs tests on several other admin themes (gin etc) but I believe we now know what's going on.
Work is done on MR 108
I'm also uploading screenshots of before-after on my project
dimitriskr → made their first commit to this issue’s fork.
dimitriskr → changed the visibility of the branch 4.x to hidden.
dimitriskr → made their first commit to this issue’s fork.
dimitriskr → created an issue.
Add the details of
https://www.drupal.org/node/150220 →
as small comment, as that page is deleted
Archive
@john franklin, what about a modal? Do you think that's better?
I have some comments regarding the changes and then we can proceed
dimitriskr → made their first commit to this issue’s fork.
dimitriskr → created an issue.
I'll check how is it possible to use directly phpseclib/phpseclib and keep these encryption methods too
Other recommendations welcome
Thanks @gambry!
Do you have any ideas/thoughts for this module? My purpose is to replace the deprecated library, add some automated testing and make it D11 compatible
dimitriskr → created an issue.
Hi @maintainers
What's the status for maintainership? Are you OK with adding a co-maintainer to update this module for D10/11?
I want to use it in a project and can offer some time to update it
This replaces deprecated drupal_get_path() on ckeditor_find.install module with \Drupal::service('extension.path.resolver')->getPath() and that should make the module completely compatible with D10
dimitriskr → created an issue.
Updating patch to remove core: 8.x from .info.yml
Uploading the same patch for latest HEAD (1.0.0-rc9)
restored IS
My complete list
PHP 8.1.31
Dcore 9.5.11
views_data_export 1.5.0
views_data_export_phpspreadsheet 2.0.5
symfony/serializer v4.4.47 (part of it is \Symfony\Component\Serializer\Encoder\EncoderInterface)
phpoffice/phpspreadsheet 3.8.0
Reverting to v1.x, especially to 1.6.0 you released today, the error goes away, since the signature has now mixed $format instead of string $format in v2, where string $format gets us this error.
So, it's still OK for v1 but if anyone in D9 upgrades to v2(2.0.5), they will probably get that error
I have it updated. It's in 3.8.0
Currently version 2.0.5 supports D9 per the module's homepage and the bug is valid.
You could probably create a new release that fixes this specific error and then another one that removes D9 support.
But of course that's up to you, as a maintainer.
dimitriskr → created an issue.
Setting priority back to Major per #10
vensires → credited dimitriskr → .
dimitriskr → changed the visibility of the branch 3476166-deprecate-rolestorage to hidden.
dimitriskr → made their first commit to this issue’s fork.
dimitriskr → changed the visibility of the branch 11.x to hidden.
dimitriskr → made their first commit to this issue’s fork.
Added the constructor property promotion.
About the constructor docs, I cannot remove them because PHPCS will complain and tests will fail. Do I need to add a phpcs bypass for this to work?
@larowlan BC layer exists, it's crossed out because it is already done
Is it browser-agnostic? We have the same, but only on Chrome, Firefox works fine
Yes exactly
It becomes null because the argument starts with an invalid character and since the "Use multiple values" option is enabled, it tries to filter it for "+"(OR) and ","(AND) characters, anything else is invalid.
I think we need to re-evaluate the scope of the issue, per #57 comment, to filter out invalid characters in arguments (as an option in UI maybe, to cover all use-cases), and keep this feature disabled, in order not to break anything during updates. If this option is disabled, we show an error to the user, as is the current proposed resolution, and if it's enabled, no harm done
vensires → credited dimitriskr → .
system.install already checks for tokenizer extension here
@patelh84 can you upload an interdiff from #12? Thank you
dimitriskr → made their first commit to this issue’s fork.
bumping this
dimitriskr → created an issue.
OK. but this patch just hides the error, not solving the actual issue. The problem originates from the fact that an argument in your view is invalid
@pcambra did you maybe forget to push to the issue branch? Otherwise there's nothing to review
dimitriskr → created an issue.
Can someone close the MR?
No format_string() found in core
Wim Leers → credited dimitriskr → .
You can override the target_db_type and version variables
automatic_updates did this here and haven't heard any complaints for almost 2 weeks. That will use MariaDB 10.6 in your tests
The differences in my.cnf is that
#3401846: Add supported mariadb container images →
has extra transaction_isolation = READ-COMMITTED and innodb_thread_concurrency = 0, while the committed my.cnf only has innodb_use_native_aio = 0
I ran again the jobs and got the same error as before
Original phpunit error: https://git.drupalcode.org/issue/drupal-2015121/-/jobs/817769
Latest phpunit error: https://git.drupalcode.org/issue/drupal-2015121/-/jobs/918319
I re-ran the job and it passed. Upon checking the browser output, I noticed it throwed different exception for the same reason. Is it something in the mysql driver?
Failing:
PDOException: SQLSTATE[HY000] [1698] Access denied for user 'cij44wcj6ozuljp5'@'127.0.0.1' in Drupal\Component\DependencyInjection\PhpArrayContainer->createService() (line 79 of /builds/issue/drupal-2015121/core/lib/Drupal/Component/DependencyInjection/PhpArrayContainer.php).
Drupal\Component\DependencyInjection\PhpArrayContainer->createService(Array, 'database') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('database', 1) (Line: 219)
Drupal\Component\DependencyInjection\PhpArrayContainer->resolveServicesAndParameters(Array) (Line: 62)
Drupal\Component\DependencyInjection\PhpArrayContainer->createService(Array, 'cache.container') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('cache.container') (Line: 574)
Drupal\Core\DrupalKernel->getCachedContainerDefinition() (Line: 960)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 514)
Drupal\Core\DrupalKernel->boot() (Line: 734)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)Passing:
Drupal\Core\Database\DatabaseAccessDeniedException: SQLSTATE[HY000] [1045] Access denied for user 'w7oihw6z5qupbfy5'@'127.0.0.1' (using password: YES) in Drupal\mysql\Driver\Database\mysql\Connection::open() (line 207 of /builds/issue/drupal-2015121/core/modules/mysql/src/Driver/Database/mysql/Connection.php).
Drupal\mysql\Driver\Database\mysql\Connection::open(Array) (Line: 460)
Drupal\Core\Database\Database::openConnection('default', 'default') (Line: 191)
Drupal\Core\Database\Database::getConnection('default')
call_user_func_array('Drupal\Core\Database\Database::getConnection', Array) (Line: 79)
Drupal\Component\DependencyInjection\PhpArrayContainer->createService(Array, 'database') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('database', 1) (Line: 219)
Drupal\Component\DependencyInjection\PhpArrayContainer->resolveServicesAndParameters(Array) (Line: 62)
Drupal\Component\DependencyInjection\PhpArrayContainer->createService(Array, 'cache.container') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('cache.container') (Line: 574)
Drupal\Core\DrupalKernel->getCachedContainerDefinition() (Line: 960)
Drupal\Core\DrupalKernel->initializeContainer() (Line: 514)
Drupal\Core\DrupalKernel->boot() (Line: 734)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)RestExport plugin is updated because it extends PathPluginBase, which itself extends DisplayPluginBase
I'm moving the work to https://git.drupalcode.org/project/drupal/-/merge_requests/6774. The other MRs can be closed
dimitriskr → changed the visibility of the branch 10.1.x to hidden.
dimitriskr → changed the visibility of the branch 11.x to hidden.
I came up with this error today. In my project, we're calling views programmatically and some contextual filters started with a comma ",". In 9.5.x this was no problem, but we upgraded to 10.2 few days ago and got this. I first tried to re-save the view but didn't have any changes in the config.
I think we need to add a check that if is_null($break->operator), it means the filter values used to call the view are invalid and return that error to the user
Also, for the actual problem, if the property 'break_phrase' of the 'nid' argument is set to 'true', it will produce this error when using invalid arguments. The 'break_phrase' argument in the UI is "Allow multiple values" in "More" when editing a contextual filter
I'm uploading a test patch that reproduces this error
Tests now pass :)
I've pushed some code changes.
There needs to be a change at \Drupal\Tests\ckeditor5\FunctionalJavascript\CKEditor5TestBase::createNewTextFormat in order to grant the required permission to the current user to allow using each text format. I guess that will make CKEditor5 tests pass and the whole pipeline go green
#62 📌 Deprecate the 'roles' property of text formats Needs review Do we still need this?
Sure, I can give it a go!
Could you also update the remaining tasks in IS?