Form Required Class Missing from Claro

The patch was applied and works fine.

Steps followed.
1 - Install field group
2 - Go to any content type manage form display
3 - Click on Add field group and select Tabs item and select horizontal or vertical tabs.
4 - Click again on Add field group and add one tab for each tab you want.
5 - Drag the specific fields to the respective tab created.
6 - Put all tabs inside the tabs container
7 - For each tab item on the widget select choose the tab widget
8 - To test the opposite orientation of the tabs go to manage form display. Click on the cogs icon on the tabs container item, and change the direction to vertical or horizontal value.

Screenshots are attached for evidence.
Note, the last tab doesn't have the required fields and the * does not appear as expected.

It seems like the solution is using CSS classes that don't exist in core, and are used by contrib modules instead. We usually don't write CSS in the core themes to explicitly accommodate contrib modules. The solution should either be generic enough for it to not include CSS classes not used by core, or it should be moved to the contrib module queue.

Vertical tabs appear to be valid in claro but horizontal tabs are not so those would need to be replaced.

Tagging for novice as it should be easy to find the replacement.

Also this could use an issue summary update with more recent screenshots of before/after.

I am looking into it

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because @smustgrave's comment still applies.

Hello, I am at Mentored Contribution DrupalCon Portland2024, I will be working on it during the next hour or two.

Hi, I am at the mentor contribution at Drupalcon24 Portland. I will be working on this one for the next couple of hours.

Hi I'm novice at DrupalCon Portland2024, I'm part of table looking into this one for next hour.

Working on this at DrupalCon 2024 for the next hour

Hi there, working on this at DrupalCon 2024 for the next hour or so.

Hi I'm novice at DrupalCon Portland2024, I'm part of table looking into this one for next hour.

Hello!
Portland DrupalCon 2024 – working on this for the next 2-ish hours.

Verified * marking tab groups that contain mandatory fields is missing form tab Field Groups when using Claro admin theme at Contribution Workshop at DrupalCon Portland 2024.

Commenting that I helped a mentored contribution table look into this issue. We were able to confirm the issue and we looked at the patches. Unfortunately this was happening later in the day and I think we all ran out of gas at the end. I'll review this in a few days if no one else from the group does and try to get it to RTBC so we might get some core credit for everyone's efforts.

checked with "drupal/field_group": "3.x-dev@dev" with 11.0-dev

before vertical fix

After vertical fix:

After horizontal fix :

Fixed with this patch claro_field_group_required_patch.diff →

#34 is not valid fix for cor -- it's adding a new entry to claro.info.yml.

Additionally, as @lauriii alluded to in #13, it's usually contrib's responsibility to work nicely with core themes, rather than the other way around. So, I'm moving this to the Field Group queue.

Thanks everyone!

The group is working on this issue at Drupalcon Barcelona 2024

I tried the patch with D9.5.11. Patch applies but does not work.

Also, as mention above, this is more likely an issue for FG module than for core (unless there is a reason core is blocking this fromworking; but there wouldnt be anything in the fix that would have "field_group" in it.

I was facing this issue and patch #10 solved it.
This issue seems related to another one: https://www.drupal.org/project/drupal/issues/3171835 🐛 Field Groups marked as required are missing red asterisk Needs work
I'm adding to the Relationships to help users found this solution.