I fixed the conflicts on MR13.
Can someone retest please?
@saurav-drupal-dev, you must remove the permission to create/edit terms and add the view overview,
See the permissions here for content editor:
Evidence that the layout is broken for the user with content editor role:
I was facing this issue and patch #10 solved it.
This issue seems related to another one:
https://www.drupal.org/project/drupal/issues/3171835
🐛
Field Groups marked as required are missing red asterisk
Needs work
I'm adding to the Relationships to help users found this solution.
I've tried applying patch #99 - 3171835-98-horizontal-tab.patch and it did not solve the issue for me.
I have a required field in a fieldset that is on a horizontal tab:
I'm facing this issue. I installed moderation_dashboard module that comes with some views installed. I tried updating one of the views to list only "Blog" content type, however I cannot find the Type filter.
carolpettirossi → created an issue.
Since the options can be confusing, I updated the help text to support the CMS user.
Thanks for updating the MR @joaopauloc.dev. I think it makes sense to make the Total Number os Spaces required only if the Wailist has been enabled.
carolpettirossi → created an issue.
This is the library.discovery on D11:
library.discovery:
class: Drupal\Core\Asset\LibraryDiscoveryCollector
arguments: ['@cache.discovery', '@lock', '@library.discovery.parser', '@theme.manager']
tags:
- { name: needs_destruction }
This is the library.discovery on D10.4:
library.discovery:
class: Drupal\Core\Asset\LibraryDiscovery
arguments: ['@library.discovery.collector']
Drupal\Core\Asset\LibraryDiscoveryInterface: '@library.discovery'
library.discovery.collector:
class: Drupal\Core\Asset\LibraryDiscoveryCollector
arguments: ['@cache.discovery', '@lock', '@library.discovery.parser', '@theme.manager']
tags:
- { name: needs_destruction }
I'm still getting errors on a existing site on version 2.2.0
TypeError: Drupal\lang_dropdown\Plugin\Block\LanguageDropdownBlock::__construct(): Argument #7 ($library_discovery_collector) must be of type Drupal\Core\Asset\LibraryDiscoveryCollector, Drupal\Core\Asset\LibraryDiscovery given, called in /var/www/web/modules/contrib/lang_dropdown/src/Plugin/Block/LanguageDropdownBlock.php on line 115 in Drupal\lang_dropdown\Plugin\Block\LanguageDropdownBlock->__construct() (line 101 of modules/contrib/lang_dropdown/src/Plugin/Block/LanguageDropdownBlock.php).
Actually, the message is thrown even if the user sets the end time.
So, I'm updating the Category and Title of this issue.
To reproduce the issue you have to have this config:
I'm trying to make the Scheduler work with Event Series and Event Instances.
Unfortunately, the patch didn't work perfectly.
With the original code from the MR, I had to force execution of the following code:
$scheduler_manager = \Drupal::service('scheduler.manager');
if ($result = $scheduler_manager->entityUpdate()) {
return t('Added Scheduler date fields to the following entity types: %updated.', [
'%updated' => implode(', ', $result),
]);
} else {
return t('No database fields had to be added.');
}
Even after that, when I published the Event Series using workflows, meaning that I moved to "Published" state in the workflow, the Event Series was not published as expected since the Publish On was in the future. However, all event instances were published.
In my use case (and I image that this is the most common use case):
- The event instances must inherit the Publish On and Unpublish On configuration by default and be published only when the Event Series is published.
To achieve the above:
- I extended the Scheduler to also be available on the EventInstance entity type. (added to the MR)
- I added a hook_update to execute the code I sent above (added to the MR)
- I created field inheritance with "Inherit" configuration for the "Publish On" and "Unpublish On" fields. (not yet added to the MR, if you need this, you need to do manually)
Note:
For some reason, I couldn't use the fallback approach in the field inheritance. It would be preferable for me, but I don't know where I should look and investigate why the fallback doesn't list the Publish On/Unpublish On fields in the Destination field.
MR13 works for me. I can run drush updb successfully now.
Thanks everyone.
carolpettirossi → made their first commit to this issue’s fork.
Additionally with patch #20, it doesn't seem that I can leave the capacity field blank anymore
I'm still seeing the old help text:
mradcliffe → credited carolpettirossi → .
carolpettirossi → created an issue.
I'm using the MR code along with an Aggregate Fulltext field successfully
Thank you so much for contributing =D
I'd like to share a feedback more from a user perspective. I'm not reporting bugs.
I know carousels in banners are no longer used frequently. However, they have been used for a LONG time. Because of this "expectation" of a carousel in the banner, the dots gave me the impression that I could change to a different slide.
carolpettirossi → created an issue.
Hey everyone, here's my suggestion to address joaopauloc.dev concerns:
- Create a new config field in the Event series called "Waitlist promotion" with the following options:
- Automatic promotion as soon as possible.
Help Text: Whenever a seat becomes available, the system will go through the entire waitlist and promote the next user who requested a seat to the registrants list. - Automatic promotion based on requested seat count.
Help text: When a seat becomes available, the system will check how many seats the first person in the waitlist requested. If they requested more than one seat, promotion will only occur once enough seats are available to fulfill their request. - Automatic promotion disabled.
Help text: Automatic promotion will be disabled. The CMS user will be responsible for manually promoting users from the waitlist to the registrants list.
- Automatic promotion as soon as possible.
- For the last 2 options, we should keep the registration form enabled but ensure that the users go to the waitlist, meaning that the registrants list is "locked".
I'm getting this error on the Login, too.
In my case, I have recaptcha keys installed to be used in webforms. I haven't enabled it on "all forms" and it shouldn't be enabled on login form
I'm getting this error on login form on an environment that has not been added to the key (tugboatqa environment). However, I don't know why it's triggering it on login form as I haven't enabled on all forms.
I can confirm the patch is working as expected.
Before patch:
After patch:
This also happens when I try to create a new Block Type via Layout Builder.
I imagine the code introduced by 3436816 should not be executed on AddBlockForm. Not sure.
carolpettirossi → created an issue.
We upgraded from 1.7 to 1.9 and this bug happened. Should we use the MR? I'm confused since jurgenhaas says it's not required on 1.9
I've tested MR#470, and I see the issue with the Header/Title of the page on Paragraph Library page (/admin/content/paragraphs/add/default
) when using the submodule paragraphs_library
Thanks for the patch @daletrexel. It helped me achieve what I needed on my project.
The scenario is:
1. The user access the node itself and not the group content URL, so, in this case, the Group is not in the URL
2. I need to add a Related Items section with content from the same group
It would be great to have the maintainer reviewing this patch. I'll move to Needs Review.
pameeela → credited carolpettirossi → .
That's correct @igorgoncalves. I updated the status on the project page. Thanks for the suggestion
carolpettirossi → created an issue.
I'm facing this issue, too. I have the InfoBubble and InfoWindow flagged in the Format settings, but when the user clicks on the marker, nothing happens.
I tried keeping only bubbles or only info, but the same thing happened.
When I downgrade to 3.13 it works.
@pfrenssen,
What I'm going to recommend to the admin is to update the author to Anonymous.
carolpettirossi → made their first commit to this issue’s fork.
Actually, I realized that the UUID url is generated according to the author. We would need to set the author of the registrant as anonymous, correct?
carolpettirossi → created an issue.
carolpettirossi → created an issue.
carolpettirossi → created an issue.
Hi @azhardotcoder,
Thanks for your response. Not sure I'm following, though.
When I access /admin/config/regional/gtranslate I only see predefined Languages with checkboxes and I don't see the custom language I created in Drupal.
It looks like the error started because the service got update to shared:false
here:
https://www.drupal.org/project/recurring_events/issues/3452632
🐛
Registration creation service leaks data
Fixed
carolpettirossi → created an issue.
Patch #22 stopped working for me. I'm now getting "Warning: Attempt to read property "recurring_events_guests_per_registrant" on null in Drupal\recurring_events_guests\Service\GuestService->getGuestsPerRegistrant() (line 111 of modules/contrib/recurring_events/modules/recurring_events_registration/modules/recurring_events_guests/src/Service/GuestService.php)."
I was facing this issue with Drupal 10.3.1. The MR solved the problem. Thanks a lot!
carolpettirossi → created an issue.
carolpettirossi → made their first commit to this issue’s fork.
carolpettirossi → created an issue.
I realized I was facing this issue because of the Reusable Block patch I applied related to https://www.drupal.org/project/drupal/issues/2999491 ✨ Add reusable option to inline block creation Needs review .
Here's a patch to fix this issue when using Layout Builder Styles along with the Reusable Block patch.
The patch did not solve the issue for me. After I applied patch #6, I get a new error:
Error: Call to a member function getSection() on null in Drupal\layout_builder\Form\ConfigureBlockFormBase->getCurrentSection() (line 343 of /var/www/web/core/modules/layout_builder/src/Form/ConfigureBlockFormBase.php).
Backtrace:
#0 /var/www/web/core/modules/layout_builder/src/Form/ConfigureBlockFormBase.php(353): Drupal\layout_builder\Form\ConfigureBlockFormBase->getCurrentSection()
#1 /var/www/web/modules/contrib/layout_builder_styles/layout_builder_styles.module(50): Drupal\layout_builder\Form\ConfigureBlockFormBase->getCurrentComponent()
#2 /var/www/web/core/lib/Drupal/Core/Extension/ModuleHandler.php(552): layout_builder_styles_form_alter(Array, Object(Drupal\Core\Form\FormState), 'layout_builder_...')
#3 /var/www/web/core/lib/Drupal/Core/Form/FormBuilder.php(834): Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object(Drupal\Core\Form\FormState), 'layout_builder_...')
#4 /var/www/web/core/lib/Drupal/Core/Form/FormBuilder.php(285): Drupal\Core\Form\FormBuilder->prepareForm('layout_builder_...', Array, Object(Drupal\Core\Form\FormState))
#5 /var/www/web/core/lib/Drupal/Core/Controller/FormController.php(73): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\layout_builder\Form\AddBlockForm), Object(Drupal\Core\Form\FormState))
#6 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch))
#7 /var/www/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#8 /var/www/web/core/lib/Drupal/Core/Render/Renderer.php(638): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#9 /var/www/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(121): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#10 /var/www/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#11 /var/www/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#12 /var/www/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#13 /var/www/web/core/lib/Drupal/Core/StackMiddleware/Session.php(53): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#14 /var/www/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#15 /var/www/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#16 /var/www/web/core/modules/big_pipe/src/StackMiddleware/ContentLength.php(32): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#17 /var/www/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#18 /var/www/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#19 /var/www/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#20 /var/www/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#21 /var/www/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#22 /var/www/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#23 /var/www/web/core/lib/Drupal/Core/DrupalKernel.php(741): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /var/www/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#25 {main}
Drupal 10.3 and PHP 8.2 compatibility MR has been created: MR 8724. Can someone please review?
One note: the patches from MR 8474 or comment #211 work and solve the problem. However, a PHP 8.2 deprecation notice remains as stated on #209:
Deprecated function: Creation of dynamic property Drupal\layout_builder\SectionComponent::$legacyAdditionalModuleKey is deprecated in Drupal\Core\Entity\Sql\SqlContentEntityStorage->loadFromDedicatedTables() (line 1269 of /web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php)
Applying this patch from #213 was helpful in make layout_builder_styles work properly when upgrading to 10.3.1.
I was getting
Deprecated function: Creation of dynamic property Drupal\layout_builder\SectionComponent::$thirdPartySettings is deprecated in Drupal\Component\Serialization\PhpSerialize::decode() (line 21 of core/lib/Drupal/Component/Serialization/PhpSerialize.php).
and also
Error: Call to a member function getSection() on null in Drupal\layout_builder\Form\ConfigureBlockFormBase->getCurrentSection() (line 341 of /var/www/web/core/modules/layout_builder/src/Form/ConfigureBlockFormBase.php).
When trying to create a new block or edit an existing block.
I added the field, updated the templates, and kept the same styling for any choice of heading level by adding a block-title class.
Could someone please review it?
The MR 67 is working as expected on my project. However, in my case, the content editors must be very careful and select the checkbox to clone the blocks inside blocks.
We are not using paragraphs.
For example, we have an Accordion block. Within the Accordion block type we have a Accordion Items field that you can reference Accordion Item block type.
If the editors are not careful in selecting those fields, they may have references to existing blocks and edits will be performed on the origin as well.
It would be nice to get a config to "Select all block_content" when cloning the entity.
carolpettirossi → created an issue.
I have faced an issue that I needed to add patch #42 + patch from https://www.drupal.org/project/layout_builder_st/issues/3069964 → when using the modules "Moderation Dashboard" and accessing the /user/{uid}/moderation-dashboard page.
I have also added a help text to the field. Can someone please review the MR?
Thanks :)
I updated the title to reflect the real issue.
Leandro, I figured out that you need to uncheck the "Double opt-in" on the handler.
I'm facing the same issue. Recent logs show that the email has been added to the list. However, when I go to Mailchimp dashboard (All contacts under Audience), I don't see the contact there.
This issue also occurred on Drupal 10.3.1 when I tried to edit a user.
Patch from #26 did solve the issue.
I just realized that the error is not on cl_editorial, and it is, in fact, on sdc_display.
Created an issue here: https://www.drupal.org/project/sdc_display/issues/3458639 🐛 The module is not compatible with Drupal 10.3.0 Needs review
Moving to "Needs review" for some other community members to review the patch provided if they use cl_editorial only.
carolpettirossi → created an issue.
Sorry, I moved to RTBC too soon.
I'm now facing a different error when I access "Manage Display" tab on the Basic Page CT:
AssertionError: assert($component_manager instanceof ComponentPluginManager) in assert() (line 58 of modules/contrib/sdc_display/sdc_display.module).
sdc_display_field_formatter_third_party_settings_form(Object, Object, 'default', Array, Object) (Line: 162)
Drupal\field_ui\Form\EntityViewDisplayEditForm->Drupal\field_ui\Form\{closure}(Object, 'sdc_display') (Line: 396)
Drupal\Core\Extension\ModuleHandler->invokeAllWith('field_formatter_third_party_settings_form', Object) (Line: 168)
Drupal\field_ui\Form\EntityViewDisplayEditForm->thirdPartySettingsForm(Object, Object, Array, Object) (Line: 451)
Drupal\field_ui\Form\EntityDisplayFormBase->buildFieldRow(Object, Array, Object) (Line: 41)
Drupal\field_ui\Form\EntityViewDisplayEditForm->buildFieldRow(Object, Array, Object) (Line: 227)
Drupal\layout_builder\Form\LayoutBuilderEntityViewDisplayForm->buildFieldRow(Object, Array, Object) (Line: 213)
Drupal\field_ui\Form\EntityDisplayFormBase->form(Array, Object) (Line: 47)
I was facing this error:
TypeError: Drupal\cl_editorial\NoThemeComponentManager::__construct(): Argument #1 ($pluginManager) must be of type Drupal\sdc\ComponentPluginManager, Drupal\Core\Theme\ComponentPluginManager given, called in /var/www/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 in Drupal\cl_editorial\NoThemeComponentManager->__construct() (line 23 of modules/contrib/cl_editorial/src/NoThemeComponentManager.php).
The MR code solved the error.
I tested the patch provided on #115 on Drupal 10.3.0, and it worked as expected. See below the test steps I executed:
I'd like to contribute with the Change Record. I've started it here: https://www.drupal.org/node/3458540 →
Can someone please review it?
Re-roll provided on #121 worked for me. Thanks :))
Patch #134 worked perfectly on Drupal 10.3.0. Thanks for the re-roll Rajab.
Patch #81 worked perfectly on Drupal 10.3.0. Thanks for the re-roll.
I re-rolled patch #49 for Drupal 10.3.x and it's available in the MR 8619 above.
It would be great if we could get a new module version with the MR approved/merged
carolpettirossi → created an issue.
carolpettirossi → created an issue.
Updating to Needs Work as there are still tests pending on this.
carolpettirossi → created an issue.
I applied the MR and it worked perfectly on my case. Moving this to RTBC. Hopefully this can be pushed to the next release.
carolpettirossi → created an issue.
+1 to this!
I'd like to suggest that the items should be processed in batches. If the views have lots of results, this could result in a max execution timeout.
I just tested the patch from the MR and it doesn't seem to be working accordingly.
Module version: 2.0.1
- Create a new event series
- Set to happen every monday
- Set capacity: 3
- Enable registration
- Enable waitlist
- Save the event series
- Access the events list
Result: Join Waitlist button is displayed when there are no registrants.
I would like to add +1 to this feature. It would be great.
carolpettirossi → created an issue.
Downloading the diff and uploading the patch to your local repo is the recommended approach.
However, I'm attaching the patch from the MR here in case someone is used to this old approach of adding patches to the issue.
The code works successfully in my case. Can't wait to see this merged and released.
I was facing the same error after creating a group on /group/1/member/1. patch #17 solved the issue.
Thanks for reviewing and for your feedback, @Berdir. Unfortunately, this would mean maintaining many display modes and configs in our project. So, I'll keep the Formatter I suggested above in our custom code.
I've just tested the latest changes, and it's working as expected:
- Can use the default transform base url
- Can use a preset
- Can use a custom transformation
carolpettirossi → created an issue.