🇧🇷Brazil @carolpettirossi

I applied the MR and it worked perfectly on my case. Moving this to RTBC. Hopefully this can be pushed to the next release.

carolpettirossi → created an issue.

+1 to this!

I'd like to suggest that the items should be processed in batches. If the views have lots of results, this could result in a max execution timeout.

I just tested the patch from the MR and it doesn't seem to be working accordingly.

Module version: 2.0.1

1. Create a new event series
2. Set to happen every monday
3. Set capacity: 3
4. Enable registration
5. Enable waitlist
6. Save the event series
7. Access the events list

Result: Join Waitlist button is displayed when there are no registrants.

Here's a screencast of the steps above. →

I would like to add +1 to this feature. It would be great.

carolpettirossi → created an issue.

Downloading the diff and uploading the patch to your local repo is the recommended approach.
However, I'm attaching the patch from the MR here in case someone is used to this old approach of adding patches to the issue.

The code works successfully in my case. Can't wait to see this merged and released.

I was facing the same error after creating a group on /group/1/member/1. patch #17 solved the issue.

Thanks for reviewing and for your feedback, @Berdir. Unfortunately, this would mean maintaining many display modes and configs in our project. So, I'll keep the Formatter I suggested above in our custom code.

I've just tested the latest changes, and it's working as expected:

- Can use the default transform base url
- Can use a preset
- Can use a custom transformation

carolpettirossi → created an issue.

@primsi, thanks for working on the MR and improving it. I tested and it works as expected with custom transformation and presets.

Moving this to RTBC

@Primsi, I added another comment aside from the above to the MR.

Please let me know how I can improve this MR and get this into a state where we can push to the module.

Thanks,
Carol

MR #47 worked like a charm. I had also removed the following from /admin/appearance/settings/openy_carnation

.card
.card-body
.card h3
.card .node__content

Result:

@froboy,

That does solve the issue with the buttons over the border.

However, I would expect the buttons to be aligned at the bottom of the card. And they are now right after the text.

carolpettirossi → created an issue.

carolpettirossi → created an issue.

Patch #40 couldn't be applied on Drupal 10.2.5.

I tested the latest MR, and I'm attaching the file I used to test. It works as expected and solves the warnings.

Can someone review the code I proposed in the MR?

I'm basically suggesting we keep using TRANSFORMATIONS_FIELD_NAME to store the preset. When the URL has the transform/{preset}/{bynder_id} structure we save the transformation as preset:{preset_machine_name} and the when displaying it, we check for preset: before moving to the "default" approach.

Attaching the patch for reference and composer usage

Updating this to a Feature Request since it doesn't seem that the module already supports DAT Preset.

It looks like when the media entity is created, we don't save the preset information:

          $media[] = $storage->create([
            'bundle' => $image_type->id(),
            $image_source_field => $bynder_info['id'],
            'name' => $bynder_info['name'],
            Bynder::TRANSFORMATIONS_FIELD_NAME => $transformation,
          ]);

What's the best approach here? Saving it in the TRANSFORMATIONS_FIELD_NAME? or creating a new field?

Looking at how the module works, it seems that it saves the transformations from the URL. The problem is that the preset doesn't have transformations with the expected structure in the URL.

So the preset format is:
https://trinity.bynder.com/transform/1x1/d5033e2c-5171-47d7-8a33-c2b852e7a7f5/Beta-Gamma-Sigma-240405-036

The custom transformation format is:
https://trinity.bynder.com/transform/0e549895-f5f0-4f09-8c1d-6fa9e9f13179/Beta-Gamma-Sigma-240405-037?io=transform:crop,height:250,width:250,path:circle&focuspoint=0.4,0.26

Note, there's no io param in the preset which breaks this part of the code in the BynderSearch class:

  public function getTransformations(string $url) {
    // Cannot use UrlHelper here, because Bynder uses the same query arg for
    // all transformations. E.g. ?io=transform:fo&io=filter:bar.
    if ($transformations = parse_url($url, PHP_URL_QUERY)){
      return $transformations;
    }
    return NULL;
  }

Then on BynderFormatter, when rendering the media entity, the TRANSFORMATIONS_FIELD_NAME returns empty
$media_entity->get(Bynder::TRANSFORMATIONS_FIELD_NAME)->isEmpty()

Results in rendering the image with the default DAT config from the formatter, when in fact I'd like to use the preset.

Any suggestions on how we can improve the module to allow Presets?

carolpettirossi → made their first commit to this issue’s fork.

Tested the MR and works as expected matching Figma

carolpettirossi → created an issue.

The MR did solve the issue on our project.

After patch:

However not sure why the cards have a inline height set that led us to add a !important to code

carolpettirossi → changed the visibility of the branch 3437650-cta-button-overlaps to active.

carolpettirossi → created an issue.

carolpettirossi → created an issue.

Forgot to click "Upload". Sorry about that

Uploading a patch from MR#57.

I tested it on my projects, and it worked as expected.

Removing popperjs as suggested on MR#25 worked for us.

Attaching patch from MR#25 to use with composer.

Updated patch with missing } and )

Added the changes from @olegrymar to the MR.

Attaching patch to use with composer.

@olegrymar, please, when working on this issue, work on the Issue fork branch along with others to avoid losing the changes that the community is doing on this as well

The code proposed in the MR did not solve the deprecated issues for me.

In our case we moved the 'Block Description' outside of the Form Display of a bunch of block types.

We didn't know that disabling Block Description would result in lots of Blocks with empty Admin Labels.

As a result, when we click to "Create a new block" in Layout Builder, lots of "Deprecated" messages are being logged:

Deprecated function: strnatcasecmp(): Passing null to parameter #2 ($string2) of type string is deprecated in Drupal\Core\Block\BlockManager->Drupal\Core\Plugin\{closure}() (line 95 of /var/www/web/core/lib/Drupal/Core/Plugin/CategorizingPluginManagerTrait.php)
#0 /var/www/web/core/includes/bootstrap.inc(164): _drupal_error_handler_real(8192, 'strnatcasecmp()...', '/var/www/web/co...', 95)
#1 [internal function]: _drupal_error_handler(8192, 'strnatcasecmp()...', '/var/www/web/co...', 95)
#2 /var/www/web/core/lib/Drupal/Core/Plugin/CategorizingPluginManagerTrait.php(95): strnatcasecmp('', NULL)
#3 [internal function]: Drupal\Core\Block\BlockManager->Drupal\Core\Plugin\{closure}(Array, Array)
#4 /var/www/web/core/lib/Drupal/Core/Plugin/CategorizingPluginManagerTrait.php(96): uasort(Array, Object(Closure))
#5 /var/www/web/core/lib/Drupal/Core/Block/BlockManager.php(76): Drupal\Core\Block\BlockManager->traitGetSortedDefinitions(Array, 'admin_label')
#6 /var/www/web/core/lib/Drupal/Core/Plugin/CategorizingPluginManagerTrait.php(105): Drupal\Core\Block\BlockManager->getSortedDefinitions(Array, 'label')
#7 /var/www/web/core/modules/layout_builder/src/Controller/ChooseBlockController.php(181): Drupal\Core\Block\BlockManager->getGroupedDefinitions(Array)
#8 /var/www/web/modules/contrib/layout_builder_restrictions/src/Controller/ChooseBlockController.php(42): Drupal\layout_builder\Controller\ChooseBlockController->inlineBlockList(Object(Drupal\layout_builder\Plugin\SectionStorage\OverridesSectionStorage), 0, 'blb_region_col_...')
#9 [internal function]: Drupal\layout_builder_restrictions\Controller\ChooseBlockController->inlineBlockList(Object(Drupal\layout_builder\Plugin\SectionStorage\OverridesSectionStorage), '0', 'blb_region_col_...')
#10 /var/www/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array)
#11 /var/www/web/core/lib/Drupal/Core/Render/Renderer.php(627): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#12 /var/www/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure))
#13 /var/www/web/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array)
#14 /var/www/vendor/symfony/http-kernel/HttpKernel.php(181): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
#15 /var/www/vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1)
#16 /var/www/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#17 /var/www/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#18 /var/www/web/core/lib/Drupal/Core/StackMiddleware/ContentLength.php(28): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#19 /var/www/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\ContentLength->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#20 /var/www/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#21 /var/www/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#22 /var/www/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#23 /var/www/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#24 /var/www/web/core/lib/Drupal/Core/StackMiddleware/AjaxPageState.php(36): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#25 /var/www/web/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(51): Drupal\Core\StackMiddleware\AjaxPageState->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#26 /var/www/web/core/lib/Drupal/Core/DrupalKernel.php(704): Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true)
#27 /var/www/web/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request))
#28 {main}

The patch suggested here: https://www.drupal.org/project/drupal/issues/3316811#comment-14796459 🐛 strnatcasecmp(): Passing null to parameter #1 ($string) of type string is deprecated Closed: duplicate does solve our issues.

I created an issue fork to start working together.

I updated the menu and config to be more generic: openy_gtranslate.settings.

I think we should add configure: openy_gtranslate.settings to the info.yml. However, when I add this, the patch cannot be applied. So I removed for now.

I'm attaching a version of the current MR as a .patch to use with composer.json

carolpettirossi → changed the visibility of the branch 3427881-can-the-widget to active.

carolpettirossi → changed the visibility of the branch 3427881-can-the-widget to hidden.

carolpettirossi → changed the visibility of the branch 3427881-can-the-widget to hidden.

carolpettirossi → created an issue.

carolpettirossi → created an issue.

I couldn't reproduce the issue on Drupal 10.2.4

1. Created a D10 instance on simplytest.me
2. Enabled LB & overrides on the basic page content type
3. Created a basic page
4. Clicked on Layout tab
5. Click to "add block"
6. Try filter by an invalid block name and then fix the typo

Result: working as expected listing the available blocks.

I've been using patch from MR and it's working properly. Changing to RTBC

Still getting the PHPCS error on trigger_error. However, I'm wondering if that trigger_error is needed. Is there an intention to make $logger required in a future Drupal version? If yes, do we need a Change Record to link to?

Thanks @drclaw! You patch worked for me and saving me some time debugging and trying to figure out the issue.

I created an MR with code from patch #87 as recommended by the "needs-review-queue-bot"

carolpettirossi → changed the visibility of the branch 3049332-call-to-a-member-function-getEntityTypeId()-on-null to hidden.

carolpettirossi → made their first commit to this issue’s fork.

I ran into this issue after running "composer update -W".

I'm on Drupal Core 10.2.4 and layout_builder_st 1.0.0-alpha3

Applying patch #15 solved the issue!

seantwalsh → credited carolpettirossi → .

I solved the MR conflict for 11.x

However, we need an MR for 10.2.x as the diff from 4178 MR doesn't work with Drupal 10.2.x

carolpettirossi → made their first commit to this issue’s fork.

I couldn't apply the patch as it's an old one.

However, I'm thinking about creating the views on my custom code and overriding the /admin/group path.

Is there any risk with this approach?

carolpettirossi → created an issue.

Attaching patch from MR to use with composer.json

Hi drunken monkey,

Is this still an issue nowadays?
We have a "Bundles" listing page per author with a "Add bundle" link at the top.
We have 'index items immediately'.
However, when the user goes back to their bundles listing page, the new added bundle is not there.

Attaching patch from MR to use with composer.

carolpettirossi → created an issue.

I don't think this is a duplicate. It looks like the other issue has been merged already. However, the WSOD with backtrace information still shows.

See the video attached showing the scenario.

Uploading file to be used in composer as .diff is not recommended.

carolpettirossi → created an issue.

Attaching patch from MR#4 to use with composer

Attaching patch from MR#59 to use with composer.

Attaching the patch from 4994 MR to use with composer as .diff link is not recommended.

I applied patch #7 and it works as expected.

carolpettirossi → created an issue.

Hi @deborahblessy

Can you please share a screenshot of the "Detection and Selection" page?

It seems for the URLs you shared, that you kept the URL (Language from the URL - Path prefix or domain) enabled. The bug happens only if you don't have that enabled.

See my config page below:

carolpettirossi → created an issue.

carolpettirossi → created an issue.

I'm facing this issue when I place a views block on a page using Layout Builder.

I get a duplicated title:

Also, this seems to be happening in my case only when I navigate to page 2, page 3...

Attaching patch to use with composer

carolpettirossi → created an issue.

Same as #18.

I had to downgrade to 2.1

Here's a patch for the version 2.x of facets.
In our case, we can't upgrade to 3.x as we are using the facets_form module that is locked on 2.x

Attaching .patch to use with composer.json

MR is ready to review. Note that the code only works if the messages div has "role=alert"

carolpettirossi → created an issue.

The patch from MR diff does not apply properly to 2.2.0.
I'm attaching a patch here in case someone needs a patch to apply to the stable version 2.2.0

Hey hey, I'm wondering if there are any plans for a new release soon?

I'm facing an issue where the Media Library pagination doesn't work, which might be related to this.

I get 414 URI-Request too long error.

Here's a screencast:
414 error with media pagination →

I applied the patch on my project and the deprecation notices are gone.

I was facing the deprecation notices in any node with layout builder.

I'm facing the exact same issue.