- 🇺🇸United States kazajhodo
I made a patch... of a patch.
When I went to apply my patch, I was editing already patched code.
My combined patch is attached. I did it this way as I'm not all that convinced its the correct way to do it; but at my experience level it seems like the proper place.
This seems to make the clone work fine, and then saves as expected.
- First commit to issue fork.
- last update
about 1 year ago 29 pass - @abu-zakham opened merge request.
- last update
about 1 year ago 29 pass - last update
about 1 year ago 29 pass - 🇧🇷Brazil carolpettirossi Campinas - SP
I've tested the latest code from MR #42, and it works as expected in my scenarios.
Without cloning the inline blocks, when I edited the cloned page via the Layout tab, the blocks were there; however, preview of paragraphs was not possible due to the parent entity being incorrect.
Attaching the patch to use in composer.json.
Thank you everyone working on this! :))
- 🇺🇸United States amitchell-p2
For those tracking different parts of this across several issues:
Using #52, I was running into the issue mentioned in #48.
Just added a new patch (#36) on 2062819 that should solve the missing id issue by using reflection to get the entity id from the plugin:
https://www.drupal.org/project/drupal/issues/3062819#comment-15053937 🐛 Cloned entities don't retain their Inline Block usage Needs work
- last update
about 1 year ago 28 pass, 2 fail - last update
about 1 year ago 28 pass, 2 fail - First commit to issue fork.
- last update
about 1 year ago 29 pass - last update
about 1 year ago 30 pass - last update
about 1 year ago Patch Failed to Apply - Status changed to Needs work
about 1 year ago 6:20pm 22 June 2023 - last update
12 months ago 30 pass - 🇧🇷Brazil carolpettirossi Campinas - SP
Updated the MR with the latest code from beta4. Working as expected on my layout builder projects :)
- 🇺🇦Ukraine anpolimus Kyiv
Last MR diff, updated by @carolpettirossi applies to the beta4 version and fixes the issue.
- Status changed to RTBC
11 months ago 11:34am 25 July 2023 - 🇺🇦Ukraine anpolimus Kyiv
I tested on a couple of projects the last fix. Last MR fixes the problem on both.
I think it is ready for RTBC but we need somebody else to verify everything is fine. - last update
11 months ago 30 pass - last update
11 months ago 30 pass - 🇬🇧United Kingdom gillarf
I've tested the last MR and it works on my project.
- last update
11 months ago 30 pass - last update
10 months ago 30 pass -
Rajeshreeputra →
committed aaa4d9a0 on 2.x authored by
abu-zakham →
Issue #3050027 by carolpettirossi, tim-diels, Rajeshreeputra,...
-
Rajeshreeputra →
committed aaa4d9a0 on 2.x authored by
abu-zakham →
- Status changed to Fixed
10 months ago 4:36am 14 September 2023 - 🇮🇳India Rajeshreeputra Pune
Merged, release to follow shortly. Thank you for working on it!!
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
5 months ago 9:27pm 6 February 2024 - 🇺🇸United States andyg5000 North Carolina, USA
Thanks for everyone that worked on this.
Whenever a major bug that can cause data to be deleted is fixed/merged, can we get a new release with it? Please.
- 🇩🇰Denmark LupusGr3y
Why on earth has this not been released yet? This is so important!
- Status changed to Needs work
3 months ago 2:17pm 2 April 2024 - 🇧🇪Belgium joevagyok
The merged code from this issue introduced a bug on the latest beta5 release!
I understand the urgency of the layout builder issue, but we can't merge code without tests!I see code fragments from #3258535 🐛 Translatable entity reference fields are not cloned correctly Needs work ended up in the merge request, which basically looping through the languages and cloning entities all over the place without actually preventing creating several duplicates and filling up the database with orphan entities.
I will open a merge request to revert this issue and make a new release as it is broken and create an opportunity to fix the problems and implement tests.
-
Rajeshreeputra →
committed df1c9084 on 2.x
Revert "Issue #3050027 by carolpettirossi, tim-diels, Rajeshreeputra,...
-
Rajeshreeputra →
committed df1c9084 on 2.x
- 🇮🇳India Rajeshreeputra Pune
As the latest release with merge introduced 🐛 Revert "Inline Blocks on Layout Builder" issue which introduced a bug of duplicate entity clones Needs review hence reverted and released new tag. Thank you @joevagyok for reporting, you can close the another issue.
- last update
about 2 months ago Fetch Error