🇧🇪Belgium @joevagyok

Thanks for the work!

joevagyok → created an issue.

joevagyok → created an issue.

Thanks for the review comments. The MR is in a work in progress.

joevagyok → made their first commit to this issue’s fork.

Anyhow, rebased the MR over 8.x-2.x.

I think this issue should be closed in favour of Drush 13 update where Drush 12 should be the minimum version required. https://www.drupal.org/project/extra_field/issues/3511072 📌 Drush 13 compatibility Active

joevagyok → made their first commit to this issue’s fork.

The MR had missing pieces from the patch, I pushed it.
I attached a patch file for composer patching against 1.19 version.

joevagyok → made their first commit to this issue’s fork.

Thank you all!

Already fixed. Thank you.

Thank you all!

joevagyok → made their first commit to this issue’s fork.

Thank you all!

joevagyok → made their first commit to this issue’s fork.

Thank you all!

joevagyok → made their first commit to this issue’s fork.

Thank you all! :)

Thanks for the fix, can we have some assertions for this please?

Thank you all!

Thank you all!

Thank you for the proposal! Test coverage for this would be much appreciated!

Thank you!

Thank you all!

@neclimdul can we have a merge request with this please?

joevagyok → made their first commit to this issue’s fork.

Also some basic test coverage of the code would be much apprechiated!

I like the proposal and the patch! Can we get a merge request with it please? :)

Thank you!

joevagyok → made their first commit to this issue’s fork.

joevagyok → made their first commit to this issue’s fork.

Thank you!

Thank you all!

Thank you all!

Thank you all!

The solution is looking good for me! Thanks @scott_euser

greggles → credited joevagyok → .

Opened another MR against the 3.x branch as well.
Uploading the patch file against the 3.0.0-rc20 release for composer patching.

Approved the MR, ready for merge.

MR looks good, we are using the patch in our project.

Thank you all for the contribution!

Removed the big border to have only the image.

Thank you for the simplified version, I find it way too simple. :)

I fixed the numbering on the previous.

I recently merged a fix related to this. I believe it is fixed by 3478937 🐛 CkEditor5 Counter gets attached in the wrong place after ajax call Active .

Can you please confirm?

I understand that you would expect from the config to act as a definitive limit when turned on and truncate the string once it is switched on.
However, it implies that the field can hold more characters just well, before the option was not turned on, so having the string truncated on form load, would render part of your pages unreadable due to the loss of strings after the save operation. I find that a bit harsh and disturbing from the editor point of view.

Thank you for the fix!

Reviewed and tested by our organisation.

joevagyok → made their first commit to this issue’s fork.

Ready to merge upstream.

joevagyok → created an issue.

joevagyok → created an issue.

The patch in #11 looks good. We are using it on our project.

joevagyok → created an issue.

This issue is not close to be merged and here are some reasons why:

• The MR still introduces a bug which creates more cloned entities in certain conditions that in should. This can be only detected with automated tests asserting the amount of entities in the database after each clone.
• The base class meant for content entities should not contain layout builder specific logic, not every site has layout builder.
• There are certain entity types and entity reference combinations that are not entirely clear how we should proceed.
• The MR needs automated tests.

These have to be addressed before we make a review.

joevagyok → created an issue.

joevagyok → created an issue.

Thanks for reporting the problem. It seems that the new version of AI module introduces change that the plugin needs to accommodate.

Currently, I am away for couple of weeks, but after I will fix the issue, unless someone contributes the fix before.

joevagyok → created an issue.

joevagyok → created an issue.

Thank you for the contribution.
Please add a test case functional test case to validate we actually have the issue and preferably the fix in a separate commit to show it fixes the problem.

dan2k3k4 → credited joevagyok → .

joevagyok → created an issue.

joevagyok → made their first commit to this issue’s fork.

Can we have an MR over 4.x please?

Thank you! :)

joevagyok → created an issue.