🇧🇪Belgium @joevagyok

Already fixed. Thank you.

Thank you all!

joevagyok → made their first commit to this issue’s fork.

Thank you all!

joevagyok → made their first commit to this issue’s fork.

Thank you all!

joevagyok → made their first commit to this issue’s fork.

Thank you all! :)

Thanks for the fix, can we have some assertions for this please?

Thank you all!

Thank you all!

Thank you for the proposal! Test coverage for this would be much appreciated!

Thank you!

Thank you all!

@neclimdul can we have a merge request with this please?

joevagyok → made their first commit to this issue’s fork.

Also some basic test coverage of the code would be much apprechiated!

I like the proposal and the patch! Can we get a merge request with it please? :)

Thank you!

joevagyok → made their first commit to this issue’s fork.

joevagyok → made their first commit to this issue’s fork.

Thank you!

Thank you all!

Thank you all!

Thank you all!

The solution is looking good for me! Thanks @scott_euser

greggles → credited joevagyok → .

Opened another MR against the 3.x branch as well.
Uploading the patch file against the 3.0.0-rc20 release for composer patching.

Approved the MR, ready for merge.

MR looks good, we are using the patch in our project.

Thank you all for the contribution!

Removed the big border to have only the image.

Thank you for the simplified version, I find it way too simple. :)

I fixed the numbering on the previous.

I recently merged a fix related to this. I believe it is fixed by 3478937 🐛 CkEditor5 Counter gets attached in the wrong place after ajax call Active .

Can you please confirm?

I understand that you would expect from the config to act as a definitive limit when turned on and truncate the string once it is switched on.
However, it implies that the field can hold more characters just well, before the option was not turned on, so having the string truncated on form load, would render part of your pages unreadable due to the loss of strings after the save operation. I find that a bit harsh and disturbing from the editor point of view.

Thank you for the fix!

Reviewed and tested by our organisation.

joevagyok → made their first commit to this issue’s fork.

Ready to merge upstream.

joevagyok → created an issue.

joevagyok → created an issue.

The patch in #11 looks good. We are using it on our project.

joevagyok → created an issue.

This issue is not close to be merged and here are some reasons why:

• The MR still introduces a bug which creates more cloned entities in certain conditions that in should. This can be only detected with automated tests asserting the amount of entities in the database after each clone.
• The base class meant for content entities should not contain layout builder specific logic, not every site has layout builder.
• There are certain entity types and entity reference combinations that are not entirely clear how we should proceed.
• The MR needs automated tests.

These have to be addressed before we make a review.

joevagyok → created an issue.

joevagyok → created an issue.

Thanks for reporting the problem. It seems that the new version of AI module introduces change that the plugin needs to accommodate.

Currently, I am away for couple of weeks, but after I will fix the issue, unless someone contributes the fix before.

joevagyok → created an issue.

joevagyok → created an issue.

Thank you for the contribution.
Please add a test case functional test case to validate we actually have the issue and preferably the fix in a separate commit to show it fixes the problem.

dan2k3k4 → credited joevagyok → .

joevagyok → created an issue.

joevagyok → made their first commit to this issue’s fork.

Can we have an MR over 4.x please?

Thank you! :)

joevagyok → created an issue.

joevagyok → created an issue.

Thanks @tirupati_singh, small note from my side, if I may.

It looks good in general and the style looks similar to the examples mentioned. However, not sure how big the project browser will show these images, but if it will be small, then the numbers and the "Maxlength" text would be too small I think. But I would refer to @kristen pol in this matter.

If we wish to have the name of the module in the image, please respect the way it is on drupal.org page, "MaxLength" in this case.
Otherwise, the HTML attribute could be used, such as "#maxlength" which is self-explanatory as well.

Let's make a merge request out of this and an automated test!

Please create a merge request with the changes and provide/adapt tests!

@partdigital can we have another PR with your proposal in a different branch on this issue for us to evaluate and choose?

Thank you!

This will be merged in 2.x as well.

joevagyok → changed the visibility of the branch project-update-bot-only to active.

joevagyok → changed the visibility of the branch 3431839-automated-drupal-11 to hidden.

Thanks @berdir! The MR adds previous minor and next major to the pipeline to test and fixes the issue mentioned above with jQuery.

joevagyok → made their first commit to this issue’s fork.