Contrib.social

Automated Drupal 11 compatibility fixes for remote_stream_wrapper

Open on Drupal.org β†’
Created on 24 March 2024, about 1 year ago
Updated 17 May 2024, 11 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot β†’ official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot β†’ or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot β†’ , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue β†’ . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue β†’ .

πŸ“Œ Task
Status

Needs review

Version

2.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment about 1 year ago β†’
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module β†’ these changes make this module compatible with Drupal 11! πŸŽ‰
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β†’ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-127659

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.9
    3. palantirnet/drupal-rector: 0.20.1
  • Merge request !11Automated Project Update Bot fixes β†’ (Open) created by project update bot
  • First commit to issue fork.
  • Merge request !12Issue #3434168: Drupal 11 compatibility fixes for remote_stream_wrapper... β†’ (Open) created by jrglasgow
  • Pipeline finished with Failed
    11 months ago
    Total: 182s
    #175332
  • Comment 10 months ago β†’
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module β†’ these changes make this module compatible with Drupal 11! πŸŽ‰
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β†’ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-217342

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.4
    2. mglaman/phpstan-drupal: 1.2.11
    3. palantirnet/drupal-rector: 0.20.3
  • Pipeline finished with Failed
    10 months ago
    Total: 149s
    #217613
  • First commit to issue fork.
  • Pipeline finished with Failed
    6 months ago
    #319959
  • Pipeline finished with Failed
    6 months ago
    Total: 223s
    #319962
  • Comment 6 months ago β†’
    πŸ‡ΊπŸ‡¦Ukraine pingwin4eg Zaporizhia πŸ‡ΊπŸ‡¦

    Re: MR !12

    Stream wrapper must not have a constructor. Because this breaks fopen() and alike functions:

    [error]  ArgumentCountError: Too few arguments to function Drupal\remote_stream_wrapper\StreamWrapper\HttpStreamWrapper::__construct(), 0 passed and exactly 1 expected in Drupal\remote_stream_wrapper\StreamWrapper\HttpStreamWrapper->__construct() (line 53 of .../web/modules/contrib/remote_stream_wrapper/src/StreamWrapper/HttpStreamWrapper.php) #0 [internal function]: Drupal\remote_stream_wrapper\StreamWrapper\HttpStreamWrapper->__construct()

    Look at core implementations of StreamWrapperInterface - they all use static calls to \Drupal::service(...) or similar.

  • Comment 6 months ago β†’
    πŸ‡ΊπŸ‡¦Ukraine pingwin4eg Zaporizhia πŸ‡ΊπŸ‡¦

    pingwin4eg β†’ changed the visibility of the branch 2.x to hidden.

  • Comment 6 months ago β†’
    πŸ‡ΊπŸ‡¦Ukraine pingwin4eg Zaporizhia πŸ‡ΊπŸ‡¦

    Working on removing constructor from stream wrapper.

  • Pipeline finished with Failed
    6 months ago
    Total: 142s
    #335127
  • Comment 6 months ago β†’
    πŸ‡ΊπŸ‡¦Ukraine pingwin4eg Zaporizhia πŸ‡ΊπŸ‡¦

    pingwin4eg β†’ changed the visibility of the branch project-update-bot-only to hidden.

  • Pipeline finished with Failed
    6 months ago
    Total: 147s
    #335137
  • Comment 6 months ago β†’
    πŸ‡ΊπŸ‡¦Ukraine pingwin4eg Zaporizhia πŸ‡ΊπŸ‡¦

    PhpUnit previous major (Drupal: 10.3.6, PHP 8.1.30) and next minor (Drupal: 11.1.0-dev, PHP 8.3.13) both pass on all tests except one for HttpMimeTypeGuesserTest, but that should be fixed by πŸ“Œ Fix mime-type guesser for Drupal >= 10.3.2 Active .

    I'm also going to manually test this MR in one of my projects in the near future. And I'm thinking (not sure) - whether the auto-testing for file functions (fopen, etc.) is needed.

  • Comment 3 months ago β†’
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module β†’ these changes make this module compatible with Drupal 11! πŸŽ‰
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot β†’ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-392907

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.3.6
    2. mglaman/phpstan-drupal: 1.3.2
    3. palantirnet/drupal-rector: 0.20.3
  • Pipeline finished with Failed
    3 months ago
    Total: 162s
    #393506
  • Comment 3 months ago β†’
    πŸ‡΅πŸ‡±Poland Pawelgorski87
  • Pipeline finished with Failed
    3 months ago
    Total: 153s
    #413466
  • Pipeline finished with Failed
    3 months ago
    Total: 158s
    #413470
  • Pipeline finished with Failed
    3 months ago
    Total: 162s
    #413500
  • Pipeline finished with Failed
    3 months ago
    Total: 153s
    #413531
  • Pipeline finished with Failed
    3 months ago
    Total: 153s
    #413532
  • Pipeline finished with Failed
    3 months ago
    Total: 168s
    #413551
  • Comment 3 months ago β†’
    πŸ‡ΊπŸ‡ΈUnited States yorchperaza Denver

    Hello! Is there any estimate of obtaining the compatibility merge and being able to have a Drupal 11 version of the module? I need help with something, I am available for anything.

  • Comment 3 months ago β†’
    πŸ‡ΊπŸ‡¦Ukraine pingwin4eg Zaporizhia πŸ‡ΊπŸ‡¦

    @pawelgorski87 Why don't you read issue comments? Please read them, and revert your breaking changes.

  • Comment 3 months ago β†’
    πŸ‡΅πŸ‡±Poland Pawelgorski87

    @pingwin4eg, right sorry. Constructor removed.

  • Pipeline finished with Failed
    3 months ago
    Total: 193s
    #414445
  • Pipeline finished with Failed
    3 months ago
    Total: 169s
    #414455
  • Pipeline finished with Success
    3 months ago
    Total: 195s
    #414493
  • Comment 3 months ago β†’
    πŸ‡΅πŸ‡±Poland Pawelgorski87

    @pingwin4eg I used Your patch for Guesser. Thank you.
    Now all pipelines passed. Please test and review.

  • Comment 3 months ago β†’
    πŸ‡΅πŸ‡±Poland Pawelgorski87
  • Comment 2 months ago β†’
    πŸ‡΅πŸ‡±Poland gpietrzak WrocΕ‚aw

    I reviewed the code and tested the module locally. I changed the image media type to accept remote streams and successfully added some new items. It worked fine (provided the image styles are not configured to use webp).

  • Comment 2 months ago β†’
    πŸ‡΅πŸ‡±Poland Pawelgorski87
  • Comment 2 months ago β†’
    πŸ‡·πŸ‡΄Romania andras_szilagyi

    Looks good, works fine also in my tests

  • Comment 2 months ago β†’
    πŸ‡ΊπŸ‡ΈUnited States yorchperaza Denver

    Loos good, works for me!

  • First commit to issue fork.
  • Comment about 2 months ago β†’
    πŸ‡ΊπŸ‡ΈUnited States yorchperaza Denver

    Is there any estimate to get this merge into the dev module?

  • Comment about 2 months ago β†’
    πŸ‡§πŸ‡ͺBelgium msnassar

    RTBC++
    I have tested it with media_avportal https://www.drupal.org/project/media_avportal/issues/3431855 πŸ“Œ Automated Drupal 11 compatibility fixes for media_avportal Needs review . All works as expected.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024