🇺🇸United States @jrglasgow

Idaho
Account created on 20 October 2005, about 19 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

I have the necessary changes made and in a merge request

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

I have this fixed and a pull request made.

🇺🇸United States jrglasgow Idaho

I was having the same issue and ended up tracking it down to this issue... I have a different symptom. After running composer update my `drush cr` failed with this message:

$ drush cr

In Container.php line 147:

Circular reference detected for service "module_handler", path: "module_handler -> cache.bootstrap -> logger.factory -> logger.syslog -> config.factory -> config.typed".

Failed to run drush cr: exit status 1

the `drush updb` succeeded but had some
[error] MemcachedDriver::set() error
errors.

I then put in a breakpoint where the exception was being thrown and traced it back to Memcache and reverted from 8.x-2.6 to 8.x-2.5 and the problem was resolved. Also updated to the latest dev release resolves the issue.

I am putting the specific errors I had in here to make it easier to find when searching.

🇺🇸United States jrglasgow Idaho

Any chance getting a new release with this fix?

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow created an issue.

🇺🇸United States jrglasgow Idaho

I took a look with the Upgrade Status module and there are 28 problems

  • 25 issues with functionality provided by this module which was marked "Deprecated as of Plugin 8.x-2.0*. Scheduled for removal before 8.x-3.0". There was no documentation about replacement functionality hat I saw, and work on 3.0.x is not even begun as far as I can tell.
  • "Call to deprecated function assert_options()." which is "This function has been DEPRECATED as of PHP 8.3.0. Relying on this function is highly discouraged." but not yet scheduled fr removal in a specific PHP version
  • "Call to deprecated method getName() of interface Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal::service('extension.list.module')->getName($module) instead." which doesn't need to be removed yet and its removal would removed backwards compatibility.

I have updated composer.json and plugin.info.yml in this fork.

🇺🇸United States jrglasgow Idaho

The only outstanding PHP Stan issue I am seeing is

sites/default/modules/metatag/metatag_views/src/Form/MetatagViewsTranslationForm.php:173 The 'config_translation/drupal.config_translation.admin' library is not defined because the defining extension is not installed. Cannot decide if it is deprecated or not.

So I have added a check to see if he module is enabled before adding the library. I also rebased.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

according to my testing it appears to be working

🇺🇸United States jrglasgow Idaho

I made some additional fixes in MR 10 but letft it in draft as I haven't had a chance to test completely.

🇺🇸United States jrglasgow Idaho

I have some additional changes made, including removing calls to format_size() as suggested by PHPStan. This makes the module incompatible with Drupal core < 10.2.

I haven't really tested the change so I have MR 18 marked as draft.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

I have made a commit to the issue fork that splits out the login to determine if file_crusader can work on the entity into the $entity and $entity->original, first checking to see if $entity->original exists and is an object with the isPublished() method.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow created an issue.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

The attached patch or the Onelogin SAML library doesn't look like it is checking for a proxy or any settings to indicate it is behind a proxy. If that patch is required then I would suggest updating it to check so it doesn't somehow break something else... otherwise the patch should be added to the saml_sp composer.json so it will get automatically applied upon composer install.
Ideally the patch, if required, should be added to an issue file on the onelogin SAML library project.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

I added the patch in #3 to the fork as well as removing reference to ,a href=" https://www.drupal.org/node/3418480 ">KernelTestBase::checkRequirements() in tests which is deprecated in 10.3 and removed in 11.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow created an issue.

🇺🇸United States jrglasgow Idaho

jrglasgow changed the visibility of the branch 3447090-drupal-11-call to hidden.

🇺🇸United States jrglasgow Idaho

added a merge request to update compatibility

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

I updated the fork to be compatible with Drupal 11 (at least removed Drupal 11 deprecations) I haven't yet tested.

PHP Stan still finds a few more issues of deprecations that were just deprecated in Drupal 10.3 (a few weeks ago at this posting) and aren't being removed until Drupal 12. I didn't want to exclude anyone who isn't on Drupal 10.3 yet.

 ------ ------------------------------------------------------------------------------------------------------
  Line   filefield_sources.module
 ------ ------------------------------------------------------------------------------------------------------
  439    Fetching deprecated class constant EXISTS_RENAME of interface Drupal\Core\File\FileSystemInterface:
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use
         \Drupal\Core\File\FileExists::Rename instead.
  446    Fetching deprecated class constant EXISTS_RENAME of interface Drupal\Core\File\FileSystemInterface:
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use
         \Drupal\Core\File\FileExists::Rename instead.
  521    Fetching deprecated class constant EXISTS_REPLACE of interface Drupal\Core\File\FileSystemInterface:
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use
         \Drupal\Core\File\FileExists::Replace instead.
 ------ ------------------------------------------------------------------------------------------------------
🇺🇸United States jrglasgow Idaho

I have pushed a commit to the issue form and created a merge request.
As far as PHP Stan could find there was only one deprecated item that needed fix which necessitates;

core_version_requirement: ^10.3 || ^11
🇺🇸United States jrglasgow Idaho

yes, I ran into this today with a fresh install of the module... merged

🇺🇸United States jrglasgow Idaho

the patch from #20 wasn't applying to D10.3, I manually applied and created a fork for the issue.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

Just now I have sent a messages to the module maintainers (Dave Reid, arthurf, becw) through the contact form:

Subject: Making Remote Stream Wrapper compatible with D10.3
Message:

I see you are listed as one of the maintainers of the Remote Stream Wrapper module on Drupal.org. There is an issue which has come t light which makes it incompatible with Drupal 10.3.0 which was released recently. - https://www.drupal.org/project/remote_stream_wrapper/issues/3437974 📌 Drupal 10.3 ImageStyleDownloadController::deliver signature change Needs review . This issue was created in April with a merge request which has been open for approximately a month. To help keep the module working with the latest version of Drupal core this merge request, or one to accomplish the same thing should be merged in with a new release of the module.

Alternatively there is also an issue in the queue to add co-maintainers to the module. You can see that issue here: https://www.drupal.org/project/remote_stream_wrapper/issues/3458068 💬 Offering to co-maintain Remote Stream Wrapper Active

- James Glasgow (jrglasgow)

🇺🇸United States jrglasgow Idaho

I m also interested in becoming a co-maintainer to help keep this project up-to-date with the current Drupal core version.

🇺🇸United States jrglasgow Idaho

Good point, I believe that initially I created the subscriber as the D7 module added the JS with query parameters in hook_init(). after adding the subscriber I apparently went a different route (in JS Alter hook).

🇺🇸United States jrglasgow Idaho

the change is fine with me, as long as there is a good message in the release notes stating that is moved, and it can still be access from the configure link on the extend page

🇺🇸United States jrglasgow Idaho

I won't disagree with you, that was the quickest solution I could come up with when I was migrating the module to D8 from 7.

As long as it continues to work, it is fine with me.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

this is looking good to me

🇺🇸United States jrglasgow Idaho

this is working and ready to be committed

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

@dcam,
This looks good, I assume that once the JS is released next week you will update your branch to include it. When that is done go ahead and merge in your changes (I have made you a maintainer) and then create a new release.

🇺🇸United States jrglasgow Idaho

I recently ran into an error with the image formatter being hijacked where there is no image style... this occurs when the content display for the image field is set to show "original" so no image style is there to be applied.

🇺🇸United States jrglasgow Idaho

Here is a merge request that does the basics... I haven't had a chance to do any testing yet

🇺🇸United States jrglasgow Idaho

jrglasgow created an issue.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

yet another backwards incompatible update in a minor release

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

I have a merge request with the changes to update the signature and the Drupal core version to ^10.3

🇺🇸United States jrglasgow Idaho

This will cause a breakage beginning when Drupal 10.3 is released and people start upgrading to it.

🇺🇸United States jrglasgow Idaho

I guess I can mention that a PHPStan analysis returns

24/24 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
[OK] No errors

🇺🇸United States jrglasgow Idaho

jrglasgow created an issue.

🇺🇸United States jrglasgow Idaho

The fork appears to have merge conflicts, please fix and I will merge them in.

🇺🇸United States jrglasgow Idaho

The fork appears to have merge conflicts, please fix and I will merge them in.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

🇺🇸United States jrglasgow Idaho

jrglasgow made their first commit to this issue’s fork.

Production build 0.71.5 2024