πŸ‡ΊπŸ‡ΈUnited States @jrglasgow

Idaho
Account created on 20 October 2005, over 18 years ago
#

Merge Requests

More

Recent comments

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I added the patch in #3 to the fork as well as removing reference to ,a href=" https://www.drupal.org/node/3418480 β†’ ">KernelTestBase::checkRequirements() in tests which is deprecated in 10.3 and removed in 11.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ changed the visibility of the branch 3447090-drupal-11-call to hidden.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

added a merge request to update compatibility

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I updated the fork to be compatible with Drupal 11 (at least removed Drupal 11 deprecations) I haven't yet tested.

PHP Stan still finds a few more issues of deprecations that were just deprecated in Drupal 10.3 (a few weeks ago at this posting) and aren't being removed until Drupal 12. I didn't want to exclude anyone who isn't on Drupal 10.3 yet.

 ------ ------------------------------------------------------------------------------------------------------
  Line   filefield_sources.module
 ------ ------------------------------------------------------------------------------------------------------
  439    Fetching deprecated class constant EXISTS_RENAME of interface Drupal\Core\File\FileSystemInterface:
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use
         \Drupal\Core\File\FileExists::Rename instead.
  446    Fetching deprecated class constant EXISTS_RENAME of interface Drupal\Core\File\FileSystemInterface:
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use
         \Drupal\Core\File\FileExists::Rename instead.
  521    Fetching deprecated class constant EXISTS_REPLACE of interface Drupal\Core\File\FileSystemInterface:
         in drupal:10.3.0 and is removed from drupal:12.0.0. Use
         \Drupal\Core\File\FileExists::Replace instead.
 ------ ------------------------------------------------------------------------------------------------------
πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I have pushed a commit to the issue form and created a merge request.
As far as PHP Stan could find there was only one deprecated item that needed fix which necessitates;

core_version_requirement: ^10.3 || ^11
πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

yes, I ran into this today with a fresh install of the module... merged

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

the patch from #20 wasn't applying to D10.3, I manually applied and created a fork for the issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

Just now I have sent a messages to the module maintainers (Dave Reid, arthurf, becw) through the contact form:

Subject: Making Remote Stream Wrapper compatible with D10.3
Message:

I see you are listed as one of the maintainers of the Remote Stream Wrapper module on Drupal.org. There is an issue which has come t light which makes it incompatible with Drupal 10.3.0 which was released recently. - https://www.drupal.org/project/remote_stream_wrapper/issues/3437974 πŸ“Œ Drupal 10.3 ImageStyleDownloadController::deliver signature change Needs review . This issue was created in April with a merge request which has been open for approximately a month. To help keep the module working with the latest version of Drupal core this merge request, or one to accomplish the same thing should be merged in with a new release of the module.

Alternatively there is also an issue in the queue to add co-maintainers to the module. You can see that issue here: https://www.drupal.org/project/remote_stream_wrapper/issues/3458068 πŸ’¬ Offering to co-maintain Remote Stream Wrapper Active

- James Glasgow (jrglasgow)

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I m also interested in becoming a co-maintainer to help keep this project up-to-date with the current Drupal core version.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

Good point, I believe that initially I created the subscriber as the D7 module added the JS with query parameters in hook_init(). after adding the subscriber I apparently went a different route (in JS Alter hook).

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

the change is fine with me, as long as there is a good message in the release notes stating that is moved, and it can still be access from the configure link on the extend page

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I won't disagree with you, that was the quickest solution I could come up with when I was migrating the module to D8 from 7.

As long as it continues to work, it is fine with me.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

this is looking good to me

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

this is looking good to me

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

this is working and ready to be committed

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

@dcam,
This looks good, I assume that once the JS is released next week you will update your branch to include it. When that is done go ahead and merge in your changes (I have made you a maintainer) and then create a new release.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I recently ran into an error with the image formatter being hijacked where there is no image style... this occurs when the content display for the image field is set to show "original" so no image style is there to be applied.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

Here is a merge request that does the basics... I haven't had a chance to do any testing yet

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

yet another backwards incompatible update in a minor release

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I have a merge request with the changes to update the signature and the Drupal core version to ^10.3

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

This will cause a breakage beginning when Drupal 10.3 is released and people start upgrading to it.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I guess I can mention that a PHPStan analysis returns

24/24 [β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“β–“] 100%
[OK] No errors

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

The fork appears to have merge conflicts, please fix and I will merge them in.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

The fork appears to have merge conflicts, please fix and I will merge them in.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ’¬ | Schema | abandoned?
πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I don't have a use case for Single Logout, therefore I have no way to test if it works. If you would like to provide a merge request I can certainly merge it in.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

@brad.bulger Drupal.org like to have a new branch with the issue Id included in the branch name, then it is more useful if you create a merge request. Then it is easier for me to approve and merge the merge reqeuest.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

It looks like the default SharedTempStore expiration if 7 days, so for most people that shouldn'y be a problem. I certainly haven't needed a larger temp store. and yes TUS has been serving us well, we have been using it in production for the last year.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

@praveen rani The missing class is part of the Drupal\c2pa_sign\Event\CertificateValidateEvent module which is listed as a dependancy of this module. Can you verify that you have a version of c2pa_sign >=1.0.1 and that the module is enabled?

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I have created an issue fork for the patch in #11

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ made their first commit to this issue’s fork.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I created a new merge request to 11.x and changed the system_update hook to 10202 so it ensured to run.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ changed the visibility of the branch 3106205-menutree-url-and-route-length to hidden.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

I was unable to get wither merge request (10.1.x and 11.x) to apply to my 10.2.x sites, I hand applied the patch and created a new branch to be merged into 10.2.x. It is working for me on my local.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

@aman_lnwebworks,
I had actually noticed this on Friday and fixed it while working on the module, the commit never got push until this morning.

Thank you for catching it.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

please let me know if this changes fixed the problem for you

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

@Revathi.B, if there is a bug in the PHP wrapper library I am more than happy see issues filed in the github repository at https://github.com/jrglasgow/c2patool, you can also feel free to create a patch that can be added to your composer.json file - see https://vazcell.com/blog/how-apply-patch-drupal-9-and-drupal-10-composer.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

@dineshkumarbollu,
I have this fixed in the most recent version of the library (0.1.4) - https://github.com/jrglasgow/c2patool/releases/tag/0.1.4

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

this works for me, I think it is ready to be committed

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

never mind, it was a one off issue that I ended up being unable to replicate

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

jrglasgow β†’ created an issue.

πŸ‡ΊπŸ‡ΈUnited States jrglasgow Idaho

After applying the patch in #5 the warning disappeared in PHP 8.3 (went straight from 8.1 to 8.3)

Production build 0.69.0 2024