- Issue created by @jrglasgow
- 🇺🇸United States jrglasgow Idaho
I have the necessary changes made and in a merge request
When trying to add an override in a custom module I found that the overrides weren't getting run
attempt to create an override and ovserver that the override isn't getting executed
I looked at the code and when the uppy instance is being created I saw
// Keep track of it globally.
settings.uppyOverrides = settings.uppyOverrides || {}; // the overrides objectwas getting created (if it didn't already exist)
settings.uppyOverrides[id] ={"instance":uppy,"overrides":{}} // the instance was added for the uppy instance (with the instance added, but any overrides already existing was wiped out)
Instead we should
// Keep track of it globally.
settings.uppyOverrides = settings.uppyOverrides || {};
// set the overrides and uppy instance for the current field identified by "id"
settings.uppyOverrides[id] = settings.uppyOverrides[id] || {}; // ensure that the uppy instance has its own section of uppyOverrides
settings.uppyOverrides[id].overrides = settings.uppyOverrides[id].overrides || {}; // add the overrides object (if it doesn't already exist)
settings.uppyOverrides[id].instance = uppy; // add the uppy isntance
fork
push code to fork
create merge request
merge merge request
close ticket
none
none
none
Active
3.0
Code
I have the necessary changes made and in a merge request