- Issue created by @ericrubino
- First commit to issue fork.
- πΊπΈUnited States jvest
Created issue fork with the added parameters for async => true and header => true.
- πΊπΈUnited States jvest
Initial testing of the issue fork plain diff patch:
1) Install module:
composer require 'drupal/usfedgov_google_analytics:^2.x-dev'2) Enable:
drush en usfedgov_google_analytics3) On admin page:
/admin/config/system/usfedgov_google_analyticsAdd Agency (and optionally here Sub Agency)
4) Log out (code will not display for logged in users):
Confirm the code included just before closing tag at bottom of page HTML source:// Test the patch/changes:
1) Include the plain diff patch file in composer.json:"drupal/usfedgov_google_analytics": {
"3467630: Update module to follow DAP Guidelines": "https://git.drupalcode.org/project/usfedgov_google_analytics/-/merge_req..."
},2) Apply patch:
composer install3) Confirm code is now being included inside tag and includes "async" attribute:
Repeat above tests with Library option "Load Analytics library from CDN" switched off, with Minified selected and again with Original selected.
- First commit to issue fork.
-
jrglasgow β
committed 420ea4e9 on 2.x authored by
jvest β
Issue #3467630 by jvest: Update module to follow DAP Guidelines
-
jrglasgow β
committed 420ea4e9 on 2.x authored by
jvest β
Automatically closed - issue fixed for 2 weeks with no activity.