Tested patch #11 with v3.0.0 on Drupal core 10.2.11 and PHP 8.1.29 ... resolves warning messages.
Initial testing of the issue fork plain diff patch:
1) Install module:
composer require 'drupal/usfedgov_google_analytics:^2.x-dev'
2) Enable:
drush en usfedgov_google_analytics
3) On admin page:
/admin/config/system/usfedgov_google_analytics
Add Agency (and optionally here Sub Agency)
4) Log out (code will not display for logged in users):
Confirm the code included just before closing tag at bottom of page HTML source:
// Test the patch/changes:
1) Include the plain diff patch file in composer.json:
"drupal/usfedgov_google_analytics": {
"3467630: Update module to follow DAP Guidelines": "https://git.drupalcode.org/project/usfedgov_google_analytics/-/merge_req..."
},
2) Apply patch:
composer install
3) Confirm code is now being included inside tag and includes "async" attribute:
Repeat above tests with Library option "Load Analytics library from CDN" switched off, with Minified selected and again with Original selected.
Created issue fork with the added parameters for async => true and header => true.
Adding clarification on testing/review:
Used a shared DrupalPod instance
Enabled Authored By
Added several users added so that the list will be long enough when expanded
The overlay issue appearing behind the table heading is fixed.
Also manually changed the z-index back to original to show the original problem of the drop down appearing behind the table heading.
Have reviewed the merge request 2.0.x MR !4 and tested the diff as a patch, steps were:
Reproduced Issue:
Used existing Drupal 10.2 install
Installed usagov module
Configured with user agent and auth key in services/usajobs
Set to Organization = 11th Wing (known to not have any jobs to display)
Added block to homepage sidebar.
Resulted in the double periods being displayed:
Test For merge diff to fix:
Added the merge diff to composer.json:
"drupal/usajobs": {
"3439485: if (empty($markup)) sentence is grammatically incorrect. (Double Period)":
"https://git.drupalcode.org/project/usajobs/-/merge_requests/4.diff"
},
Run composer install.
Results in only 1 period being displayed.
Test is successful.
Reviewed #27 and tested with @kd_ace, issue looks good for rtbc status.