- Issue created by @eric@erubino.net
- 🇺🇸United States eric@erubino.net Washington DC
Created patch to remove the second period at the end of sentence when there are no jobs found.
- Status changed to Needs review
3 months ago 7:47pm 8 April 2024 - Merge request !4remove second period from output when there are no vacancy announcements → (Open) created by Unnamed author
Assisting the next hour with this issue at the mentored contribution session at DrupalCon Portland. Hiding non-canonical MR as well as updating issue summary with more detailed steps to reproduce. Will be reviewing issue fix as well.
kd_ace → changed the visibility of the branch 3439485-if-emptymarkup-sentence to hidden.
- Merge request !5remove second period from output when there are no vacancy announcements → (Open) created by Unnamed author
kd_ace → changed the visibility of the branch 2.0.x to hidden.
Recreated mr with new name to properly apply patch. Tested and confirmed via the issue summary steps to reproduce that the text is now corrected. Suggesting to moved to rtbc status.
- 🇺🇸United States jvest
Have reviewed the merge request 2.0.x MR !4 and tested the diff as a patch, steps were:
Reproduced Issue:
Used existing Drupal 10.2 install
Installed usagov module
Configured with user agent and auth key in services/usajobs
Set to Organization = 11th Wing (known to not have any jobs to display)
Added block to homepage sidebar.
Resulted in the double periods being displayed:
Test For merge diff to fix:
Added the merge diff to composer.json:
"drupal/usajobs": {
"3439485: if (empty($markup)) sentence is grammatically incorrect. (Double Period)":
"https://git.drupalcode.org/project/usajobs/-/merge_requests/4.diff"
},Run composer install.
Results in only 1 period being displayed.
Test is successful.
- Status changed to RTBC
about 2 months ago 10:29pm 8 May 2024