- Issue created by @dcam
- 🇺🇸United States dcam
I created a draft MR that disables the
pua
setting and adds thepga4
setting. I had to fix a couple of bugs along the way. Thepua
setting was being cast into anint
by the form. This appears to have been copied and pasted from other settings. Also, the module's settings schema type needed to be changed to aconfig_object
. Saving the config form resulted in an error and failure to save unless this change was made.I need to look up the deprecation procedures for config properties and see if there's more to do for that. But that can wait until after lunch.
I think we should wait until June 25 to copy the DAP JS into the local files.
- 🇺🇸United States jrglasgow Idaho
@dcam,
This looks good, I assume that once the JS is released next week you will update your branch to include it. When that is done go ahead and merge in your changes (I have made you a maintainer) and then create a new release. - 🇺🇸United States dcam
@jrglasgow Yeah, I'll take care of it. Thank you for entrusting me with maintainer status.
- 🇺🇸United States dcam
The new JS was released last night. I'm working on it now.
- Status changed to Fixed
10 months ago 3:50pm 25 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.