Automated Drupal 11 compatibility fixes for plugin

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.2
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.3

I took a look with the Upgrade Status module and there are 28 problems

• 25 issues with functionality provided by this module which was marked "Deprecated as of Plugin 8.x-2.0*. Scheduled for removal before 8.x-3.0". There was no documentation about replacement functionality hat I saw, and work on 3.0.x is not even begun as far as I can tell.
• "Call to deprecated function assert_options()." which is "This function has been DEPRECATED as of PHP 8.3.0. Relying on this function is highly discouraged." but not yet scheduled fr removal in a specific PHP version
• "Call to deprecated method getName() of interface Drupal\Core\Extension\ModuleHandlerInterface. Deprecated in drupal:10.3.0 and is removed from drupal:12.0.0. Use Drupal::service('extension.list.module')->getName($module) instead." which doesn't need to be removed yet and its removal would removed backwards compatibility.

I have updated composer.json and plugin.info.yml in this fork.

Seeing error running phpunit test on file:
- tests/src/Unit/Plugin/Plugin/PluginSelector/AdvancedPluginSelectorBaseTest.php

https://git.drupalcode.org/issue/plugin-3433935/-/jobs/2636647

    Drupal\Tests\plugin\Unit\Plugin\Plugin\PluginSelector\AdvancedPluginSelectorBaseTest::testbuildMultipleAvailablePlugins
    PHPUnit\Framework\MockObject\MethodCannotBeConfiguredException: Trying to
    configure method "buildPluginForm" which cannot be configured because it
    does not exist, has not been specified, is final, or is static

https://www.drupal.org/project/drupal/issues/3130606 →
"setMethods()" is deprecated, and should be using "onlyMethods()"

Testing this file throws errors, but they exist on the current version:
- tests/src/Unit/PluginType/PluginTypeManagerTest.php

The following classes are undefined, and not pulled in through the project composer.json file:

use org\bovigo\vfs\vfsStream;
use org\bovigo\vfs\vfsStreamDirectory;
use org\bovigo\vfs\vfsStreamWrapper;

... so taking no action here as it pertains to D11 upgrade.

Testing this also throws errors - I think this is because the interface to add a field has been changed by Drupal (around 10.3?) to where a content admin must select the field type first, then move on to the next screen.
- tests/src/Functional/PluginSelectorTest.php

Again, these deprecations exist in the current version so does not seem to be something that is introduced by this patch.

Tested on:
- Drupal 11.0.1
- PHP 8.3.10
- MySQL 8.0.19

Verified:
- Plugin configuration can be viewed (/admin/structure/plugin)
- Plugin details can be viewed (/admin/structure/plugin/block for example)
- Plugin reference field can be added to an entity
- Plugin reference field can be viewed

Automated tests needed updates (committed on the issue fork).
These tests will fail, but this is not new on this patch (issues exist in current version):
- tests/src/Unit/Plugin/Plugin/PluginSelector/AdvancedPluginSelectorBaseTest.php
- tests/src/Functional/PluginSelectorTest.php

RTBC +1