Signature of Declaration SamlSPMetadata::builder does not match One Login

Created on 5 June 2024, 23 days ago
Updated 19 June 2024, 9 days ago

Problem/Motivation

After upgrading pas 4.2.0 the dependency for One Login also updates and the signiture of the builder function in SamlSPMetadata no longer matches what is needed. This will white screen the saml_sp configuration page with a PHP error

PHP Fatal error: Declaration of Drupal\\saml_sp\\SAML\\SamlSPMetadata::builder($sp, $authnsign = false, $wsign = false, $validUntil = null, $cacheDuration = null, $contacts = [], $organization = [], $attributes = []) must be compatible with OneLogin\\Saml2\\Metadata::builder($sp, $authnsign = false, $wsign = false, $validUntil = null, $cacheDuration = null, $contacts = [], $organization = [], $attributes = [], $ignoreValidUntil = false) in /var/www/web/modules/contrib/saml_sp/src/SAML/SamlSPMetadata.php on line 17, referer: http://localhost/admin/config

Steps to reproduce

After upgrading past 4.2.0 got to the saml_sp configuration page.

Proposed resolution

Update the signature of the builder function in SamlSPMetadata.php class

πŸ› Bug report
Status

Fixed

Version

4.0

Component

Code

Created by

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024