Drupal 11 compatibility

Created on 12 July 2024, 4 months ago
Updated 12 September 2024, 2 months ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

RTBC

Version

1.0

Component

Code

Created by

🇺🇸United States jrglasgow Idaho

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @jrglasgow
  • Merge request !5Issue #3461089: Drupal 11 compatibility → (Open) created by jrglasgow
  • Status changed to RTBC 4 months ago
  • 🇮🇳India dev16.addweb

    Hello,

    I have tested MR !5 and it's applied successfully. I've also checked that into Drupal 11 and it's working as expected as well.

  • 🇫🇷France opi

    Same here, adding https://git.drupalcode.org/project/classy/-/merge_requests/5.patch to my composer.json makes upgrade_status module happy ! And it works well with my theme.

  • 🇪🇸Spain alvarodemendoza

    Attaching the MR5 patch

  • 🇬🇧United Kingdom ice70

    Tried both patches just in case there was a difference:
    https://www.drupal.org/project/classy/issues/3461089#comment-15720455 🐛 Drupal 11 compatibility RTBC
    https://www.drupal.org/project/classy/issues/3461089#comment-15743743 🐛 Drupal 11 compatibility RTBC

    but both gave the same result in upgrade_status 4.3.5: classy: 1263 warnings found.
    They are all depreciation notices, nearly all of the first one in the list:

    1. vendor\symfony\deprecation-contracts\function.php 25 Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated
    2. dropbutton-wrapper.html.twig 13 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
    3. link-formatter-link-separate.html.twig 15 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.

    4. select.html.twig 13 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
    5. toolbar.html.twig 30 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.

    On php 8.3.11 & drupal 10.3.5

  • 🇩🇪Germany eric-alexander schaefer Munich

    After I upgraded to Drupal 10.3.6 all of the many "Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated" went away. Left were only the "spaceless" warnings. I tried to get rid of them though a combination of simply putting short passages onto one single line and in some cases I used "whitespace-control". After that all warnings were gone.

    Please review the attached patch. I am not a twig expert and I might have screwed it up completely. Also, the last time I rolled a patch was probably more than a decade ago... :D

    PHP 8.3.12
    Drupal 10.3.6

  • 🇩🇪Germany eric-alexander schaefer Munich

    Is there anything I can do to move this forward?

Production build 0.71.5 2024