- Issue created by @jrglasgow
- Status changed to RTBC
4 months ago 11:20am 16 July 2024 - 🇮🇳India dev16.addweb
Hello,
I have tested MR !5 and it's applied successfully. I've also checked that into Drupal 11 and it's working as expected as well.
- 🇫🇷France opi
Same here, adding
https://git.drupalcode.org/project/classy/-/merge_requests/5.patch
to my composer.json makes upgrade_status module happy ! And it works well with my theme. - 🇬🇧United Kingdom ice70
Tried both patches just in case there was a difference:
https://www.drupal.org/project/classy/issues/3461089#comment-15720455 🐛 Drupal 11 compatibility RTBC
https://www.drupal.org/project/classy/issues/3461089#comment-15743743 🐛 Drupal 11 compatibility RTBCbut both gave the same result in upgrade_status 4.3.5: classy: 1263 warnings found.
They are all depreciation notices, nearly all of the first one in the list:- vendor\symfony\deprecation-contracts\function.php 25 Since twig/twig 3.12: Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated
- dropbutton-wrapper.html.twig 13 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
- select.html.twig 13 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
- toolbar.html.twig 30 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
link-formatter-link-separate.html.twig 15 Since twig/twig 3.12: Twig Filter "spaceless" is deprecated. See https://drupal.org/node/3071078.
On php 8.3.11 & drupal 10.3.5
- 🇩🇪Germany eric-alexander schaefer Munich
After I upgraded to Drupal 10.3.6 all of the many "Getting node "filter" on a "Twig\Node\Expression\FilterExpression" class is deprecated" went away. Left were only the "spaceless" warnings. I tried to get rid of them though a combination of simply putting short passages onto one single line and in some cases I used "whitespace-control". After that all warnings were gone.
Please review the attached patch. I am not a twig expert and I might have screwed it up completely. Also, the last time I rolled a patch was probably more than a decade ago... :D
PHP 8.3.12
Drupal 10.3.6 - 🇩🇪Germany eric-alexander schaefer Munich
Is there anything I can do to move this forward?