Account created on 4 April 2023, over 1 year ago
#

Merge Requests

More

Recent comments

πŸ‡§πŸ‡ͺBelgium Jonasanne

This fix has been included in 10.3.x so I guess this issue can me closed and assumed fixed?

πŸ‡§πŸ‡ͺBelgium Jonasanne

I made a small mistake with the prev patch.
Goodmorning :D

πŸ‡§πŸ‡ͺBelgium Jonasanne

Added a diff from merge request for ease of use as patch.

Thankyou @scott_euser for updating this.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I accidentally uploaded the wrong patch.

This one works correctly for me at 10.3.2

πŸ‡§πŸ‡ͺBelgium Jonasanne

I Replace deprecated watchdog_exception() with \Drupal\Core\Utility\Error::logException()

- Inject logger service into the File class.
- Update logResults method to use \Drupal\Core\Utility\Error::logException() for logging exceptions.
- Ensure proper dependency injection and autoloading configuration.

PHPUNIT testing still fails and needs to be checked
We also need to wait on a new D11 ready release of drupal/monitoring

πŸ‡§πŸ‡ͺBelgium Jonasanne

+1
Can we please have a new release D11 compatible?

Kind regards,

πŸ‡§πŸ‡ͺBelgium Jonasanne

Hi Dieter,

I tested everything this morning, and it all seems to be working well in one of our projects. I've also created a merge request.

If there's anything else I need to do, please let me know.

Best regards,

πŸ‡§πŸ‡ͺBelgium Jonasanne

I have made the summarized changes. However, it still needs to be tested with a valid Flexmail account since I don't have one at the moment.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ created an issue.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I did the changes and tested it with upgrade status.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Uploaded patch here for ease of use

πŸ‡§πŸ‡ͺBelgium Jonasanne

I tested this on 10.2.6 with php 8.1 (branch 2.0.x and branch 3.0.x) and on 10.3.0 with 8.3 while following the steps above and I do not have the error.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I tested this PR inside configuration inspector and it looks good.


πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ changed the visibility of the branch CozyDrupalNerd-2.0.x-patch-a239 to active.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ changed the visibility of the branch CozyDrupalNerd-2.0.x-patch-a239 to hidden.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I updated the file with the correct naming conventions and tested it in config inspector.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I added the config schema for view area plugin and tested it via the configurator inspector.
No warnings or errors.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ changed the visibility of the branch 3376126-config-schema-missing to active.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ changed the visibility of the branch 3376126-config-schema-missing to hidden.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I like this proposition. I also updated the issue information.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I updated the check with the correct modules and tested this again.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I added the defensive check to see if menu module is enabled.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I removed the version from the library file

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ changed the visibility of the branch 3457317-fatal-error-when to hidden.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I added the icon to the field_ui form and encoded it to a base_64.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jonasanne β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ͺBelgium Jonasanne

As proposed from @vlad.dancer I created a patch to check the block type.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Just checking in for an update.
Also, I'm happy to help out with co-maintaining if needed.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Jelle_S and I did some research together on how to reproduce this on a clean Drupal install:

  1. Install and enable the menu_multilingual and block_field modules
  2. Create a field on a node or a paragraph with type 'Block (plugin)' and set display mode to 'block field'
  3. Edit the field or paragraph and set the field value to a menu reference
  4. View the node

I updated the issue summary and this issue also accurs on 2.0.0

πŸ‡§πŸ‡ͺBelgium Jonasanne

In this code modification, I enhanced the UserMailUniqueValidator class in the UserMailUniqueValidator.php file. The changes involve refactoring the constructor to leverage property promotion, which is a feature introduced in PHP 8.0. This helps simplify the code by declaring and initializing class properties directly within the constructor parameters.

Here's a breakdown of the changes:
Property Promotion in Constructor:

I replaced the individual property declarations and assignments in the constructor with property promotion.
Introduced property promotion for the AuthmapInterface, OpenidConnectRealmManagerInterface, EntityFieldManagerInterface, and EntityTypeManagerInterface properties.

Constructor Parameter Removal:
Removed the unnecessary parameters from the constructor, as property promotion takes care of both declaration and initialization.

Dependency Injection Enhancement:
Updated the create method to include the new dependencies (EntityFieldManagerInterface and EntityTypeManagerInterface) when instantiating the class.

πŸ‡§πŸ‡ͺBelgium Jonasanne

I created a small patch for this issue.

πŸ‡§πŸ‡ͺBelgium Jonasanne

Has there been an update on this issue?
I still have this problem in D10.1.4.

Production build 0.71.5 2024