Account created on 4 April 2023, about 2 years ago
#

Merge Requests

More

Recent comments

🇧🇪Belgium Jonasanne

Has there been an update for a D11 ready release?

🇧🇪Belgium Jonasanne

Latest D11 patch does not apply

This one does:

🇧🇪Belgium Jonasanne

Latest D11 patch does not apply

This one does:

🇧🇪Belgium Jonasanne

What's the status here?
Can we get a D11 compatible release please?

🇧🇪Belgium Jonasanne

We are having the same issue where results are 0 and that the render is not working correctly.
I tested this MR and I can confirm this works.
also uploaded diff of MR as patch.

🇧🇪Belgium Jonasanne

Uploading the diff as a patch here for ease of use.

🇧🇪Belgium Jonasanne

Aleix are u sure the answer above is on the correct ticket?
I don't understand why you closed this ticket to fixed and the geofield_map require is still inside the compose.json in the new release.

🇧🇪Belgium Jonasanne

New patch against 2.x

🇧🇪Belgium Jonasanne

Nevermind patch does not apply after change to target branch 2.0.x instead of 2.x.
I'm also confused. What's the difference here and why these branch names?

🇧🇪Belgium Jonasanne

uploading diff of MR as patch here.

🇧🇪Belgium Jonasanne

tested and can cofirm it's ok.
Can we get a merge please?

🇧🇪Belgium Jonasanne

@flyke
When I check git.drupalcode.org and change the target branch to 2.0.x, it does not say anything about a merge conflict.

Can you give me some more information about the warnings?
Drupal version, steps to reproduce, and whether you see this warning while using these changes or without them.

🇧🇪Belgium Jonasanne

I created a MR since monitoring has a D11 compatible version.
Can we get a merge and a new D11 ready release?
Thanks!

🇧🇪Belgium Jonasanne

Checked the module with upgrade_status and this MR would be enough.

Can we get a release please?

🇧🇪Belgium Jonasanne

I converted Jelle his changes into a MR and added the change in monitoring.schema.yml.

Also uploaded the diff of the MR as patch here.

🇧🇪Belgium Jonasanne

Can we get a merge and a new release?
I tested the module with upgrade status and these changes look ok.

🇧🇪Belgium Jonasanne

Can we get a new release?
This has been merged but no release since.

🇧🇪Belgium Jonasanne

I have tested this MR and can confirm that it fixes the problem.

Could we get a new release as soon as possible, please?

I’ve also resolved the merge conflict and included a diff of the merge here for convenience as a patch. Additionally, I’ve removed the comments from the libraries file, as they are not necessary to retain.

Thank you!

🇧🇪Belgium Jonasanne

jonasanne made their first commit to this issue’s fork.

🇧🇪Belgium Jonasanne

uploading the diff of the MR here for easy usage as patch
works on 10.4.x

🇧🇪Belgium Jonasanne

I rerolled the patch from @zero2one to 10.3.10 and made a MR for this.
Also gonna upload the MR diff here as a patch for ease of use.

🇧🇪Belgium Jonasanne

This fix has been included in 10.3.x so I guess this issue can me closed and assumed fixed?

🇧🇪Belgium Jonasanne

I made a small mistake with the prev patch.
Goodmorning :D

🇧🇪Belgium Jonasanne

Added a diff from merge request for ease of use as patch.

Thankyou @scott_euser for updating this.

🇧🇪Belgium Jonasanne

I accidentally uploaded the wrong patch.

This one works correctly for me at 10.3.2

🇧🇪Belgium Jonasanne

I Replace deprecated watchdog_exception() with \Drupal\Core\Utility\Error::logException()

- Inject logger service into the File class.
- Update logResults method to use \Drupal\Core\Utility\Error::logException() for logging exceptions.
- Ensure proper dependency injection and autoloading configuration.

PHPUNIT testing still fails and needs to be checked
We also need to wait on a new D11 ready release of drupal/monitoring

🇧🇪Belgium Jonasanne

+1
Can we please have a new release D11 compatible?

Kind regards,

🇧🇪Belgium Jonasanne

Hi Dieter,

I tested everything this morning, and it all seems to be working well in one of our projects. I've also created a merge request.

If there's anything else I need to do, please let me know.

Best regards,

🇧🇪Belgium Jonasanne

I have made the summarized changes. However, it still needs to be tested with a valid Flexmail account since I don't have one at the moment.

🇧🇪Belgium Jonasanne

I did the changes and tested it with upgrade status.

🇧🇪Belgium Jonasanne

I tested this on 10.2.6 with php 8.1 (branch 2.0.x and branch 3.0.x) and on 10.3.0 with 8.3 while following the steps above and I do not have the error.

🇧🇪Belgium Jonasanne

I tested this PR inside configuration inspector and it looks good.


🇧🇪Belgium Jonasanne

Jonasanne changed the visibility of the branch CozyDrupalNerd-2.0.x-patch-a239 to active.

🇧🇪Belgium Jonasanne

Jonasanne changed the visibility of the branch CozyDrupalNerd-2.0.x-patch-a239 to hidden.

🇧🇪Belgium Jonasanne

I updated the file with the correct naming conventions and tested it in config inspector.

🇧🇪Belgium Jonasanne

I added the config schema for view area plugin and tested it via the configurator inspector.
No warnings or errors.

🇧🇪Belgium Jonasanne

Jonasanne changed the visibility of the branch 3376126-config-schema-missing to active.

🇧🇪Belgium Jonasanne

Jonasanne changed the visibility of the branch 3376126-config-schema-missing to hidden.

🇧🇪Belgium Jonasanne

I like this proposition. I also updated the issue information.

🇧🇪Belgium Jonasanne

I removed the version from the library file

Production build 0.71.5 2024