🇧🇪Belgium @Jonasanne

Converted the patch to a MR so we can easily merge it.

jonasanne → made their first commit to this issue’s fork.

Is it allowed to not choose a child type?
If not, you need the validation imo.

I added validate function and also changed null to string since the schema.yml file says it should have a string and not null.

Please review when possible :)

Also opened a MR

jonasanne → made their first commit to this issue’s fork.

Uploading mr diff as patch for ease of use.

The last patch was a mistake.
I uploaded the new patch that works against 11.2.x

rerolled patch against 11.2.2

Can we get this asap merged please?
Thanks in advance!

jonasanne → created an issue.

Converted the patch into a MR.

I also tested this on 11.2.2 and can confirm it works.
Thanks

I tested this and can confirm it works on D11

jonasanne → created an issue.

Ignore point #2 — that was a mistake.
I would suggest merging this into 3.0.x as soon as possible, and we can create a new branch to fix the remaining issues (which I’d be happy to contribute to).

jonasanne → created an issue.

Looks good for me!

jonasanne → created an issue.

I tested this and can confirm it works.
But there is another problem. In the AdminToolbarVersionSettingsForm.php file there is an extend on ConfigFormBase and this constructor requires TypedConfigManagerInterface in D11 and optional in D10 but that means it's not compatible with d8 and d9.
So it should be removed.

I closed the MR and made the changes in a patch.
Because of Tim, I noticed that this MR was not BC and would create errors on D8 and 9.
So there needs to be a major release with this patch.

I added d11 support and fixed 1 critical issue while testing on D11.
Tested this by going through the settings form and just testing all the options.

I also think we can remove d8 support?

jonasanne → created an issue.

jonasanne → created an issue.

Hey Steven,
Tested this on D11 and can confirm everything still works.
This can be merged and a D11 release can be made.

This fixes the issue of the previous comment

When upgrading to 11.2 and trying to run database updates I get this error:

PHP Fatal error:  Cannot use Drupal\Core\Config\Entity\ConfigEntityUpdater as ConfigEntityUpdater because the name is already in use in /var/www/html/web/core/modules/system/system.post_update.php on line 12

Fatal error: Cannot use Drupal\Core\Config\Entity\ConfigEntityUpdater as ConfigEntityUpdater because the name is already in use in /var/www/html/web/core/modules/system/system.post_update.php on line 12
 [warning] Drush command terminated abnormally.

Can we get a release please?

Can we get a release please?

Hey,
Just wanna follow up here.
What's the status here?
Are we still waiting for something?

jonasanne → created an issue.

I can confirm this fixes the problem.
I also created a MR based on the patch of @Zero2one (thanks)

Can we get a review, merge and release please?

Thanks!

jonasanne → made their first commit to this issue’s fork.

I'm having the same issue in Drupal 11.
When I add the formatter this works perfectly when logged in.
not logged in this is completely broken.

What's the status here?

#140 does not apply to 11.1.7 so uploaded a new diff of the MR.

My vote:
- Joris Vercammen (borisson_)

Can we get a D11 compatible release please?

Can we get a release please?

Can we get a merge and a d11 compatible release here please?

Can we please get a release?

This is my mistake.
I was to quick assuming it was a different issue but it's the fault of the D11 patch.
Closing this issue again since it's a duplicate.

jonasanne → created an issue.

Can we get this merged and a D11 stable release?
We need this to make the RNG module D11 compatible.

bramdriesen → credited jonasanne → .

Created a MR with the necessary changes.
Can we get a merge and a new d11 compatible release?
Thanks

jonasanne → created an issue.

jonasanne → created an issue.

I created a MR with the necessary changes.
Upgrade status still flags 1 deprecation but for D12 so we are safe in D11.
Added diff of MR to use as patch.

jonasanne → created an issue.

I made a MR.
Can we get this merged and a D11 compatible release?
Thanks in advance.

jonasanne → changed the visibility of the branch 3521691-add-d11-support to hidden.

jonasanne → created an issue.

jonasanne → changed the visibility of the branch 3521565-add-d11-support to active.

jonasanne → changed the visibility of the branch 3521565-add-d11-support to hidden.

jonasanne → changed the visibility of the branch 3521565-add-d11-support to hidden.

Created a MR.
Can we get this reviewed and merged for a d11 compatible release please?

Thanks!
Also added diff of MR to use as patch.

jonasanne → created an issue.

Uploaded diff of MR as patch for ease of use.

Can we get a D11 compatible release version please?

Can we get a D11 compatible release please?

rerolled patch to 3.0.0-beta1
Now I don't have time to fix the other tests so if someone else wants to pick this up that would also be awesome.

jonasanne → made their first commit to this issue’s fork.

borisson_ → credited jonasanne → .

bramdriesen → credited jonasanne → .

patch reroll

Uploaded MR diff as patch for ease of use

Has there been an update for a D11 ready release?

borisson_ → credited jonasanne → .

Can we get a release here?

jonasanne → created an issue.

rerolled patch to 3.0.0-alpha4

jonasanne → created an issue.

Latest D11 patch does not apply

This one does:

Latest D11 patch does not apply

This one does:

bramdriesen → credited jonasanne → .

What's the status here?
Can we get a D11 compatible release please?

jonasanne → created an issue.

We are having the same issue where results are 0 and that the render is not working correctly.
I tested this MR and I can confirm this works.
also uploaded diff of MR as patch.

bramdriesen → credited jonasanne → .

Uploading the diff as a patch here for ease of use.

Can we get a merge and release please?

jonasanne → made their first commit to this issue’s fork.

Aleix are u sure the answer above is on the correct ticket?
I don't understand why you closed this ticket to fixed and the geofield_map require is still inside the compose.json in the new release.

New patch against 2.x

added mr as patch

Nevermind patch does not apply after change to target branch 2.0.x instead of 2.x.
I'm also confused. What's the difference here and why these branch names?