- Issue created by @JeroenT
- Status changed to Needs review
almost 2 years ago 5:02pm 27 February 2023 - 🇬🇧United Kingdom aaron.ferris
Patch makes sense to me, if I'm being super pedantic there's a typo in successfull though :)
successfull = successful
- 🇮🇳India Jaspreet-Kaur
Reviewed! Patch #3 fixed the issues. successfully applied on Drupal 9.5.x
- last update
over 1 year ago 18 pass - 🇬🇧United Kingdom aaron.ferris
Updated patch with fixed spelling as mentioned previously.
- last update
over 1 year ago Patch Failed to Apply Hi, I experience another issue related to the same `require` option. The option is defined as a boolean in the `Drupal\search_api_location_views\Plugin\views\filter\SearchApiFilterLocation::defineOptions()`, when the `Drupal\views\Plugin\views\PluginBase::setOptionDefaults()` expects every option in the plugin to be an associative array that at least contains the `default` key. The patch fixes the mentioned issue and includes the patch from #7.
Warning: Trying to access array offset on value of type bool in Drupal\views\Plugin\views\PluginBase->setOptionDefaults() (line 187 of core/modules/views/src/Plugin/views/PluginBase.php).
- 🇳🇱Netherlands Krilo_89
@akrrev, indeed! I discovered the same issue.
Maybe @JeroenT can create a new alpha4 tag with the newest commits? The only additions are the readme file and the fix for the 'require' option.
- 🇧🇪Belgium stefdewa
Stefdewa → changed the visibility of the branch 3343987-missing-config-schema to hidden.
- 🇧🇪Belgium stefdewa
Stefdewa → changed the visibility of the branch 3343987-missing-config-schema to active.
- 🇬🇧United Kingdom rossb89 Bristol
Made a new MR for this as the previous branch for this ticket hadn't been setup properly.
- 🇧🇪Belgium Jonasanne
uploading the diff of the MR here for easy usage as patch
works on 10.4.x