Account created on 11 February 2013, over 11 years ago
#

Merge Requests

Recent comments

πŸ‡§πŸ‡ͺBelgium Stefdewa

Stefdewa β†’ changed the visibility of the branch 3343987-missing-config-schema to active.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Stefdewa β†’ changed the visibility of the branch 3343987-missing-config-schema to hidden.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Stefdewa β†’ changed the visibility of the branch 2857402-domain-access-for to hidden.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Bumping version so I can create a merge request for the active development branch.

πŸ‡§πŸ‡ͺBelgium Stefdewa

On D10.2.2 I got Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "maintenance_mode_subscriber" because of the overriding maintenance_mode service.

Added a new patch (and interdiff) for a fix.

It is probably better to use a service decorator here instead of overriding the service. Leaving that suggestion here for another day/person.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Confirming MR16 works when using Drupal 10.1.4, Monolog 3.0.1 and svg_image 3.0.1.

πŸ‡§πŸ‡ͺBelgium Stefdewa

At the time that I created this issue, the problem was resolved for me when I used the two patches from #4. I agree that you don't include the patch I created because the problem should be solved upsteam. User joco_sp can still use the patch here if the patches didn't work for him for some reasen. I would keep this issue 'Closed' and wait until at least the core issue is resolved. Then, test again and revaluate.

πŸ‡§πŸ‡ͺBelgium Stefdewa

I also required this to fix what is mentioned in #4. After applying the fix, the module still works for me. So setting to RTBC.

πŸ‡§πŸ‡ͺBelgium Stefdewa

The issue is fixed in Drupal 10.1.2 . Issue πŸ› When AssetControllerBase delivers existing file should add content-type Fixed makes sure the correct Content-Type is specified (Fix in code: https://git.drupalcode.org/project/drupal/-/commit/6c8799d135b23bfadbf43... ). Lowering priority to 'Normal'.

Nonetheless, we can go forward with the change here because that reduces website calls.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Created a new MR based on the feedback of Berdir in #12 .

A sidenote: the function _token_core_supported_modules is no longer used but I kept it in because it was inside a comment in the install file.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Stefdewa β†’ made their first commit to this issue’s fork.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Added patch that puts the form alter code in a seperate function and use that function to also add the cshs to the widget from the menu_link module.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Patch loads the menus and uses their label as value where the key is the menu machine name.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Correct me if I'm wrong, I'm bumping the version to 2.0.x-dev because that's maintained. Added patch that url decodes the source url in migrate.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Updated test to use 'stark' instead of 'classy' as default theme.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Created MR that does what is asked.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Opened MR that does exactly this:

Increase this module's weight so alters from other modules (with weight 0) are run first. This way, when the page_cache_maximum_age options are re-used, the alters have run.

πŸ‡§πŸ‡ͺBelgium Stefdewa

Having the same problem and the patch in #4 fixed it for me.

For me, the problem only happens in the backend. I'm using Drupal 9.5.2 with backend theme gin 3.0.0-rc1 .

Production build 0.69.0 2024