Sorry I didn't test it properly with empy values. Your MR looks good to me. I tested the list_classes configuration on my end with NULL, an empty string '', a string with one class and a string with multiple classes. This all works and the ToC keeps being generated without any erros in console.
Sure, no problem!
We are creating a sticky ToC that can be navigated like a slider. For that, we are combining this awesome toc_js module with a custom splide component. (Splide is a lightweight slider/carousel library, more info at https://splidejs.com/ ). The Toc.js module handles the automatic ToC generation and the splide component handles the slider behaviour.
A requirement for using the splide component is that specific classes are set on both the list (UL) and on the list items (LI). Adding classes on the list items is already possible, but adding classes on the list was not yet possible. Because adding classes was already possible for list items, it seems feasible that it would be OK to have this possibility for the list itself. Therefore, I added it here as a new feature.
Feel free to ask for more information if you need any!
Create MR for the feature request.
stefdewa → created an issue.
Discussed with grietdk IRL.
Renamed recipes.README.txt to recipes.README.md (and updated composer.lock hash).
stefdewa → made their first commit to this issue’s fork.
I looked into updating the tests, specifically the failing tests from
core/modules/ckeditor5/tests/src/Kernel/CKEditor5PluginManagerTest::testInvalidPluginDefinitions
which calls
core/modules/ckeditor5/tests/src/Kernel/CKEditor5PluginManagerTest::providerTestInvalidPluginDefinitions.
The provider returns YAML with invalid ckeditor5 plugin definitions. The way I understand it, this YAML should define a FilterFormat that the ckeditor5 Editor uses. But how... that is not clear to me. Anyone have an idea on how this is done?
Updated MR with latest changes and fixed phpcs violations. Getting the tests green was a bit of a stretch for me. I'm leaving that for anyone with more knowledge of the expierence builder itself.
Having a go at the reroll and fixing the pipeline errors, at Drupalcon Barcelona.
Reviewed MR38, tested manually and it works!
This is no longer an issue on current 3.x. The logger instance is no longer passed in the constructor. This was changed in 🐛 SvgImageUrlFormatter parent construct wrong order Needs review which is part of 3.0.2.
I also manually tested and the error no longer occurs.
Stefdewa → changed the visibility of the branch 3343987-missing-config-schema to active.
Stefdewa → changed the visibility of the branch 3343987-missing-config-schema to hidden.
Stefdewa → changed the visibility of the branch 2857402-domain-access-for to hidden.
Bumping version so I can create a merge request for the active development branch.
On D10.2.2 I got Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "maintenance_mode_subscriber" because of the overriding maintenance_mode service.
Added a new patch (and interdiff) for a fix.
It is probably better to use a service decorator here instead of overriding the service. Leaving that suggestion here for another day/person.
Confirming MR16 works when using Drupal 10.1.4, Monolog 3.0.1 and svg_image 3.0.1.
Stefdewa → created an issue.
Yes, this seems merged https://git.drupalcode.org/project/node_keep/-/merge_requests/2 .
At the time that I created this issue, the problem was resolved for me when I used the two patches from #4. I agree that you don't include the patch I created because the problem should be solved upsteam. User joco_sp can still use the patch here if the patches didn't work for him for some reasen. I would keep this issue 'Closed' and wait until at least the core issue is resolved. Then, test again and revaluate.
I also required this to fix what is mentioned in #4. After applying the fix, the module still works for me. So setting to RTBC.
Created MR.
Stefdewa → created an issue.
The issue is fixed in Drupal 10.1.2 . Issue 🐛 When AssetControllerBase delivers existing file should add content-type Fixed makes sure the correct Content-Type is specified (Fix in code: https://git.drupalcode.org/project/drupal/-/commit/6c8799d135b23bfadbf43... ). Lowering priority to 'Normal'.
Nonetheless, we can go forward with the change here because that reduces website calls.
Created a new MR based on the feedback of Berdir in #12 .
A sidenote: the function _token_core_supported_modules is no longer used but I kept it in because it was inside a comment in the install file.
Stefdewa → made their first commit to this issue’s fork.
Stefdewa → created an issue.
Stefdewa → created an issue.
Added patch that puts the form alter code in a seperate function and use that function to also add the cshs to the widget from the menu_link module.
Stefdewa → created an issue.
Patch loads the menus and uses their label as value where the key is the menu machine name.
Stefdewa → created an issue.
Correct me if I'm wrong, I'm bumping the version to 2.0.x-dev because that's maintained. Added patch that url decodes the source url in migrate.
Updated test to use 'stark' instead of 'classy' as default theme.
Created MR that does what is asked.
Stefdewa → created an issue.
Opened MR that does exactly this:
Increase this module's weight so alters from other modules (with weight 0) are run first. This way, when the page_cache_maximum_age options are re-used, the alters have run.
Stefdewa → created an issue. See original summary → .
Having the same problem and the patch in #4 fixed it for me.
For me, the problem only happens in the backend. I'm using Drupal 9.5.2 with backend theme gin 3.0.0-rc1 .